github-mirror/framework
2
0
Fork 0
mirror of https://github.com/flarum/framework.git synced 2024-12-12 14:13:37 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Performance improvements

Browse Source
This commit is contained in:
Toby Zerner 2015-05-21 06:49:07 +09:30
parent ec65a15767
commit 8f7e563036
2 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
framework/core/js/forum/src/components/discussion-list.js
View File

@ -125,7 +125,10 @@ export default class DiscussionList extends Component {
var active = m.route().substr(0, discussionRoute.length) === discussionRoute;
var subtree = this.subtrees[discussion.id()];
return m('li.discussion-summary'+(isUnread ? '.unread' : '')+(active ? '.active' : ''), {key: discussion.id(), 'data-id': discussion.id()}, (subtree && subtree.retain()) || m('div', [
return m('li.discussion-summary'+(isUnread ? '.unread' : '')+(active ? '.active' : ''), {
key: discussion.id(),
'data-id': discussion.id()
}, (subtree && subtree.retain()) || m('div', [
controls.length ? DropdownButton.component({
items: controls,
className: 'contextual-controls',

7
framework/core/js/forum/src/components/discussion-page.js
View File

@ -38,10 +38,11 @@ export default class DiscussionPage extends mixin(Component, evented) {
if (app.cache.discussionList) {
if (!(app.current instanceof DiscussionPage)) {
app.cache.discussionList.subtrees.map(subtree => subtree.invalidate());
} else {
m.redraw.strategy('diff'); // otherwise pane redraws (killing retained subtrees) and mouseenter even is triggered so it doesn't hide
}
app.pane.enable();
app.pane.hide();
m.redraw.strategy('diff'); // otherwise pane redraws and mouseenter even is triggered so it doesn't hide
}
app.history.push('discussion');
@ -57,7 +58,9 @@ export default class DiscussionPage extends mixin(Component, evented) {
params.include = params.include.join(',');
app.store.find('discussions', m.route.param('id'), params).then(this.setupDiscussion.bind(this));
m.redraw();
// Trigger a redraw only if we're not already in a computation (e.g. route change)
m.startComputation();
m.endComputation();
}
params() {