github-mirror/framework
github-mirror/framework
2
0
Fork 0
mirror of https://github.com/flarum/framework.git synced 2025-02-22 07:19:56 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Only migrate enabled extensions when upgrading

Browse Source 
Also remove the Extension::install() and Extension::uninstall()
methods, because they add nothing that can't be done with migrations.
This commit is contained in:
Toby Zerner 2015-08-31 14:35:52 +09:30
parent 5f9f42dc4b
commit 9024cabcb3
3 changed files with 12 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
framework/core/src/Console/UpgradeCommand.php
View File

@ -68,9 +68,13 @@ class UpgradeCommand extends Command
$migrator = $extensions->getMigrator(); $migrator = $extensions->getMigrator();
foreach ($extensions->getInfo() as $extension) { foreach ($extensions->getInfo() as $extension) {
if (! $extensions->isEnabled($extension->name)) {
continue;
}
$this->info('Upgrading extension: '.$extension->name); $this->info('Upgrading extension: '.$extension->name);
$extensions->enable($extension->name); $extensions->migrate($extension->name);
foreach ($migrator->getNotes() as $note) { foreach ($migrator->getNotes() as $note) {
$this->info($note); $this->info($note);

8
framework/core/src/Support/Extension.php
View File

@ -15,14 +15,6 @@ use Illuminate\Events\Dispatcher;
class Extension extends ServiceProvider class Extension extends ServiceProvider
{ {
public function install()
{
}
public function uninstall()
{
}
public function listen(Dispatcher $events) public function listen(Dispatcher $events)
{ {
} }

15
framework/core/src/Support/ExtensionManager.php
View File

@ -48,15 +48,11 @@ class ExtensionManager
public function enable($extension) public function enable($extension)
{ {
$enabled = $this->getEnabled(); if (! $this->isEnabled($extension)) {
if (! in_array($extension, $enabled)) {
$enabled[] = $extension; $enabled[] = $extension;
$class = $this->load($extension); $class = $this->load($extension);
$class->install();
$this->migrate($extension); $this->migrate($extension);
$this->setEnabled($enabled); $this->setEnabled($enabled);
@ -80,12 +76,10 @@ class ExtensionManager
$class = $this->load($extension); $class = $this->load($extension);
$class->uninstall();
$this->migrate($extension, false); $this->migrate($extension, false);
} }
protected function migrate($extension, $up = true) public function migrate($extension, $up = true)
{ {
$migrationDir = base_path('../extensions/' . $extension . '/migrations'); $migrationDir = base_path('../extensions/' . $extension . '/migrations');
@ -119,6 +113,11 @@ class ExtensionManager
$this->config->set('extensions_enabled', json_encode($enabled)); $this->config->set('extensions_enabled', json_encode($enabled));
} }
public function isEnabled($extension)
{
return in_array($extension, $this->getEnabled());
}
protected function load($extension) protected function load($extension)
{ {
if (file_exists($file = $this->getExtensionsDir() . '/' . $extension . '/bootstrap.php')) { if (file_exists($file = $this->getExtensionsDir() . '/' . $extension . '/bootstrap.php')) {