github-mirror/framework
2
0
Fork 0
mirror of https://github.com/flarum/framework.git synced 2024-12-13 15:13:42 +08:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

Revert from a while ago: always append if reference item not found

Browse Source 
API still needs some work though
This commit is contained in:
Toby Zerner 2015-06-23 11:12:37 +09:30
parent 35cd1f3b51
commit 951db23ffd
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
framework/core/js/lib/utils/item-list.js
View File

@ -44,12 +44,18 @@ export default class ItemList {
items.forEach(item => { items.forEach(item => {
var key = item.position.before || item.position.after; var key = item.position.before || item.position.after;
var type = item.position.before ? 'before' : 'after'; var type = item.position.before ? 'before' : 'after';
// TODO: Allow both before and after to be specified, and multiple keys to
// be specified for each.
// e.g. {before: ['foo', 'bar'], after: ['qux', 'qaz']}
// This way extensions can make sure they are positioned where
// they want to be relative to other extensions.
if (key) { if (key) {
var index = array.indexOf(this[key]); var index = array.indexOf(this[key]);
if (index === -1) { if (index === -1) {
index = type === 'before' ? 0 : array.length; array.push(item);
} else {
array.splice(index + (type === 'after' ? 1 : 0), 0, item);
} }
array.splice(index + (type === 'after' ? 1 : 0), 0, item);
} }
}); });