Add todo about query optimization

This commit is contained in:
Toby Zerner 2015-06-16 16:59:48 +09:30
parent 64e6b7d26c
commit 9ac1f53244

View File

@ -22,6 +22,7 @@ class IndexAction extends BaseAction
public function handle(Request $request, $params = []) public function handle(Request $request, $params = [])
{ {
$config = DB::table('config')->whereIn('key', ['base_url', 'api_url', 'forum_title', 'welcome_title', 'welcome_message'])->lists('value', 'key'); $config = DB::table('config')->whereIn('key', ['base_url', 'api_url', 'forum_title', 'welcome_title', 'welcome_message'])->lists('value', 'key');
$data = [];
$session = []; $session = [];
$alert = Session::get('alert'); $alert = Session::get('alert');
@ -40,6 +41,10 @@ class IndexAction extends BaseAction
'token' => Cookie::get('flarum_remember') 'token' => Cookie::get('flarum_remember')
]; ];
// TODO: calling on the API here results in an extra query to get
// the user + their groups, when we already have this information on
// $this->actor. Can we simply run the CurrentUserSerializer
// manually?
$response = app('Flarum\Api\Actions\Users\ShowAction') $response = app('Flarum\Api\Actions\Users\ShowAction')
->handle(new ApiRequest(['id' => $user->id], $this->actor)) ->handle(new ApiRequest(['id' => $user->id], $this->actor))
->content->toArray(); ->content->toArray();