github-mirror/framework
github-mirror/framework
2
0
Fork 0
mirror of https://github.com/flarum/framework.git synced 2025-04-02 23:19:04 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Adjust PostStreamScrubber height after scroll (#2333)

Browse Source
This commit is contained in:
Alexander Skvortsov 2020-10-02 11:13:55 -04:00 committed by GitHub
parent 20b99bcab1
commit a013d647e0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
js/src/forum/components/PostStream.js
View File

@ -345,17 +345,23 @@ export default class PostStream extends Component {
} }
} }
// Even before scrolling, we want to provide location information const updateScrubberHeight = () => {
// to the scrubber as soon as possible. This way, we avoid an unnecessary
// and confusing animation.
this.updateScrubber();
// We manually set the index because we want to display the index of the // We manually set the index because we want to display the index of the
// exact post we've scrolled to, not just that of the first post on the page. // exact post we've scrolled to, not just that of the first post within viewport.
this.updateScrubber();
this.stream.index = index; this.stream.index = index;
};
// If we don't update this before the scroll, the scrubber will start
// at the top, and animate down, which can be confusing
updateScrubberHeight();
this.stream.forceUpdateScrubber = true; this.stream.forceUpdateScrubber = true;
return Promise.all([$container.promise(), this.stream.loadPromise]).then(() => { return Promise.all([$container.promise(), this.stream.loadPromise]).then(() => {
m.redraw.sync(); m.redraw.sync();
// We want to adjust this again after posts have been loaded in so that
// the height of the scrubber is accurate.
updateScrubberHeight();
// After post data has been loaded in, we will attempt to scroll back // After post data has been loaded in, we will attempt to scroll back
// to the top of the requested post (or to the top of the page if the // to the top of the requested post (or to the top of the page if the