github-mirror/framework
github-mirror/framework
2
0
Fork 0
mirror of https://github.com/flarum/framework.git synced 2025-03-10 04:05:30 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix deleting posts/discussions by deleted user (#2521)

Browse Source 
Making the $user argument nullable prevents this unnecessary exception, and doesn't introduce any issues since we check that $user exists as part of the method.
This commit is contained in:
Alexander Skvortsov 2021-01-07 17:46:14 -05:00 committed by GitHub
parent 403ee77c6c
commit a1a2598c03
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
framework/core/src/User/UserMetadataUpdater.php
View File

@ -65,7 +65,7 @@ class UserMetadataUpdater
/** /**
* @param \Flarum\User\User $user * @param \Flarum\User\User $user
*/ */
private function updateCommentsCount(User $user) private function updateCommentsCount(?User $user)
{ {
if ($user && $user->exists) { if ($user && $user->exists) {
$user->refreshCommentCount()->save(); $user->refreshCommentCount()->save();