github-mirror/framework
2
0
Fork 0
mirror of https://github.com/flarum/framework.git synced 2024-11-30 13:36:10 +08:00
Code Issues Actions 26 Packages Projects Releases Wiki Activity

Convert controller test to request test

Browse Source 
This further decouples these tests from the implementation (i.e. which
controller are we calling?).
This commit is contained in:
Franz Liedke 2019-09-04 01:27:24 +02:00
parent 0005da3a0d
commit a7b19284b9
2 changed files with 155 additions and 111 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

111
framework/core/tests/integration/api/Controller/CreateUserControllerTest.php
View File

@ -1,111 +0,0 @@
<?php
/*
* This file is part of Flarum.
*
* (c) Toby Zerner <toby.zerner@gmail.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
namespace Flarum\Tests\integration\api\Controller;
use Flarum\Api\Controller\CreateUserController;
use Flarum\Settings\SettingsRepositoryInterface;
use Flarum\User\User;
use Illuminate\Support\Arr;
class CreateUserControllerTest extends ApiControllerTestCase
{
protected $controller = CreateUserController::class;
protected $data = [
'username' => 'test',
'password' => 'too-obscure',
'email' => 'test@machine.local'
];
public function setUp()
{
parent::setUp();
$this->prepareDatabase([
'users' => [
$this->adminUser(),
],
'groups' => [
$this->adminGroup(),
],
'group_user' => [
['user_id' => 1, 'group_id' => 1],
],
'settings' => [
['key' => 'mail_driver', 'value' => 'log']
]
]);
}
/**
* @test
*/
public function cannot_create_user_without_data()
{
$response = $this->callWith();
$this->assertEquals(422, $response->getStatusCode());
}
/**
* @test
*/
public function can_create_user()
{
$response = $this->callWith($this->data);
$this->assertEquals(201, $response->getStatusCode());
/** @var User $user */
$user = User::where('username', 'test')->firstOrFail();
$this->assertEquals(0, $user->is_activated);
foreach (Arr::except($this->data, 'password') as $property => $value) {
$this->assertEquals($value, $user->{$property});
}
}
/**
* @test
*/
public function admins_can_create_activated_users()
{
$this->actor = User::find(1);
$response = $this->callWith(array_merge($this->data, [
'isEmailConfirmed' => 1
]));
$this->assertEquals(201, $response->getStatusCode());
/** @var User $user */
$user = User::where('username', 'test')->firstOrFail();
$this->assertEquals(1, $user->is_email_confirmed);
}
/**
* @test
*/
public function disabling_sign_up_prevents_user_creation()
{
/** @var SettingsRepositoryInterface $settings */
$settings = app(SettingsRepositoryInterface::class);
$settings->set('allow_sign_up', false);
$response = $this->callWith($this->data);
$this->assertEquals(403, $response->getStatusCode());
$settings->set('allow_sign_up', true);
}
}

155
framework/core/tests/integration/api/users/CreationTest.php Normal file
View File

@ -0,0 +1,155 @@
<?php
/*
* This file is part of Flarum.
*
* (c) Toby Zerner <toby.zerner@gmail.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
namespace Flarum\Tests\integration\api\users;
use Flarum\Settings\SettingsRepositoryInterface;
use Flarum\Tests\integration\RetrievesAuthorizedUsers;
use Flarum\Tests\integration\TestCase;
use Flarum\User\User;
class CreationTest extends TestCase
{
use RetrievesAuthorizedUsers;
public function setUp()
{
parent::setUp();
$this->prepareDatabase([
'users' => [
$this->adminUser(),
],
'groups' => [
$this->adminGroup(),
],
'group_user' => [
['user_id' => 1, 'group_id' => 1],
],
'settings' => [
['key' => 'mail_driver', 'value' => 'log'],
],
'access_tokens' => [
['token' => 'admintoken', 'user_id' => 1],
],
]);
}
/**
* @test
*/
public function cannot_create_user_without_data()
{
$response = $this->send(
$this->request(
'POST', '/api/users',
[
'json' => ['data' => ['attributes' => []]],
]
)->withAttribute('bypassCsrfToken', true)
);
$this->assertEquals(422, $response->getStatusCode());
}
/**
* @test
*/
public function can_create_user()
{
$response = $this->send(
$this->request(
'POST', '/api/users',
[
'json' => [
'data' => [
'attributes' => [
'username' => 'test',
'password' => 'too-obscure',
'email' => 'test@machine.local',
],
]
],
]
)->withAttribute('bypassCsrfToken', true)
);
$this->assertEquals(201, $response->getStatusCode());
/** @var User $user */
$user = User::where('username', 'test')->firstOrFail();
$this->assertEquals(0, $user->is_activated);
$this->assertEquals('test', $user->username);
$this->assertEquals('test@machine.local', $user->email);
}
/**
* @test
*/
public function admins_can_create_activated_users()
{
$response = $this->send(
$this->request(
'POST', '/api/users',
[
'json' => [
'data' => [
'attributes' => [
'username' => 'test',
'password' => 'too-obscure',
'email' => 'test@machine.local',
'isEmailConfirmed' => 1,
],
]
],
]
)->withHeader('Authorization', 'Token admintoken')
);
$this->assertEquals(201, $response->getStatusCode());
/** @var User $user */
$user = User::where('username', 'test')->firstOrFail();
$this->assertEquals(1, $user->is_email_confirmed);
}
/**
* @test
*/
public function disabling_sign_up_prevents_user_creation()
{
/** @var SettingsRepositoryInterface $settings */
$settings = app(SettingsRepositoryInterface::class);
$settings->set('allow_sign_up', false);
$response = $this->send(
$this->request(
'POST', '/api/users',
[
'json' => [
'data' => [
'attributes' => [
'username' => 'test',
'password' => 'too-obscure',
'email' => 'test@machine.local',
],
]
],
]
)->withAttribute('bypassCsrfToken', true)
);
$this->assertEquals(403, $response->getStatusCode());
$settings->set('allow_sign_up', true);
}
}