github-mirror/framework
2
0
Fork 0
mirror of https://github.com/flarum/framework.git synced 2024-12-02 15:03:44 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Avoid calculations in views

Browse Source 
Instead, look up existence of navigation links in the underlying
API document.
This commit is contained in:
Franz Liedke 2018-01-10 20:39:53 +01:00
parent 81c86b726c
commit b491bd1e36
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
framework/core/views/frontend/content/discussion.blade.php
View File

@ -1,9 +1,5 @@
<?php
$discussion = $document->data;
$postsCount = count($discussion->relationships->posts->data);
?>
<div class="container">
<h2>{{ $discussion->attributes->title }}</h2>
<h2>{{ $document->data->attributes->title }}</h2>
<div>
@foreach ($posts as $post)
@ -19,11 +15,11 @@ $postsCount = count($discussion->relationships->posts->data);
@endforeach
</div>
@if ($page > 1)
@if (isset($document->links->prev))
<a href="{{ $url(['page' => $page - 1]) }}">&laquo; {{ $translator->trans('core.views.discussion.previous_page_button') }}</a>
@endif
@if ($page < $postsCount / 20)
@if (isset($document->links->next))
<a href="{{ $url(['page' => $page + 1]) }}">{{ $translator->trans('core.views.discussion.next_page_button') }} &raquo;</a>
@endif
</div>