From c1be00e79a191faefbfa9435bb3508af6b5b2a95 Mon Sep 17 00:00:00 2001
From: Sami Mazouz <sychocouldy@gmail.com>
Date: Tue, 9 Jan 2024 19:01:29 +0100
Subject: [PATCH] chore: improve debugging experience (#3944)

---
 framework/core/js/src/common/Application.tsx        |  4 +++-
 .../js/src/common/components/RequestErrorModal.tsx  | 13 +++++++++++++
 framework/core/less/common/scaffolding.less         |  6 ++++++
 3 files changed, 22 insertions(+), 1 deletion(-)

diff --git a/framework/core/js/src/common/Application.tsx b/framework/core/js/src/common/Application.tsx
index bccc69b18..606b6e2b4 100644
--- a/framework/core/js/src/common/Application.tsx
+++ b/framework/core/js/src/common/Application.tsx
@@ -604,7 +604,9 @@ export default class Application {
         console.groupEnd();
       }
 
-      if (e.alert) {
+      if (e.status === 500 && isDebug) {
+        app.modal.show(RequestErrorModal, { error: e, formattedError: formattedErrors });
+      } else if (e.alert) {
         this.requestErrorAlert = this.alerts.show(e.alert, e.alert.content);
       }
     } else {
diff --git a/framework/core/js/src/common/components/RequestErrorModal.tsx b/framework/core/js/src/common/components/RequestErrorModal.tsx
index b537993dd..b1ee48689 100644
--- a/framework/core/js/src/common/components/RequestErrorModal.tsx
+++ b/framework/core/js/src/common/components/RequestErrorModal.tsx
@@ -30,6 +30,19 @@ export default class RequestErrorModal<CustomAttrs extends IRequestErrorModalAtt
       responseText = error.responseText;
     }
 
+    if (responseText?.includes('<script> Sfdump = window.Sfdump')) {
+      responseText = (
+        <iframe
+          srcdoc={responseText}
+          className="RequestErrorModal-iframe"
+          onload={(e: Event) => {
+            const iframe = e.target as HTMLIFrameElement;
+            iframe.style.height = (iframe.contentWindow?.document.body.offsetHeight || 0) + 50 + 'px';
+          }}
+        />
+      );
+    }
+
     return (
       <div className="Modal-body">
         <pre>
diff --git a/framework/core/less/common/scaffolding.less b/framework/core/less/common/scaffolding.less
index 732e29186..c1e2c05bd 100644
--- a/framework/core/less/common/scaffolding.less
+++ b/framework/core/less/common/scaffolding.less
@@ -137,6 +137,12 @@ blockquote ol:last-child {
     white-space: pre-wrap;
     margin: 0;
   }
+
+  &-iframe {
+    width: 100%;
+    max-height: 90vh;
+    border: 0;
+  }
 }
 
 #flarum-loading {