github-mirror/framework
2
0
Fork 0
mirror of https://github.com/flarum/framework.git synced 2024-12-02 23:23:52 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Migrations: Fix dropping foreign keys

Browse Source 
Passing an array to dropForeign does not mean dropping multiple indices,
but rather dropping a key on multiple tables.

Passing a string means that this string will be interpreted as index
name, not as name of the indexed column. Passing an array with one
string is therefore correct, in order to benefit from automatic index
name generation.
This commit is contained in:
Franz Liedke 2018-11-30 14:02:37 +01:00
parent d6632c061d
commit c23b7f33eb
5 changed files with 15 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
framework/core/migrations/2018_01_11_155300_change_discussions_add_foreign_keys.php
View File

@ -47,10 +47,11 @@ return [
'down' => function (Builder $schema) { 'down' => function (Builder $schema) {
$schema->table('discussions', function (Blueprint $table) use ($schema) { $schema->table('discussions', function (Blueprint $table) use ($schema) {
$table->dropForeign([ $table->dropForeign(['user_id']);
'user_id', 'last_posted_user_id', 'hidden_user_id', $table->dropForeign(['last_posted_user_id']);
'first_post_id', 'last_post_id' $table->dropForeign(['hidden_user_id']);
]); $table->dropForeign(['first_post_id']);
$table->dropForeign(['last_post_id']);
Migration::fixIndexNames($schema, $table); Migration::fixIndexNames($schema, $table);
}); });

3
framework/core/migrations/2018_01_15_071900_change_discussion_user_add_foreign_keys.php
View File

@ -37,7 +37,8 @@ return [
'down' => function (Builder $schema) { 'down' => function (Builder $schema) {
$schema->table('discussion_user', function (Blueprint $table) use ($schema) { $schema->table('discussion_user', function (Blueprint $table) use ($schema) {
$table->dropForeign(['user_id', 'discussion_id']); $table->dropForeign(['user_id']);
$table->dropForeign(['discussion_id']);
Migration::fixIndexNames($schema, $table); Migration::fixIndexNames($schema, $table);
}); });

3
framework/core/migrations/2018_01_18_130700_change_group_user_add_foreign_keys.php
View File

@ -37,7 +37,8 @@ return [
'down' => function (Builder $schema) { 'down' => function (Builder $schema) {
$schema->table('group_user', function (Blueprint $table) use ($schema) { $schema->table('group_user', function (Blueprint $table) use ($schema) {
$table->dropForeign(['user_id', 'group_id']); $table->dropForeign(['user_id']);
$table->dropForeign(['group_id']);
Migration::fixIndexNames($schema, $table); Migration::fixIndexNames($schema, $table);
}); });

3
framework/core/migrations/2018_01_18_133100_change_notifications_add_foreign_keys.php
View File

@ -41,7 +41,8 @@ return [
'down' => function (Builder $schema) { 'down' => function (Builder $schema) {
$schema->table('notifications', function (Blueprint $table) use ($schema) { $schema->table('notifications', function (Blueprint $table) use ($schema) {
$table->dropForeign(['user_id', 'from_user_id']); $table->dropForeign(['user_id']);
$table->dropForeign(['from_user_id']);
Migration::fixIndexNames($schema, $table); Migration::fixIndexNames($schema, $table);
}); });

8
framework/core/migrations/2018_01_18_135100_change_posts_add_foreign_keys.php
View File

@ -43,10 +43,10 @@ return [
'down' => function (Builder $schema) { 'down' => function (Builder $schema) {
$schema->table('posts', function (Blueprint $table) use ($schema) { $schema->table('posts', function (Blueprint $table) use ($schema) {
$table->dropForeign([ $table->dropForeign(['user_id']);
'user_id', 'discussion_id', $table->dropForeign(['discussion_id']);
'edited_user_id', 'hidden_user_id' $table->dropForeign(['edited_user_id']);
]); $table->dropForeign(['hidden_user_id']);
Migration::fixIndexNames($schema, $table); Migration::fixIndexNames($schema, $table);
}); });