github-mirror/framework
github-mirror/framework
2
0
Fork 0
mirror of https://github.com/flarum/framework.git synced 2025-02-24 19:00:29 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Update code to work with latest html5sortable (#62)

Browse Source 
* Update code to work with latest html5sortable (0.9.16)

* Move forEach function callback to constant variable

* Extract inline function into method
This commit is contained in:
David Sevilla Martín 2019-06-03 05:46:48 -04:00 committed by Franz Liedke
parent 6d0de4b29c
commit c65aa52726
3 changed files with 67 additions and 63 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
extensions/tags/js/package-lock.json generated
View File

@ -2779,9 +2779,9 @@
} }
}, },
"html5sortable": { "html5sortable": {
"version": "0.9.8", "version": "0.9.16",
"resolved": "https://registry.npmjs.org/html5sortable/-/html5sortable-0.9.8.tgz", "resolved": "https://registry.npmjs.org/html5sortable/-/html5sortable-0.9.16.tgz",
"integrity": "sha512-QodBiv8LdTZHot3EMzNHTeKn/nHm66BlvmcFvMFMPVm4mYN5S0uKvDxFnzRltFvrIjvps7OVRrxBJQX8aLnxWg==" "integrity": "sha512-GjCFl7w+Z6bQNs6lU5fhPqLoC5aRbFbQtL9rgqGR3Fs0GCRCrGjoRusZkhWaQpMr4eN25BlkviYA2nH+hFnDoA=="
}, },
"https-browserify": { "https-browserify": {
"version": "1.0.0", "version": "1.0.0",

2
extensions/tags/js/package.json
View File

@ -3,7 +3,7 @@
"name": "@flarum/tags", "name": "@flarum/tags",
"dependencies": { "dependencies": {
"flarum-webpack-config": "0.1.0-beta.10", "flarum-webpack-config": "0.1.0-beta.10",
"html5sortable": "^0.9.8", "html5sortable": "^0.9.16",
"webpack": "^4.26.0", "webpack": "^4.26.0",
"webpack-cli": "^3.1.2" "webpack-cli": "^3.1.2"
}, },

16
extensions/tags/js/src/admin/components/TagsPage.js
View File

@ -1,4 +1,4 @@
import 'html5sortable'; import sortable from 'html5sortable/dist/html5sortable.es.js';
import Page from 'flarum/components/Page'; import Page from 'flarum/components/Page';
import Button from 'flarum/components/Button'; import Button from 'flarum/components/Button';
@ -80,14 +80,18 @@ export default class TagsPage extends Page {
} }
config() { config() {
this.$('ol, ul') sortable(this.$('ol, ul'), {
.sortable({connectWith: 'primary'}) acceptFrom: 'ol,ul'
.on('sortupdate', (e, ui) => { }).forEach(this.onSortUpdate.bind(this));
}
onSortUpdate(el) {
el.addEventListener('sortupdate', (e) => {
// If we've moved a tag from 'primary' to 'secondary', then we'll update // If we've moved a tag from 'primary' to 'secondary', then we'll update
// its attributes in our local store so that when we redraw the change // its attributes in our local store so that when we redraw the change
// will be made. // will be made.
if (ui.startparent.is('ol') && ui.endparent.is('ul')) { if (e.detail.origin.container instanceof HTMLOListElement && e.detail.destination.container instanceof HTMLUListElement) {
app.store.getById('tags', ui.item.data('id')).pushData({ app.store.getById('tags', e.detail.item.getAttribute('data-id')).pushData({
attributes: { attributes: {
position: null, position: null,
isChild: false isChild: false