Rename column for consistency

framework/core/CHANGELOG.md

@@ -15,6 +15,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 ### Changed
 - Migrations must be namespaced under `Flarum\Migrations\{Core|ExtensionName}`. ([#422](https://github.com/flarum/core/issues/422))
 - More compact post layout, with all controls grouped over to the right.
+- Rename `notification_read_time` column in discussions table to `notifications_read_time`.
 
 ### Fixed
 - Output forum description in meta description tag. ([#506](https://github.com/flarum/core/issues/506))

framework/core/migrations/2015_09_22_030432_rename_notification_read_time.php

@@ -0,0 +1,33 @@
+<?php
+
+namespace Flarum\Migrations\Core;
+
+use Illuminate\Database\Schema\Blueprint;
+use Flarum\Migrations\Migration;
+
+class RenameNotificationReadTime extends Migration
+{
+    /**
+     * Run the migrations.
+     *
+     * @return void
+     */
+    public function up()
+    {
+        $this->schema->table('users', function (Blueprint $table) {
+            $table->renameColumn('notification_read_time', 'notifications_read_time');
+        });
+    }
+
+    /**
+     * Reverse the migrations.
+     *
+     * @return void
+     */
+    public function down()
+    {
+        $this->schema->table('users', function (Blueprint $table) {
+            $table->renameColumn('notifications_read_time', 'notification_read_time');
+        });
+    }
+}

framework/core/src/Core/Users/User.php

@@ -71,7 +71,7 @@ class User extends Model
         'join_time',
         'last_seen_time',
         'read_time',
-        'notification_read_time'
+        'notifications_read_time'
     ];
 
     /**
@@ -295,7 +295,7 @@ class User extends Model
      */
     public function markNotificationsAsRead()
     {
-        $this->notification_read_time = time();
+        $this->notifications_read_time = time();
 
         return $this;
     }
@@ -432,7 +432,7 @@ class User extends Model
     {
         return $this->notifications()
             ->whereIn('type', $this->getAlertableNotificationTypes())
-            ->where('time', '>', $this->notification_read_time ?: 0)
+            ->where('time', '>', $this->notifications_read_time ?: 0)
             ->where('is_read', 0)
             ->where('is_deleted', 0)
             ->count($this->getConnection()->raw('DISTINCT type, subject_id'));