github-mirror/framework
github-mirror/framework
2
0
Fork 0
mirror of https://github.com/flarum/framework.git synced 2025-03-02 23:09:39 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Update PULL_REQUEST_TEMPLATE.md

Browse Source 
adding a requirement list
adding related required changes
added comment description
This commit is contained in:
Daniël Klabbers 2018-07-13 10:32:57 +02:00 committed by GitHub
parent 190a737321
commit da9272e870
1 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
framework/core/.github/PULL_REQUEST_TEMPLATE.md vendored
View File

@ -1,10 +1,24 @@
<!--
IMPORTANT: We applaud pull requests, they excite us every single time. As we have an obligation to maintain a healthy code standard and quality, we take considerate amounts of time for reviews.
-->
**Fixes #0000** **Fixes #0000**
**Changes proposed in this pull request:** **Changes proposed in this pull request:**
<!-- fill this out --> <!-- fill this out, mention the pages and/or components which have been impacted -->
**Reviewers should focus on:** **Reviewers should focus on:**
<!-- fill this out --> <!-- fill this out, ask for feedback on specific changes you are unsure about -->
**Screenshot** **Screenshot**
<!-- include an image of the most relevant user-facing change, if any --> <!-- include an image of the most relevant user-facing change, if any -->
**Confirmed**
- [ ] for visual or frontend changes that the changes work as intended via visual confirmation on a local flarum installation.
- [ ] for php changes that the unit tests are all AOK (green) by running them locally (`php vendor/bin/phpunit`).
**Required changes:**
- **Docs**: <!-- list of subjects or pages -->
- **Core extensions**: <!-- list of extensions -->