github-mirror/framework
github-mirror/framework
2
0
Fork 0
mirror of https://github.com/flarum/framework.git synced 2025-02-23 16:14:10 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

prevent lingering permissions when unrestricting (#65)

Browse Source 
Whenever a tag is no longer being restricted, a permission entry in
group_permission lingers around for `viewDiscussions`. This commit
removes all permissions configured after you stop restricting them.

Co-authored-by: Franz Liedke <franz@develophp.org>
This commit is contained in:
Daniël Klabbers 2020-01-13 22:11:41 +01:00 committed by Franz Liedke
parent b2dffe6a0d
commit de7715168a
1 changed files with 26 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
extensions/tags/src/Tag.php
View File

@ -52,8 +52,14 @@ class Tag extends AbstractModel
{
parent::boot();
static::deleted(function ($tag) {
Permission::where('permission', 'like', "tag{$tag->id}.%")->delete();
static::saved(function (self $tag) {
if ($tag->wasUnrestricted()) {
$tag->deletePermissions();
}
});
static::deleted(function (self $tag) {
$tag->deletePermissions();
});
}
@ -164,6 +170,24 @@ class Tag extends AbstractModel
]);
}
/**
* Has this tag been unrestricted recently?
*
* @return bool
*/
public function wasUnrestricted()
{
return ! $this->is_restricted && $this->wasChanged('is_restricted');
}
/**
* Delete all permissions belonging to this tag.
*/
public function deletePermissions()
{
Permission::where('permission', 'like', "tag{$this->id}.%")->delete();
}
protected static function getIdsWherePermission(User $user, string $permission, bool $condition = true): array
{
static $tags;