From eb9ee85b9d344123bbab3ea6175cea4f5750a6f8 Mon Sep 17 00:00:00 2001 From: Franz Liedke Date: Thu, 9 Jan 2020 00:45:50 +0100 Subject: [PATCH] Ensure page parameters are always integers --- framework/core/src/Forum/Content/Discussion.php | 2 +- framework/core/src/Forum/Content/Index.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/framework/core/src/Forum/Content/Discussion.php b/framework/core/src/Forum/Content/Discussion.php index ee1adb5a4..748027383 100644 --- a/framework/core/src/Forum/Content/Discussion.php +++ b/framework/core/src/Forum/Content/Discussion.php @@ -50,7 +50,7 @@ class Discussion public function __invoke(Document $document, Request $request) { $queryParams = $request->getQueryParams(); - $page = max(1, Arr::get($queryParams, 'page')); + $page = max(1, intval(Arr::get($queryParams, 'page'))); $params = [ 'id' => (int) Arr::get($queryParams, 'id'), diff --git a/framework/core/src/Forum/Content/Index.php b/framework/core/src/Forum/Content/Index.php index 3c32baa28..843c25a27 100644 --- a/framework/core/src/Forum/Content/Index.php +++ b/framework/core/src/Forum/Content/Index.php @@ -61,7 +61,7 @@ class Index $sort = Arr::pull($queryParams, 'sort'); $q = Arr::pull($queryParams, 'q'); - $page = Arr::pull($queryParams, 'page', 1); + $page = max(1, intval(Arr::pull($queryParams, 'page'))); $sortMap = $this->getSortMap();