From ee6886382c04e621813ab735632f23c8870f7336 Mon Sep 17 00:00:00 2001
From: Fransiscus Rolanda Malau <fransiscusrmalau@gmail.com>
Date: Thu, 14 Oct 2021 01:53:35 +0700
Subject: [PATCH] Add missing autocomplete attributes to input fields (#3088)

* Add missing autocomplete attributes to input fields
* Add autocomplete attributes to password fields
* Attribute should use new-password
---
 framework/core/js/src/forum/components/ChangeEmailModal.js | 1 +
 framework/core/js/src/forum/components/LogInModal.js       | 1 +
 framework/core/js/src/forum/components/SignUpModal.js      | 1 +
 framework/core/views/reset-password.blade.php              | 4 ++--
 4 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/framework/core/js/src/forum/components/ChangeEmailModal.js b/framework/core/js/src/forum/components/ChangeEmailModal.js
index 6997e71e0..3d7cb6ef0 100644
--- a/framework/core/js/src/forum/components/ChangeEmailModal.js
+++ b/framework/core/js/src/forum/components/ChangeEmailModal.js
@@ -77,6 +77,7 @@ export default class ChangeEmailModal extends Modal {
               type="password"
               name="password"
               className="FormControl"
+              autocomplete="current-password"
               placeholder={app.translator.trans('core.forum.change_email.confirm_password_placeholder')}
               bidi={this.password}
               disabled={this.loading}
diff --git a/framework/core/js/src/forum/components/LogInModal.js b/framework/core/js/src/forum/components/LogInModal.js
index 70445a171..6e2097d34 100644
--- a/framework/core/js/src/forum/components/LogInModal.js
+++ b/framework/core/js/src/forum/components/LogInModal.js
@@ -83,6 +83,7 @@ export default class LogInModal extends Modal {
           className="FormControl"
           name="password"
           type="password"
+          autocomplete="current-password"
           placeholder={extractText(app.translator.trans('core.forum.log_in.password_placeholder'))}
           bidi={this.password}
           disabled={this.loading}
diff --git a/framework/core/js/src/forum/components/SignUpModal.js b/framework/core/js/src/forum/components/SignUpModal.js
index a7c34248c..53593134f 100644
--- a/framework/core/js/src/forum/components/SignUpModal.js
+++ b/framework/core/js/src/forum/components/SignUpModal.js
@@ -104,6 +104,7 @@ export default class SignUpModal extends Modal {
             className="FormControl"
             name="password"
             type="password"
+            autocomplete="new-password"
             placeholder={extractText(app.translator.trans('core.forum.sign_up.password_placeholder'))}
             bidi={this.password}
             disabled={this.loading}
diff --git a/framework/core/views/reset-password.blade.php b/framework/core/views/reset-password.blade.php
index 2b389864d..dfee17383 100644
--- a/framework/core/views/reset-password.blade.php
+++ b/framework/core/views/reset-password.blade.php
@@ -19,11 +19,11 @@
     <input type="hidden" name="passwordToken" value="{{ $passwordToken }}">
 
     <p class="form-group">
-      <input type="password" class="form-control" name="password" placeholder="{{ $translator->trans('core.views.reset_password.new_password_label') }}">
+      <input type="password" class="form-control" name="password" autocomplete="new-password" placeholder="{{ $translator->trans('core.views.reset_password.new_password_label') }}">
     </p>
 
     <p class="form-group">
-      <input type="password" class="form-control" name="password_confirmation" placeholder="{{ $translator->trans('core.views.reset_password.confirm_password_label') }}">
+      <input type="password" class="form-control" name="password_confirmation" autocomplete="new-password" placeholder="{{ $translator->trans('core.views.reset_password.confirm_password_label') }}">
     </p>
 
     <p class="form-group">