From f638fb9300fea84e5c542b28713cf6d84eaaef42 Mon Sep 17 00:00:00 2001 From: Toby Zerner Date: Sun, 5 Nov 2017 17:32:43 +1030 Subject: [PATCH] Remove FastClick. Fixes #1268 Turns out FastClick was causing textareas to be buggy on iOS Safari, and it wasn't really doing any good. --- framework/core/js/bower.json | 1 - framework/core/js/forum/Gulpfile.js | 1 - framework/core/js/forum/src/initializers/boot.js | 4 ---- 3 files changed, 6 deletions(-) diff --git a/framework/core/js/bower.json b/framework/core/js/bower.json index d6532da73..d4d647f54 100644 --- a/framework/core/js/bower.json +++ b/framework/core/js/bower.json @@ -9,7 +9,6 @@ "color-thief": "v2.0", "mithril": "lhorie/mithril.js#v0.2.5", "es6-micro-loader": "caridy/es6-micro-loader#v0.2.1", - "fastclick": "~1.0.6", "autolink": "~1.0.0", "m.attrs.bidi": "tobscure/m.attrs.bidi", "punycode": "http://cdnjs.cloudflare.com/ajax/libs/punycode/1.4.1/punycode.js" diff --git a/framework/core/js/forum/Gulpfile.js b/framework/core/js/forum/Gulpfile.js index 338eabc31..491fcde63 100644 --- a/framework/core/js/forum/Gulpfile.js +++ b/framework/core/js/forum/Gulpfile.js @@ -23,7 +23,6 @@ gulp({ bowerDir + '/spin.js/spin.js', bowerDir + '/spin.js/jquery.spin.js', - bowerDir + '/fastclick/lib/fastclick.js', bowerDir + '/punycode/index.js' ], modules: { diff --git a/framework/core/js/forum/src/initializers/boot.js b/framework/core/js/forum/src/initializers/boot.js index f2b919024..1cf42350d 100644 --- a/framework/core/js/forum/src/initializers/boot.js +++ b/framework/core/js/forum/src/initializers/boot.js @@ -78,11 +78,7 @@ export default function boot(app) { .toggleClass('scrolled', top > offset); }).start(); - // Initialize FastClick, which makes links and buttons much more responsive on - // touch devices. $(() => { - FastClick.attach(document.body); - $('body').addClass('ontouchstart' in window ? 'touch' : 'no-touch'); });