Commit Graph

3534 Commits

Author SHA1 Message Date
Franz Liedke
e446c91a27 Laravel: Stop calling deprecated fire() method
This has been deprecated and removed from the contract for a long time,
and it will be completely dropped in v5.8, our next upgrade target.
2020-03-28 11:08:44 +01:00
Franz Liedke
3246fb3fea Make tests compatible with PHPUnit 8 2020-03-28 11:06:47 +01:00
Franz Liedke
f47a4879c4 Merge pull request #1931 from flarum/dk/1869-queue-notifications
Notifications into the queue
2020-03-27 23:06:36 +01:00
Franz Liedke
119662f6ce Add new method to DiscussionRenamedBlueprint 2020-03-27 16:22:39 +01:00
Franz Liedke
cf3e0cc5bc Add BC layer for notification blueprints
This gives extension authors time to add the new `getAttributes()`
method to their `BlueprintInterface` implementations.

The layer itself is easy to remove in beta.14.
2020-03-27 16:22:38 +01:00
Franz Liedke
4c363fe76c Remove unnecessary constructor parameter 2020-03-27 16:22:38 +01:00
Franz Liedke
2277f26e84 Remove Notifying event for now
As discussed with @luceos, let's add this once the use case comes up. It
might be a left-over from a previous state of this PR anyway.
2020-03-27 16:22:37 +01:00
Daniël Klabbers
dfaa400d85 Moved sending emails to the syncer
This separates sending each individual mail, thus hardening the app.
There are still many improvements possible in this code, e.g. chaining
these commands, making emails just another notification type and
listening to the Notify event instead. We can postpone this to a later
stable release.
2020-03-27 16:22:37 +01:00
Daniël Klabbers
8cdcb25fcc Notifications into the queue
Forces notifications into a dedicated SendNotificationsJob and passed
to the queue.

- One static method re-used in the job ::getAttributes, is that okay or
  use a trait?
- Do we want to use this solution and refactor into a better Hub after
  stable, postpone this implementation or use it in b11?
2020-03-27 16:16:36 +01:00
Franz Liedke
20bc1e50fc Convert last two controller tests to request tests 2020-03-27 13:39:38 +01:00
Daniël Klabbers
9ee12eebcd fixes checking for enabled extension and correct pointer of 13e20c2ced 2020-03-27 13:29:16 +01:00
Franz Liedke
2deae4b058 Rename API tests for more consistency
I could not come up with a noun for the new "UpdateTest" for users, so
this is easier in terms of consistency.
2020-03-27 13:22:27 +01:00
Franz Liedke
4e2f91fa00 Convert more controller tests to request tests 2020-03-27 13:21:10 +01:00
Matt Kilgore
b0fd63adc3 Fix test and extender for middleware (#2084) 2020-03-27 11:00:30 +01:00
Daniël Klabbers
13e20c2ced Resolved enabled extension test
The getEnabled method returns all extensions (previously) enabled, yet manually
uninstalled through composer. This does not reference the exact, current state
of the forum. getEnabledExtensions returns a list where the getEnabled list
is filtered on the extensions found in the composer installed.json file.
2020-03-25 11:47:39 +01:00
Matt Kilgore
84dafdd5c3 fix insertAfter and insertBefore middleware extender functions (#2063) 2020-03-20 22:59:57 +01:00
Franz Liedke
b3dc2c7571 Convert more controller tests to request tests 2020-03-20 18:54:20 +01:00
Franz Liedke
a70acdf9cb Apply fixes from StyleCI
[ci skip] [skip ci]
2020-03-20 17:28:58 +00:00
Franz Liedke
2b0bc2865d Tests: Use new authenticatedAs option where useful
There are two more API integration tests that explicitly add the
"Authorization" header right now:

- `Flarum\Tests\integration\api\authentication\WithApiKeyTest`
- `Flarum\Tests\integration\api\csrf_protection\RequireCsrfTokenTest`

These two specifically test authentication, so in those cases the
explicitness seems desirable.
2020-03-20 18:28:35 +01:00
Franz Liedke
8e21fee06c Replace authenticatedRequest() by request() option
I feel this makes the parameters a bit more clear, does not rely on
inheritance (you can only inherit from one class, but we might want more
of these helpers in the future), and has less side effects (e.g. no
creation and, more importantly, deletion of users in the database).

Refs #2052.
2020-03-20 18:23:06 +01:00
Franz Liedke
6540049421 Tests: Extract trait for building requests 2020-03-20 17:51:03 +01:00
Alexander Skvortsov
fe8df6df4e Add Authenticated Test Case utility 2020-03-20 17:18:35 +01:00
Alexander Skvortsov
01bbaadf2f Users should not be able to restore discussions if deleted by admins (#2037) 2020-03-20 15:57:03 +01:00
Franz Liedke
4d4a1e5e24 Update less.php to version 3.0
Now that we require PHP 7.2, this ensures we get the latest updates and
fixes as well.

Refs #1988.
2020-03-17 23:12:23 +01:00
Matt Kilgore
77062dd833 Change Extenders properties to private (#1958) 2020-03-17 22:37:17 +01:00
dependabot[bot]
3e8aae3cff Bump acorn from 6.4.0 to 6.4.1 in /js (#2065)
Bumps [acorn](https://github.com/acornjs/acorn) from 6.4.0 to 6.4.1.
- [Release notes](https://github.com/acornjs/acorn/releases)
- [Commits](https://github.com/acornjs/acorn/compare/6.4.0...6.4.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-03-17 22:29:36 +01:00
Franz Liedke
21188eba39 CI: Fix broken build on GitHub Actions
The MySQL service is no longer started by default on these agents.

See https://github.blog/changelog/2020-02-21-github-actions-breaking-change-ubuntu-virtual-environments-will-no-longer-start-the-mysql-service-automatically/.
2020-03-17 22:23:11 +01:00
flarum-bot
b99f1bc384 Bundled output for commit 1c7dab6e07 [skip ci] 2020-03-09 12:41:19 +00:00
Daniël Klabbers
1c7dab6e07 showing start user in class list now 2020-03-09 13:39:26 +01:00
Franz Liedke
7096da722e Add a baseline test for the middleware extender
Refs #2017.
2020-03-06 15:05:16 +01:00
Franz Liedke
774dd10bf5 Fix typo 2020-03-06 15:05:15 +01:00
Franz Liedke
a1a2b35221 Apply fixes from StyleCI
[ci skip] [skip ci]
2020-03-06 13:55:39 +00:00
Matt Kilgore
390b529da7 Test Middleware extender (#2017) 2020-03-06 14:55:21 +01:00
Daniël Klabbers
18ebf34635 start using a dev stability version constant during the cycle 2020-03-05 10:50:30 +01:00
Franz Liedke
00e4b44abc Remove deprecated ConfigureMiddleware Event (#2032) 2020-03-04 23:02:05 +01:00
Franz Liedke
f6b4985347 Remove deprecated Flarum\Util\Str class 2020-03-04 22:59:14 +01:00
Franz Liedke
6b20c92be2 Remove mail settings backwards compatibility layer 2020-03-04 22:58:15 +01:00
Franz Liedke
1b66612e11 Merge branch 'refs/heads/v0.1.0-beta.12'
# Conflicts:
#	composer.json
2020-03-04 22:56:37 +01:00
Daniël Klabbers
90c6f3f567 updated core developers in authors 2020-03-03 15:47:00 +01:00
Daniël Klabbers
f8355e661a Update Application.php
updated version constant for b12
2020-03-03 15:38:15 +01:00
Alexander Skvortsov
6577842b7a Drop support for PHP 7.1 (#2014)
* Updated PHP requirement to 7.2

* Set wikimedia less version to 1.8

* Indentation fix on composer json

* Revert "Set wikimedia less version to 1.8"

This reverts commit 22d862fd98.
2020-02-27 00:52:03 +01:00
Franz Liedke
1a3f90daef Re-add mail settings backwards compatibility layer 2020-02-26 23:11:22 +01:00
Franz Liedke
50ea61b524 Require new mail driver methods, remove BC layer 2020-02-26 22:56:09 +01:00
Alexander Skvortsov
ccf11480bf Removed support for SES Mail Driver (#2011) 2020-02-26 22:36:27 +01:00
Alexander Skvortsov
9ef640fa44 Remove Zend compatability bridge (#2010) 2020-02-26 22:29:44 +01:00
Franz Liedke
3e154f9c25 Re-add util class and mark it as deprecated
This would be the only breaking change in beta.12. Let's stick to our
backwards compatibility promise / intentions as much as possible, even
if we assume the class has not been used anywhere.

This BC layer will be removed again for beta.13.

Refs #1975.
2020-02-26 22:14:23 +01:00
Franz Liedke
a41fef8d25 Prepare changelog for beta.12 release 2020-02-26 21:10:52 +01:00
Matt Kilgore
b83d848752 Force fixed version of text formatter 2020-02-25 11:27:59 +01:00
Franz Liedke
d30f2a0ca9 Merge pull request #2002 from flarum/fl/extender-tests
Start testing extenders
2020-02-14 18:47:58 +01:00
flarum-bot
4788c144cf Bundled output for commit ec59171ef1 [skip ci] 2020-02-14 14:57:19 +00:00