github-mirror/framework
2
0
Fork 0
mirror of https://github.com/flarum/framework.git synced 2024-11-26 02:10:09 +08:00
Code Issues Actions 46 Packages Projects Releases Wiki Activity
4,533 Commits 87 Branches 50 Tags 181 MiB
397e4786da
Commit Graph

4533 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Alexander Skvortsov
9b011d742c Merge pull request #3228 from flarum/as/v1.2_frontend_fixes 
Some v1.2 frontend fixes
 2021-12-27 20:24:53 -05:00
David Wheatley
d60f1953f1 perf: only update last time when current value outdated (#3230) 
* perf: only update last seen time when current > 120s ago

* perf: only update `last_activity_at` every 2 mins

* docs: add comment

* fix: add missing param

* test: add tests

* tests: attempt tests fix

* fix(tests): call `$this->app()`

* chore: extract hard-coded values out to private consts

* chore: increase diff

* Apply suggestions from code review
 2021-12-28 00:39:42 +01:00
Alexander Skvortsov
f6b1d65a57 Fix consecutive shows of same modal with different attrs 
We need to specify a unique key for each modal so that the modals are fully destroyed and recreated. For instance, this fixes the signup modal being empty with OAuth register flows.
 2021-12-27 18:28:11 -05:00
flarum-bot
aa90edd2d7 Bundled output for commit afa36e71f8 
Includes transpiled JS/TS, and Typescript declaration files (typings).

[skip ci]
 2021-12-27 23:18:49 +00:00
Alexander Skvortsov
c939b4f274 Use translations for page titles in frontend 
This gives more flexibility for customization, and allows overriding title structure via translations / linguist.
 2021-12-27 18:15:12 -05:00
Alexander Skvortsov
afa36e71f8 Only retain scroll position if coming from discussion (#3229) 
Fixes https://discuss.flarum.org/d/29596-make-tag-hero-visible/8.

If a user has just switched from one tag to another, they want to see the entire new discussion list, and information about which tag that discussion list corresponds to. There's no good reason to not display the hero header when switching tags.
 2021-12-27 18:13:29 -05:00
flarum-bot
7ababc95f3 Bundled output for commit 93e7732117 
Includes transpiled JS/TS, and Typescript declaration files (typings).

[skip ci]
 2021-12-27 20:37:36 +00:00
David Wheatley
93e7732117 fix: posts tab on users page broken 2021-12-27 21:32:04 +01:00
flarum-bot
d53ab07648 Bundled output for commit de4e906a1a 
Includes transpiled JS/TS, and Typescript declaration files (typings).

[skip ci]
 2021-12-27 19:59:19 +00:00
David Wheatley
de4e906a1a fix: returning null breaking CommentPosts 2021-12-27 20:54:00 +01:00
flarum-bot
e7df8f121e Bundled output for commit 5e3ad44a55 
Includes transpiled JS/TS, and Typescript declaration files (typings).

[skip ci]
 2021-12-27 19:09:19 +00:00
David Wheatley
5e3ad44a55 chore: maintenance pre-1.2 release (#3213) 
* chore: bump js dependencies

* chore: bump Yarn to 3.1.1

* chore: re-patch TS binary

* chore: don't show diffs for yarn lockfile
 2021-12-27 19:04:42 +00:00
flarum-bot
7e54c70055 Bundled output for commit 998aff251f 
Includes transpiled JS/TS, and Typescript declaration files (typings).

[skip ci]
 2021-12-27 19:02:33 +00:00
David Wheatley
998aff251f chore: 1.2 JS clean-up (#3214) 
* fix: `extend.ts` TS error

* docs: fix incorrect JS docblocks

* chore: simplify some code

* chore: remove usages of prefixed JS function

* chore: consistent empty return types

* chore: format

* fix: typing errors

* chore: remove unneeded `@public` docblock modifiers

* Apply suggestions from code review

* Update js/src/forum/utils/slidable.js

Co-authored-by: Alexander Skvortsov <38059171+askvortsov1@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Alexander Skvortsov <38059171+askvortsov1@users.noreply.github.com>
 2021-12-27 18:58:18 +00:00
Alexander Skvortsov
01e177eb52 Fix drawer focus trap making login form unclickable on mobile 
Adding `clickOutsideDeactivates` seems to fix the issue, contrary to what the focus-trap documentation implies about it being unnecessary.
 2021-12-26 22:45:58 -05:00
Alexander Skvortsov
5e9f746f37 Fix Search error when user can't search 
If there are no search sources, HTML for the Search component won't be rendered, so trying to attach listeners to it will likely error.

In this PR, we don't attach such listeners/logic if there are no sources. We also stop asserting that sources is defined to help avoid other similar issues in the future.
 2021-12-26 20:04:48 -05:00
flarum-bot
f63a40e313 Bundled output for commit 3dcf7bcd67 
Includes transpiled JS/TS, and Typescript declaration files (typings).

[skip ci]
 2021-12-26 06:29:40 +00:00
David Wheatley
3dcf7bcd67 fix: incorrect return type on pushPayload (#3226) 2021-12-26 01:25:16 -05:00
flarum-bot
46d90487e8 Bundled output for commit 343f822771 
Includes transpiled JS/TS, and Typescript declaration files (typings).

[skip ci]
 2021-12-22 18:58:42 +00:00
David Wheatley
343f822771 fix: hide WelcomeHero when content is empty (#3219) 2021-12-22 13:54:21 -05:00
Sebastian Kessler
b054b44510 docs: fix broken contribution link in README; add screenshot (#3211) 2021-12-20 14:55:25 -05:00
flarum-bot
4ac6887c6f Bundled output for commit e9de3f3c61 
Includes transpiled JS/TS, and Typescript declaration files (typings).

[skip ci]
 2021-12-20 16:32:17 +00:00
David Wheatley
e9de3f3c61 fix: breaking change in Search component - renaming of state property (#3212) 
* fix: breaking change in search component's public api

* fix: add setter

* feat: add deprecation warning helper

This reduces bundle size as a result of deprecation warning in our JS, as well as maintaining a consistent format across warnings.

* feat: fire deprecation warning on usage of `Search.state`

* chore: use consistent deprecation warning across core

* fix: `/pull` not `/issue`

* chore: format
 2021-12-20 16:28:28 +00:00
David Wheatley
5ddfacf436 fix(postmeta): use app baseUrl instead of location.origin (#3216) 2021-12-20 16:25:04 +00:00
David Wheatley
fbaf936e7e feat: allow replacing of blade template namespaces via extender (#3167) 
* feat: allow replacing of blade template namespaces

* wip: add `prependNamespace` support

* test: add replace namespace test

* Apply fixes from StyleCI

[ci skip] [skip ci]

* fix: add missing property

* test: add prepend test

* fix: add view namespaces before resolving

Allows `replaceNamespace()` extender to actually remove old routes.

* test: make replace test ensure that replaced view does not exist

* docs: update docblock

* Apply fixes from StyleCI

[ci skip] [skip ci]

* fix: missing `\` before class

* fix: change test view namespace

* chore: simplify test

* Remove replace namespace code

We only really need prepend.

* chore: rename extender

* ci: add override test

* Apply fixes from StyleCI

[ci skip] [skip ci]

* fix(tests): add `trim` call

* revert: 3d46ead14b

Co-authored-by: luceos <luceos@users.noreply.github.com>
 2021-12-20 09:56:48 +01:00
flarum-bot
c8febb6199 Bundled output for commit 93e7b446bd 
Includes transpiled JS/TS, and Typescript declaration files (typings).

[skip ci]
 2021-12-16 08:36:25 +00:00
Sami Mazouz
93e7b446bd fix: Add a11y labels to auth modal inputs (#3207) 2021-12-16 09:30:34 +01:00
flarum-bot
6a90930373 Bundled output for commit eeff1e5b65 
Includes transpiled JS/TS, and Typescript declaration files (typings).

[skip ci]
 2021-12-15 15:53:25 +00:00
David Wheatley
eeff1e5b65 fix: replace throw with debug warning to fix breaking change (#3206) 
* fix: replace throw with debug warning to fix breaking change

* Add link back to PR in warning

* fix: add missing `return null` for `!allowUnregistered` code path

* Clean up message -- move more info to PR comment

* Add setTimeout to delay call debug warning call until after `app.forum` is defined

* Add backticks around data type
 2021-12-15 10:48:46 -05:00
flarum-bot
1c2a33b253 Bundled output for commit 8fa7ffa175 
Includes transpiled JS/TS, and Typescript declaration files (typings).

[skip ci]
 2021-12-14 22:16:16 +00:00
Ian Morland
8fa7ffa175 feat: extract notification primaryControl items to an ItemList (#3204) 2021-12-14 22:11:48 +00:00
Ian Morland
77264be5e3 feat: Add events for Notification read / read all (#3203) 2021-12-14 15:38:50 -05:00
David Wheatley
fbfc80f979 feat: add Less custom function extender, is-extension-enabled function (#3190) 
Co-authored-by: luceos <luceos@users.noreply.github.com>
Co-authored-by: Sami Mazouz <sychocouldy@gmail.com>
 2021-12-14 19:25:39 +00:00
Ian Morland
eb7382b672 Only update notifications that are not already marked as read (#3202) 2021-12-14 19:24:30 +01:00
flarum-bot
6a5afd1e4f Bundled output for commit 56809ae20b 
Includes transpiled JS/TS, and Typescript declaration files (typings).

[skip ci]
 2021-12-14 17:10:20 +00:00
Alexander Skvortsov
56809ae20b Merge pull request #2961 from the-turk/style-st 
Improve selected text stylization
 2021-12-14 12:06:22 -05:00
flarum-bot
1efab83293 Bundled output for commit 3d754461b0 
Includes transpiled JS/TS, and Typescript declaration files (typings).

[skip ci]
 2021-12-14 03:11:57 +00:00
Alexander Skvortsov
3d754461b0 Merge pull request #3196 from flarum/as/finish-typing 
Finish typing, enable error on TypeScript check failure
 2021-12-13 22:07:39 -05:00
Alexander Skvortsov
a82a160ecb Format and Type Import Cleanup 
Co-authored-by: David Wheatley <hi@davwheat.dev>
 2021-12-13 22:04:36 -05:00
Alexander Skvortsov
2dea2f09a4 Error in GH actions on type failures 2021-12-13 20:20:35 -05:00
Alexander Skvortsov
7b8eaf9045 Fix typing errors with app.modal.show 
Unfortunately TypeScript doesn't support higher-kinded types, so we can't write this in a type-safe way.
 2021-12-13 20:20:35 -05:00
Alexander Skvortsov
850d555866 Slightly improve AlertManagerState show typing 
`typeof Alert` is more correct than `Alert`, since we're accepting classes not instances.
 2021-12-13 20:20:35 -05:00
Alexander Skvortsov
7b8d507139 VnodeElementTag must be either a string or a class. 
Unfortunately, TypeScript only supports strings and classes for JSX tags.
Therefore, our type definition should only allow for those two types.
see https://github.com/microsoft/TypeScript/issues/14789#issuecomment-412247771
 2021-12-13 20:20:34 -05:00
Alexander Skvortsov
959662f2e2 Format VnodeElementTag fix 2021-12-13 20:20:34 -05:00
Alexander Skvortsov
e1c6028dce Modal typescript cleanup and conversions 2021-12-13 20:20:34 -05:00
Alexander Skvortsov
da6ae898b2 alertAttrs can be null 2021-12-13 20:20:34 -05:00
Alexander Skvortsov
74f223cccc Fix LoadingModal attr typings 2021-12-13 20:20:34 -05:00
Alexander Skvortsov
0e2053da1f Allow any Mithril Children where appropriate 2021-12-13 20:20:33 -05:00
Alexander Skvortsov
d307331603 extractText from translations where strings expected 2021-12-13 20:20:33 -05:00
Alexander Skvortsov
a8db0b7bb2 Fix import of mithril for VnodeElementTag usage 2021-12-13 20:20:33 -05:00