Commit Graph

355 Commits

Author SHA1 Message Date
Alexander Skvortsov
84dcde4e85 Fix delayed mention search results
Fixes https://github.com/flarum/core/issues/3095
2021-10-06 16:22:04 -04:00
Alexander Skvortsov
03c6db4c8d Import function correctly
There was a typo in the function's name which broke mentions.
2021-10-06 16:15:01 -04:00
flarum-bot
798fadbddc Bundled output for commit 6173c3d612
Includes transpiled JS/TS.

[skip ci]
2021-09-20 17:43:50 +00:00
David Wheatley
6173c3d612 Minor refactors in frontend JS (#69)
* Add Prettier

* Update dependencies; add typescript setup

* Add tsconfig

* Rewrite some mentions frontend into TS

* Fix use of username instead of display name

* Change back to JS

* Remove commented code

* Update function name to match filename

* Update getMentionText.js

* Simplify condition

* Bump packages to stable versions; use prettier package

* Make functions use camel case

* Update js/package.json

Co-authored-by: Sami Mazouz <sychocouldy@gmail.com>

* Don't access data directly

* Update js/src/forum/addComposerAutocomplete.js

Co-authored-by: Alexander Skvortsov <38059171+askvortsov1@users.noreply.github.com>

* Update tsconfig.json

Co-authored-by: Sami Mazouz <sychocouldy@gmail.com>
Co-authored-by: Alexander Skvortsov <38059171+askvortsov1@users.noreply.github.com>
2021-09-20 18:42:38 +01:00
Sami Mazouz
6a5d7e9864 Fix unrecognised user/post mentions (#71)
* fix: Use proper mentionsUsers serializer
The only reason we haven't seen any issues with this up until now is because we have not has to include the relationship in any responses.

* fix: User/Post mentions showing as deleted after saving
The reason this happens is because the modified relationship is not refreshed, so the formatter doesn't recognize the new mentions as valid.
2021-08-30 18:23:59 +01:00
Sami Mazouz
af9e5a9cc9 Eager load more necessary related mentions (#72)
* perf: Eager load related mentions from the extender

These missing relations caused more queries to be called, the more mentions posts have the more queries produced.

* perf: Eager load models in show endpoints

Can't use the extender for that
2021-08-23 20:33:42 +01:00
Daniel Klabbers
5217b8b6be fix branch alias 2021-05-25 22:51:07 +02:00
Daniel Klabbers
d37a43c795 changes for stable 2021-05-25 16:26:34 +02:00
flarum-bot
37c1933d37 Bundled output for commit 07e93747be
Includes transpiled JS/TS.

[skip ci]
2021-05-25 07:03:39 +00:00
SychO9
b0a301229a Tweak test name and add posts mention equivalent test 2021-05-25 00:15:10 +01:00
SychO9
cc62044e6f Support smart quotes in mentions format 2021-05-24 21:49:31 +01:00
Sami Mazouz
a311edf106 Update tests to use setting method (#68) 2021-05-17 22:46:02 +01:00
Alexander Skvortsov
53bbb63a24 Bump composer reqs for 1.0.0 2021-05-16 18:28:41 -04:00
David Wheatley
59320d401f Update copyright year 2021-05-15 00:56:10 +01:00
flarum-bot
b7e9d729c1 Bundled output for commit 8ef8dee532
Includes transpiled JS/TS.

[skip ci]
2021-05-14 22:15:06 +00:00
SychO9
8ef8dee532 Use slug for user mentions page 2021-05-14 23:13:45 +01:00
flarum-bot
4d8f105d07 Bundled output for commit ae69dd25c7
Includes transpiled JS/TS.

[skip ci]
2021-05-13 00:02:51 +00:00
Alexander Skvortsov
ae69dd25c7 Update for ICU MessageFormat 2021-05-12 19:27:13 -04:00
flarum-bot
bc187d9b83 Bundled output for commit 3e596aaadf [skip ci] 2021-05-12 19:43:31 +00:00
Sami Mazouz
3e596aaadf Move replies preview dropdown out of Post-footer (#55) 2021-05-12 20:42:33 +01:00
Alexander Skvortsov
8ed08b63cd Fix mentioned filtering (#67) 2021-05-04 14:57:29 -04:00
flarum-bot
e2b309ad95 Bundled output for commit 02d3355989 [skip ci] 2021-05-02 20:38:50 +00:00
SychO9
02d3355989 Add space when inserting a post mention 2021-05-02 21:37:31 +01:00
flarum-bot
83ed624223 Bundled output for commit e407c66784 [skip ci] 2021-04-21 09:59:51 +00:00
Sami Mazouz
e407c66784 New mentions format, decouple usernames from mentions (#65)
* Convert user mentions to new `@"Display Name"#ID` format

* Handle deleted user's mentions

* Convert post mentions to `@"Display Name"#pID` format

* Handle deleted user's post mentions and deleted posts mentions

* Clean display name of `"#{letters}{numbers}` (replace with underscore _)

* Adapt integration tests to new mention formats

* Use a deleted attribute for user mentions

* Introduce cleanDisplayName util

* Detect new format with autocomplete

* Slug needed on rendering only

* Invalidate user mention tag when ID is invalid
This used to be implicitly done, when there was a username attribute configured, formatter would check that all attributes are available and if not invalidate.

since we now only have `displayname` and `id` attributes which are both available from the regex matching, formatter doesn't implicitly invalidate anymore and therefore validates ANY matches. So we explicitly invalidate the tag when the ID does not match a user.

* Allow username mention format with a setting

* Add tests for turning setting on/off

* Move setting check to tag filter
Because the configurator caches, changing the setting only takes effect after the cache is cleared.

* fix: showing autocomplete at the right moment

* Add dockblocks to explain unparsing process
2021-04-21 10:58:54 +01:00
Sami Mazouz
057517688c Add integration tests (#66) 2021-04-13 22:27:42 +01:00
Alexander Skvortsov
cd3934e358 Use RequestUtil to access actor 2021-04-08 00:03:18 -04:00
Sami Mazouz
46aabd2ae5 Eager load mentionedBy and only missing relations (#64) 2021-03-25 15:37:47 +01:00
Daniel Klabbers
613664525d Release v0.1.0-beta.16 2021-03-15 12:11:51 +01:00
Alexander Skvortsov
b922257468 Use non-deprecated translator interface 2021-03-13 17:10:23 -05:00
Charlie
23c03e058a change category (#62) 2021-03-08 14:21:21 -05:00
flarum-bot
37f0a100bd Bundled output for commit 0ad97bb4ed [skip ci] 2021-03-02 04:33:37 +00:00
Alexander Skvortsov
0ad97bb4ed Fix dropdown going off top of screen
The previous solution didn't properly account for document scroll, so when replying to posts, the parent offset would be extremely large, and it'd fall back to the top coordinate, which is out of bounds on small screens.
2021-03-01 23:32:30 -05:00
Alexander Skvortsov
302687b11a Use one instance of formatter extender 2021-03-01 23:26:35 -05:00
flarum-bot
8c78af4b1c Bundled output for commit d4db946c31 [skip ci] 2021-02-26 21:20:57 +00:00
Alexander Skvortsov
d4db946c31 Update for Editor Drivers Abstraction (#61) 2021-02-26 16:20:07 -05:00
Robert Korulczyk
b06f6470e7 Move locale files from language pack to extension. (#56) 2021-02-17 16:23:40 -05:00
Ian Morland
d368aa4e55 Fix incorrect display_name showing in email notifications (#59) 2020-12-21 12:43:27 -05:00
Daniël Klabbers
5f8a4009fe changelog and constraint for beta 15 2020-12-15 09:15:26 +01:00
Daniël Klabbers
80101d52a9 npm audit fix 2020-12-15 09:15:26 +01:00
Alexander Skvortsov
198f8ae870 Ensure nullable arguments are indeed nullable 2020-12-13 16:38:24 -05:00
flarum-bot
4f153a099d Bundled output for commit eea694e021 [skip ci] 2020-12-11 04:50:41 +00:00
Alexander Skvortsov
eea694e021 Fix mention button in composer toolbar
It seems like we missed one `this.props` during the beta 14 rewrite
2020-12-10 23:49:26 -05:00
Alexander Skvortsov
9ca860ee7b Update composer metadata for admin dashboard 2020-12-08 19:57:10 -05:00
Alexander Skvortsov
3198de4b9b Use Formatter extender for rendering callbacks 2020-12-08 11:41:05 -05:00
Sami Mazouz
256e821289 Use new extenders (#58) 2020-12-08 11:15:52 -05:00
Alexander Skvortsov
ab27fd452d Add composer metadata for admin ux redesign 2020-11-25 01:23:14 -05:00
Sami Mazouz
2e9d9ab816 Use the new Notification type extender (#57) 2020-10-31 18:43:02 -04:00
flarum-bot
6f7b86b0a9 Bundled output for commit 367a1b2329 [skip ci] 2020-10-29 22:34:16 +00:00
Sami Mazouz
367a1b2329 Check if event is cancelable before preventDefault (#54)
This recovers the initial wanted behavior of opening the post mention preview dropdown instead of directly going to the post on touchscreens.
2020-10-29 18:33:26 -04:00
Daniël Klabbers
2b6b7ed26e changelog and dep for v0.1.0-beta.14 2020-10-15 14:43:04 +02:00
Daniël Klabbers
5cfb1550eb npm audit security vulnerabilities patched 2020-10-14 09:59:01 +02:00
flarum-bot
d94dfa6090 Bundled output for commit 26c84b9e5b [skip ci] 2020-10-03 00:20:06 +00:00
Alexander Skvortsov
26c84b9e5b Use Link component instead of route patch 2020-10-02 20:19:10 -04:00
Alexander Skvortsov
9ef207fa85 Translate notification emails (#50) 2020-10-01 11:16:20 -04:00
flarum-bot
51134ff625 Bundled output for commit ea56f39a53 [skip ci] 2020-09-24 02:54:49 +00:00
Alexander Skvortsov
ea56f39a53 Mithril 2 Update (#52)
Update for Mithril 2

- Please note that PostQuoteButton and AutocompleteDropdown are not Fragments, not Components. Accordingly, they have been moved to the components folder.

Co-authored-by: Matthew Kilgore <tankerkiller125@gmail.com>
Co-authored-by: Franz Liedke <franz@develophp.org>
2020-09-23 22:53:46 -04:00
flarum-bot
a48a84fcd0 Bundled output for commit 1674e7a313 [skip ci] 2020-09-04 16:26:07 +00:00
Franz Liedke
1674e7a313 Fix extension to work with Composer state changes
Refs flarum/core#2162.
2020-09-04 18:19:27 +02:00
flarum-bot
8f1ba6e7d2 Bundled output for commit 921db74fe4 [skip ci] 2020-09-04 14:47:16 +00:00
Franz Liedke
921db74fe4 Fix extension to work with Composer state changes
Refs flarum/core#2162.
2020-09-04 16:46:01 +02:00
flarum-bot
1ce62ca3c5 Bundled output for commit ce039d3dd6 [skip ci] 2020-09-04 14:43:38 +00:00
Franz Liedke
ce039d3dd6 Fix extension to work with Composer state changes
Refs flarum/core#2162.
2020-09-04 16:42:07 +02:00
dependabot[bot]
6da004c7ae Bump elliptic from 6.5.2 to 6.5.3 in /js (#51)
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.2 to 6.5.3.
- [Release notes](https://github.com/indutny/elliptic/releases)
- [Commits](https://github.com/indutny/elliptic/compare/v6.5.2...v6.5.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-07-31 01:09:16 +02:00
Alexander Skvortsov
5d7f1d87d5 Don't typehint the view factory in the closure in extend.php
This causes the view factory to resolve early, breaking all future extensions that use the view extender
2020-07-27 19:30:24 -04:00
Matthew Kilgore
d1cf21dcd2 Replaced depreciated helper function with classfull function 2020-07-25 21:08:49 -04:00
Franz Liedke
ba3071eaac Use new View extender
Refs flarum/core#2134.
2020-07-17 12:10:47 +02:00
dependabot[bot]
c192cbc57b Bump lodash from 4.17.15 to 4.17.19 in /js (#49)
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-07-17 10:48:25 +02:00
flarum-bot
ebc8b763ce Bundled output for commit 68163d462a [skip ci] 2020-07-01 21:10:06 +00:00
Alexander Skvortsov
68163d462a Stop mentions dropdown from jumping around (#48)
Cache the order in which users are returned by the API to stop the mentions list from jumping around
Only ping the api when 2 or more characters are entered
2020-07-01 17:08:31 -04:00
Alexander Skvortsov
13e79e5457 Add empty locale extender to clear cache properly on enable/disable.
See https://github.com/flarum/core/pull/2020#issuecomment-616149583
2020-06-19 22:27:37 -04:00
flarum-bot
a905fbd073 Bundled output for commit af979f20ff [skip ci] 2020-06-10 00:14:45 +00:00
Matteo Contrini
af979f20ff Always show replies list on posts (#47)
Previously, if there was a single reply and it was adjacent to the post it wasn't shown.

See discussion on Discuss: https://discuss.flarum.org/d/23666-flarum-010-beta13-released/75
2020-06-09 20:13:24 -04:00
Sami Mazouz
f8d1e2b22e Fix replies dropdown menu width (#38)
* Fixes flarum/core#1707
2020-05-22 18:50:26 -04:00
Franz Liedke
e6f0ca5873 Use existing variable for media query
Refs #46, flarum/core#2070.
2020-05-21 03:33:32 +02:00
Tariq Hussein
2ecfe5da7b Check reply with mention can be read by original poster (#39) 2020-05-20 17:01:34 -04:00
timas130
43ad78654c Fix dropdown overflow on mobile (flarum/core#2070) (#46)
* Fix dropdown overflow on mobile (flarum/core#2070)
2020-05-20 15:20:02 -04:00
Daniël Klabbers
665f41a518 incorrect compared versions in changelog 2020-05-04 10:42:22 +02:00
Daniël Klabbers
6f3e7fde0b Missing PR ref in Changelog beta 13 2020-05-04 10:35:14 +02:00
Daniël Klabbers
910ca68ccd Release v0.1.0-beta.13 2020-05-04 10:34:34 +02:00
flarum-bot
494ec8b8a6 Bundled output for commit 5855b0367f [skip ci] 2020-05-01 09:59:00 +00:00
Franz Liedke
5855b0367f Update Webpack 2020-05-01 11:56:01 +02:00
Franz Liedke
a552b957ba Use new Model extender 2020-04-24 15:55:50 +02:00
Franz Liedke
9587d3b416 npm audit fix 2020-04-24 14:30:29 +02:00
dependabot[bot]
dd89498150 Bump acorn from 6.4.0 to 6.4.1 in /js (#45)
Bumps [acorn](https://github.com/acornjs/acorn) from 6.4.0 to 6.4.1.
- [Release notes](https://github.com/acornjs/acorn/releases)
- [Commits](https://github.com/acornjs/acorn/compare/6.4.0...6.4.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-03-17 21:52:38 +01:00
Robert Turner
9c674f0a8b Fix mentioning a deleted user's post (#41)
Fixes #1956 - ErrorException: Trying to get property 'display_name' of 
non-object. ConfigureMentions::addPostId method set mention details 
based on if there was an existing post. This caused an error if there 
was an existing post, but the user who posted had been deleted. The 
mention details are now only set if there is a user associated with the 
post being mentioned.
2020-03-06 23:04:24 +01:00
Daniël Klabbers
090483e3ab remove author, updated deps 2020-03-03 14:29:50 +01:00
flarum-bot
62ec7dc2fc Bundled output for commit 969638a311 [skip ci] 2020-02-11 20:44:30 +00:00
Franz Liedke
969638a311 Update Webpack 2020-02-11 21:43:28 +01:00
Franz Liedke
3390bd5b02 Apply fixes from StyleCI 2019-11-29 23:02:17 +00:00
Franz Liedke
8227426aa0 Update copyright claims in LICENSE 2019-11-30 00:01:02 +01:00
Daniël Klabbers
0b80dfe837 updated requirement with flarum/core 2019-09-16 09:34:22 +02:00
Franz Liedke
9bb4894ec0 Update changelog for beta.10 2019-09-15 22:43:58 +02:00
Franz Liedke
d9fb5ab31b Update vulnerable JS dependencies 2019-09-13 15:33:06 +02:00
Franz Liedke
dd43db2ddb Add GitHub workflow for JavaScript building 2019-08-20 23:54:24 +02:00
Shivanshu Patel
7afdbb1ea9 Remove like with and compare with equals (#37)
`_` is special character in mysql so like query was fetching different result for user who's unsername starts with or contains `_`
2019-08-16 15:57:35 +02:00
Daniël Klabbers
f21b062b3d update constraint 2019-06-24 12:01:04 +02:00
Daniël Klabbers
6b8fc76283 changelog for 0.1.0-beta.9 2019-06-24 11:23:29 +02:00
Franz Liedke
0e0159c397 Update changelog 2019-06-13 01:32:20 +02:00
bdumaspilhou
b9c4a003f2 Fixes : use display_name in mail and in subject (#35) 2019-03-06 23:25:23 +01:00