2257 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Sajjad Hasehmian	979fef1163	Remove 'extensions' path for writable check	2016-03-04 09:55:40 +03:30
Daniel Klabbers	f1236a90b1	added integration with codecov to track coverage of tests	2016-03-03 11:50:09 +01:00
Toby Zerner	0671c676b4	Merge pull request #843 from Luceos/add-tests ... adding new tests to cover api handlers	2016-03-03 20:53:15 +10:30
Daniel Klabbers	7e65a7fd5b	adding new tests to cover api handlers, part 1 of #245 and #74	2016-03-03 11:00:11 +01:00
Toby Zerner	f1fb33cc55	Fix fatal error when deleting a discussion forever. closes #842	2016-03-03 12:52:53 +10:30
Toby Zerner	4fa89dbb13	Merge pull request #841 from Luceos/drop-ext-dir ... Refactoring to drop extensions dir, see #774	2016-03-02 18:46:08 +10:30
Daniel Klabbers	c151bc700a	Refactoring to drop extensions dir, see #774 ... satisfy nitpick	2016-03-02 09:04:10 +01:00
Toby Zerner	bc12114273	Merge pull request #840 from flarum/analysis-z4xEVE ... Applied fixes from StyleCI	2016-03-01 14:21:22 +10:30
Toby Zerner	03051f376e	Applied fixes from StyleCI	2016-02-29 22:51:13 -05:00
Toby Zerner	720b960515	Don't require a previous Post when saving event posts ... A bit of an edge-case since it shouldn't really be possible to have a discussion with zero posts anymore, but when renaming an empty discussion (or taking any action that will create an "event post"), Flarum would crash. This is due to the MergeableInterface requiring these posts to be saved after a previous post.	2016-02-29 18:50:27 +10:30
Toby Zerner	0f3b942c97	Fix crash when sending notification to non-existent user ... When renaming a discussion, an attempt is made to send a notification to the discussion's author. However, there is no check to see if the user account still exists - this can lead to a crash. While the check should technically be in the initiating code, it will probably slip through the cracks in other scenarios/extensions, so it's probably best that we safe-guard against this in the NotificationSyncer itself.	2016-02-29 18:48:02 +10:30
Toby Zerner	b0b388052a	Fix regressions related to deleting posts ... - On the front-end, correct the check to see if the discussion has no more posts - On the back-end, run a query to count the posts instead of using the comments_count, because the comments_count does not include other deleted posts	2016-02-29 18:41:59 +10:30
Franz Liedke	730a46d885	More indentation cleanup	2016-02-26 13:10:32 +09:00
Toby Zerner	b461f157ca	Use regex for username validation ... Laravel's alpha_dash rule allows unicode letters including those with inflections, leading to issues like #832. As per discussion in #557, we are sticking with ASCII-only usernames for now.	2016-02-26 13:59:05 +10:30
Franz Liedke	bc95ab8ae1	Improve alignment of string	2016-02-26 12:20:37 +09:00
Toby Zerner	49ea5d7923	Simplify StyleCI config	2016-02-26 13:47:17 +10:30
Toby Zerner	556755ee8c	Merge pull request #831 from flarum/analysis-qvQMPx ... Applied fixes from StyleCI	2016-02-26 13:40:39 +10:30
Toby Zerner	63c355c20d	Applied fixes from StyleCI	2016-02-25 22:09:39 -05:00
Toby Zerner	5fe8e6cd9a	Fix StyleCI misconfiguration error ... > The provided fixer 'unalign_double_arrow' cannot be disabled unless it was already enabled by your preset.	2016-02-26 13:36:19 +10:30
Toby Zerner	9e882d8023	Add StyleCI config	2016-02-26 13:35:09 +10:30
Toby Zerner	2f187dfd65	Delete a discussion when its last post is deleted. fixes #823	2016-02-26 13:26:09 +10:30
Toby Zerner	f375fd9241	Revert #687 + #197. fixes #785 ... Unfortunately we have no way to calculate the number of comment posts that are previous to the current viewing position of the discussion, without loading all of the posts which is going to be too expensive (even if we do it selectively somehow).	2016-02-26 13:11:52 +10:30
Toby Zerner	f6c3834b32	Recompile admin JS	2016-02-26 12:50:03 +10:30
Toby Zerner	3148f175cf	Refactor Composer rendering for smoother animations ... Also fixes a couple of miscellaneous bugs: - Minimise the Composer when clicking the preview button in full-screen mode on desktop. - Minimise the Composer when clicking the link to the discussion/post in the header on mobile/full-screen mode.	2016-02-26 12:49:49 +10:30
Franz Liedke	1cbab36fda	Just a tad of cleanup	2016-02-25 23:29:55 +09:00
Daniel Klabbers	3f4b880e77	refactoring to support array closures migrations and fixed issues with previous pr for extension rewriting	2016-02-25 23:26:10 +09:00
Franz Liedke	9c7523e3b1	Use the new migration shortcuts in most of core's migrations	2016-02-25 00:50:54 +09:00
Franz Liedke	14042bedaf	Add some handy shortcuts for typical migration tasks ... This will make it much easier for extension developers (and also less error-prone) to create migrations for things like creating tables, renaming columns and so on...	2016-02-25 00:50:03 +09:00
Franz Liedke	b2b3e8ff89	Remove obsolete AbstractMigration class	2016-02-24 23:22:52 +09:00
Franz Liedke	0411cc5137	Update generate:migration command to deal with new migration structure	2016-02-24 23:20:33 +09:00
Franz Liedke	14ecd325e1	Add two missing copyright headers	2016-02-24 22:25:09 +09:00
Franz Liedke	98546801bc	Revamp migration structure ... They are now simply files that return an array of closures, for running the named "up" and "down" actions, respectively. Related to #732.	2016-02-24 22:23:49 +09:00
Toby Zerner	61a0523e12	Fix crash when displaying a discussion with no posts. closes #823	2016-02-22 22:22:49 +10:30
Toby Zerner	7b0c318dc9	Condense into value/oninput into bidi	2016-02-22 21:22:18 +10:30
Toby Zerner	a979338ccb	Merge pull request #811 from sijad/firefox-fix ... Fix login box autocomplete in firefox	2016-02-22 21:09:18 +10:30
Franz Liedke	e376b74236	Merge pull request #817 from flarum/revert-813-typehint ... Revert "typehint fix, opening for implementation"	2016-02-18 17:35:17 +01:00
Franz Liedke	44586ed4c2	Revert "typehint fix, opening for implementation"	2016-02-18 17:33:34 +01:00
Franz Liedke	fe6c3b9ea5	Merge pull request #813 from Luceos/typehint ... typehint fix, opening for implementation	2016-02-17 16:12:15 +01:00
Daniel Klabbers	f9419926a5	typehint fix, opening for implementation	2016-02-17 13:34:13 +01:00
Sajjad Hasehmian	d49f8164f9	Fix login box autocomplete	2016-02-16 21:08:45 +03:30
Toby Zerner	28b5ab620b	Merge pull request #787 from sijad/401-page ... 401 for unauthorised request to settings, notifications page	2016-02-15 21:04:39 +10:30
Daniël Klabbers	6e0715e822	Merge pull request #801 from Luceos/extension_fix ... Extension fix	2016-02-14 22:18:08 +01:00
Daniel Klabbers	ef83a4681b	fixes #800, forgot these controllers	2016-02-13 20:33:33 +01:00
Daniel Klabbers	5179d2eb52	fixes #799, now properly assigning a id	2016-02-13 20:32:46 +01:00
Sajjad Hasehmian	28ed01ffcc	401 for unauthorised request to settings, notifications page fixes #714	2016-02-11 09:59:01 +03:30
Daniel Klabbers	b11b952aff	Implemented extensions as an object, usable by backend and frontend.	2016-02-10 15:13:51 +01:00
Franz Liedke	10f3846646	Merge pull request #786 from Luceos/imports ... reordering and removing unused imports	2016-02-10 15:02:37 +01:00
Franz Liedke	ca5c3079c9	Avoid use of model class in migration ... See commit 03db2b4	2016-02-10 14:17:38 +01:00
Franz Liedke	03db2b4cc0	Installer: Fix models not being ready for use when running migrations ... This was a regression after the recent introduction of a new migration that actually uses models. Maybe we should change this. See https://discuss.flarum.org/d/2023-can-t-manage-to-install-the-development-version-503-service-unavailable/8	2016-02-10 14:07:29 +01:00
Daniel Klabbers	20e4f64025	reordering and removing unused imports	2016-02-10 11:00:37 +01:00