Commit Graph

3364 Commits

Author SHA1 Message Date
w-4
3acee604d4 history back function fix
it shouldn't check for canGoBack again after the array pop()
2019-11-24 13:59:51 -05:00
Daniel Klabbers
a0ed6c5d69 incorrect ability used, drop prefix discussion. 2019-11-22 08:17:02 +01:00
Daniel Klabbers
07313a15c4 test only on the hidePosts policy ability 2019-11-22 08:17:02 +01:00
Daniel Klabbers
6fcc720f6c resume chain in query builder 2019-11-22 08:17:02 +01:00
Daniël Klabbers
b35afc2be7 [review] using orWhere to allow any where to follow in extensions 2019-11-22 08:17:02 +01:00
Daniël Klabbers
78e146dac8 fixes #1827
- set default statement to block access
- added tests to confirm all scenarios work as intended
2019-11-22 08:17:02 +01:00
Franz Liedke
2a71ee215c Automatically set up Mockery for unit tests
- Use provided PhpUnit listener to enforce verification of expectations.
- Include Mockery's trait to auto-close Mockery after each test.
2019-11-21 00:51:11 +01:00
Franz Liedke
b83edc54fc Actually return null
Nullable return types require an explicit null return value; not
returning or returning without value is the "void" type.
2019-11-21 00:46:01 +01:00
David Sevilla Martin
c357907c73 Add test for discussion posts being deleted on discussion delete from DB 2019-11-18 09:23:53 +01:00
David Sevilla Martin
41d55e6fe2 Fix failing tests 2019-11-18 09:23:53 +01:00
datitisev
ea03909fb2 Apply fixes from StyleCI
[ci skip] [skip ci]
2019-11-18 09:23:53 +01:00
David Sevilla Martin
2bb554e93b Remove 'or' from 'orWhereNotExists' 2019-11-18 09:23:53 +01:00
David Sevilla Martin
19c79c9dd3 Add discussion_id foreign key to posts table 2019-11-18 09:23:53 +01:00
flarum-bot
2a974bf8c6 Bundled output for commit 3e07f47b51 [skip ci] 2019-11-15 14:10:15 +00:00
Clark Winkelmann
3e07f47b51 Pass event to KeyboardNavigatable whenCallback (#1922)
This way the callback can know which key is pressed.
2019-11-15 15:08:36 +01:00
Daniël Klabbers
ba79935bfe Fix the queue:restart command (#1932)
Adding a proxy callStatic on our simple implementation of the Manager class allows passing through calls like `forever()` to the underlying cache driver instance.
2019-11-15 15:01:31 +01:00
Franz Liedke
1bb39bbacb Add a docblock 2019-11-13 21:19:21 +01:00
Daniël Klabbers
6e4c605da1 only show queue commands if using another driver than sync 2019-11-13 13:17:09 +01:00
flarum-bot
e8cbdfe6f8 Bundled output for commit 5c1e0293e3 [skip ci] 2019-11-12 19:27:29 +00:00
Daniël Klabbers
5c1e0293e3 Fix existing Post component classes being dropped 2019-11-12 20:26:07 +01:00
flarum-bot
29359568e8 Bundled output for commit 830f48a212 [skip ci] 2019-11-11 12:00:45 +00:00
Daniël Klabbers
830f48a212 Improved naming of class for post by actor.
Made class list for post extensible by using a separate method.
2019-11-11 12:59:26 +01:00
flarum-bot
9f0a178f58 Bundled output for commit f9da947d07 [skip ci] 2019-11-11 11:15:09 +00:00
Matthew Kilgore
f9da947d07 Removed LESS changes 2019-11-11 12:13:36 +01:00
Matthew Kilgore
37ecb7d9a5 Set border to left side only 2019-11-11 12:13:36 +01:00
Matthew Kilgore
6668f1b7ee Added border around post made by active user 2019-11-11 12:13:36 +01:00
flarum-bot
6d78445569 Bundled output for commit 8fc1458467 [skip ci] 2019-11-09 13:51:55 +00:00
David Sevilla Martin
8fc1458467 Cleanup some code and fix alert dismiss not working 2019-11-09 08:50:24 -05:00
Moritz Stueckler
f7176cb076 feat: re-add debug button/modal
Fixes #1687
2019-11-09 08:50:24 -05:00
David Sevilla Martin
898ab9000e Fix Modal width on <768px screens not occupying the whole page 2019-11-06 17:48:00 -05:00
flarum-bot
0ef0b0c0c0 Bundled output for commit 4211cbb9cb [skip ci] 2019-10-28 15:37:34 +00:00
Daniël Klabbers
4211cbb9cb Update User.js
Use recommended `anonymous`, see https://developer.mozilla.org/en-US/docs/Web/API/HTMLImageElement/crossOrigin
2019-10-28 16:35:45 +01:00
J.C.Ködel
41e97db5d0 Fix Color Thief cross origin bug
When users have external avatar urls (for instance: in a SSO environment where the avatar is provided by another domain), color thief fails to get the avatar dominant color because the canvas would be tainted. 

Following the instructions here (https://lokeshdhakar.com/projects/color-thief/ on the "Does it work if the image is hosted on another domain?"), adding an `image.crossOrigin = 'Anonymous';` solves the issue.

Tested on my forum which before suffered from a JS error and works fine (without this fix, the canvas remain in the `body` while an script error is thrown by color thief)
2019-10-28 16:35:45 +01:00
Franz Liedke
fef6612d62 Revert search performance regression
We decided it is better to have a less intelligent search (that does not
match search terms in titles) for some people than a bad-performing
search for everyone.

We will revisit the search performance topic in the next release cycle,
possibly with larger changes around indexing.

Refs #1738, #1741, #1764.
2019-10-26 15:41:39 +02:00
Daniël Klabbers
2febb2653f improve queue error handling 2019-10-18 13:13:30 +02:00
Daniël Klabbers
62e1a8e5c2 added return type hint to memory cache 2019-10-08 15:51:19 +02:00
Daniël Klabbers
ec04ca7f97 add type hinting to settings repository 2019-10-08 15:39:01 +02:00
luceos
479266b368 Apply fixes from StyleCI
[ci skip] [skip ci]
2019-10-07 09:56:10 +02:00
Daniël Klabbers
53b2d9fabb added ability to re-use existing error handling stack 2019-10-07 09:56:10 +02:00
David Sevilla Martin
7d15fb87b7 Alias 'flarum.queue.connection' to Queue contract 2019-10-05 16:14:27 -04:00
Tariq Hussein
2682c573eb Fixes #1877 Replace getIdsForUsername() with subquery instead. (#1878) 2019-10-02 01:04:01 +02:00
flarum-bot
9ddd1b6e81 Bundled output for commit 614b4a1d4e [skip ci] 2019-10-01 21:50:25 +00:00
Madalin Tache
614b4a1d4e Update window size (#1894)
This small change attempts to fix #1727, as i just got my eye on it and figured i could simply fix it while seeing it.
2019-10-01 23:48:54 +02:00
flarum-bot
4cab24225f Bundled output for commit 7fe95ec695 [skip ci] 2019-10-01 21:39:07 +00:00
David Sevilla Martín
7fe95ec695 Enable scrollbars in login button popups (#1900)
Fixes #1716
2019-10-01 23:37:42 +02:00
Daniël Klabbers
ccb8b1b6cc works towards #1789 by allowing event subscribing (#1810) 2019-10-01 11:12:46 +02:00
Franz Liedke
8faf774210 Amend the existing rel attribute of links
...instead of overwriting. This will play more nicely with extensions.

Refs #859.
2019-09-26 23:02:39 +02:00
Franz Liedke
2641b7c036 Stop opening external links in new tabs
We accept that this may be desired by forum owners and will offer an
extension to enable this feature. By default, we will not make any
assumptions and simply adopt the web's and browsers' default behavior.

Fixes #859.
2019-09-26 23:01:24 +02:00
Franz Liedke
5a9c1a91b2 Cleanup code from #1876
- Extract a method for email address generation
- Consistent types
- No docblocks for types where superfluous
- Tweak console output
- Don't inherit from integration test's base class in unit test
2019-09-24 01:00:22 +02:00
Stefan Totev
522d3356ca Normalize Base URL during installation
- Fix base url when is appended with a script filename
- Add default base url http://flarum.local when CLI wizard used
- Remove some code duplication
- Add minor improvement to the UX when CLI wizard used
- Add tests
- Extract base url normalisation into its own value object
2019-09-24 00:26:51 +02:00