github-mirror/framework
2
0
Fork 0
mirror of https://github.com/flarum/framework.git synced 2025-02-09 00:03:59 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity
4,440 Commits 90 Branches 52 Tags 191 MiB
718e01165a
Commit Graph

454 Commits

Author SHA1 Message Date
Alexander Skvortsov
718e01165a
Slightly improve AlertManagerState show typing 
`typeof Alert` is more correct than `Alert`, since we're accepting classes not instances.
 2021-12-13 20:20:35 -05:00
Alexander Skvortsov
311e858c2b
VnodeElementTag must be either a string or a class. 
Unfortunately, TypeScript only supports strings and classes for JSX tags.
Therefore, our type definition should only allow for those two types.
see https://github.com/microsoft/TypeScript/issues/14789#issuecomment-412247771
 2021-12-13 20:20:34 -05:00
Alexander Skvortsov
b13bc70339
Format VnodeElementTag fix 2021-12-13 20:20:34 -05:00
Alexander Skvortsov
a90140928c
Modal typescript cleanup and conversions 2021-12-13 20:20:34 -05:00
Alexander Skvortsov
162c60e763
alertAttrs can be null 2021-12-13 20:20:34 -05:00
Alexander Skvortsov
174345cf22
Fix LoadingModal attr typings 2021-12-13 20:20:34 -05:00
Alexander Skvortsov
fe9cec0787
Allow any Mithril Children where appropriate 2021-12-13 20:20:33 -05:00
Alexander Skvortsov
1bdfe0112c
extractText from translations where strings expected 2021-12-13 20:20:33 -05:00
Alexander Skvortsov
cc69211977
Fix import of mithril for VnodeElementTag usage 2021-12-13 20:20:33 -05:00
Alexander Skvortsov
02a57bfa8e
Don't assume app.session.user is present 2021-12-13 20:20:33 -05:00
Alexander Skvortsov
6c46fc4228
Merge pull request #3197 from flarum/as/permission-grid-fixes 
Permission grid fixes
 2021-12-13 18:56:11 -05:00
Alexander Skvortsov
1567ab0cb8
Return undefined => return null 2021-12-13 18:55:25 -05:00
Alexander Skvortsov
508be96f15
Don't throw errors for undefined relationships 2021-12-13 15:07:30 -05:00
Alexander Skvortsov
364575b3f0
Make sure this.data.attributes is initialized. 
`Object.assign` is not type-safe, and does ensure that the property being assigned to is not undefined.
 2021-12-13 12:34:51 -05:00
Alexander Skvortsov
4ade45e67a
Don't lazy draw permissions dropdown 
It is already lazy drawn, see 23a70affa6/js/src/admin/components/PermissionDropdown.js (L63-L63)
 2021-12-13 02:00:06 -05:00
Alexander Skvortsov
46893a9749
PermissionGrid fixes 
Fixes https://github.com/flarum/core/issues/3169#issuecomment-979470794

- Restore wrapping `scope.render` results in a table cell tag. This was accidentially introduced in 924815b6e1, and caused the issue linked above
- Rename the `SettingDropdown` attr `key` to `setting` in order to avoid naming clashes with Mithril vnode keys. `key` still works, but is deprecated.
 2021-12-13 02:00:06 -05:00
Alexander Skvortsov
6b7dfaa598
Format 2021-12-13 01:58:47 -05:00
Alexander Skvortsov
d0c160923d
Fix listItems to unbrick admin extension pages 
https://github.com/flarum/core/pull/3176 accidentially stopped adding a `key` attribute to wrappers of non-vnode inputs. This resulted in "all or no vnodes must have keys" errors.
 2021-12-13 01:34:05 -05:00
Alexander Skvortsov
f26ad3e32d
Minor typefixes, fomat 2021-12-12 15:46:46 -05:00
Alexander Skvortsov
4759395186
Post's discussion should always be present 2021-12-12 15:39:45 -05:00
Alexander Skvortsov
a2c8407dd4
params arguments for id-based app.store.find should be optional 2021-12-12 15:39:28 -05:00
Alexander Skvortsov
306b3a9e8b
Type-safe session instantiation 2021-12-12 15:39:06 -05:00
Alexander Skvortsov
4444e7c788
Rename Discussion, User files to allow jsx 2021-12-12 15:18:37 -05:00
Alexander Skvortsov
4bd5bc87ee
Update js/src/common/models/User.ts 
Co-authored-by: David Wheatley <hi@davwheat.dev>
 2021-12-12 15:18:37 -05:00
Alexander Skvortsov
528c964d94
Update js/src/common/models/User.ts 
Co-authored-by: David Wheatley <hi@davwheat.dev>
 2021-12-12 15:18:36 -05:00
Alexander Skvortsov
3bca30121b
Update js/src/common/models/Discussion.ts 
Co-authored-by: David Wheatley <hi@davwheat.dev>
 2021-12-12 15:18:36 -05:00
Alexander Skvortsov
53180a38ac
Update js/src/common/Store.ts 
Co-authored-by: David Wheatley <hi@davwheat.dev>
 2021-12-12 15:18:36 -05:00
Alexander Skvortsov
d82073c3a9
Update js/src/common/Model.ts 
Co-authored-by: David Wheatley <hi@davwheat.dev>
 2021-12-12 15:18:36 -05:00
Alexander Skvortsov
44efff342d
Update js/src/common/Model.ts 
Co-authored-by: David Wheatley <hi@davwheat.dev>
 2021-12-12 15:18:36 -05:00
Alexander Skvortsov
0bdb018ad4
Add meta to ApiPayload interfaces 2021-12-12 15:18:35 -05:00
Alexander Skvortsov
b0504597da
Review changes, make Model.store non-nullable, include meta in APIPayload signatures 2021-12-12 15:18:35 -05:00
Alexander Skvortsov
b85aa403cc
Remove unnecessary nonnull assertions 2021-12-12 15:18:35 -05:00
Alexander Skvortsov
ab2620147a
Drop unnecessary JSDocs 2021-12-12 15:18:35 -05:00
Alexander Skvortsov
09a55258a0
format 2021-12-12 15:18:34 -05:00
Alexander Skvortsov
3a8d640dab
Clean up model nullability 2021-12-12 15:18:34 -05:00
Alexander Skvortsov
bbc9143404
Convert models to TS 2021-12-12 15:18:34 -05:00
Alexander Skvortsov
580be37eb4
listItems typing fix (#3176) 
Co-authored-by: David Wheatley <hi@davwheat.dev>
 2021-12-12 14:51:05 -05:00
Ian Morland
325b9afca6
fix: getPlainContent causes external content to be fetched (#3193) 2021-12-12 14:30:56 -05:00
Alexander Skvortsov
57b413ada5
Split up application error handling (#3184) 
Co-authored-by: David Wheatley <hi@davwheat.dev>
 2021-12-11 12:32:51 -05:00
Rafał Całka
0f2824e0f4
Make StatusWidget tools extensible (#3189) 2021-12-07 13:50:40 -05:00
David Wheatley
c219699024
fix: clicking three dots on post opens all dropdowns in .Post-actions (#3185) 2021-12-06 18:03:07 +01:00
Ian Morland
6a909386b2
Move colorItems to ItemList (#3186) 2021-12-02 11:16:50 -05:00
Alexander Skvortsov
c7662a320f Fix app.route initialization 
The first argument being an object breaks the forum, since a function can work in `Object.assign` if it is the first argument.
 2021-12-01 17:05:57 -05:00
Alexander Skvortsov
c522657212
Improve avatar upload experience (#3181) 
Fixes https://github.com/flarum/core/issues/3055

- On the frontend, accept only image types as a hint to the OS file picker.
- On the backend, add more robust validation to ensure only valid images make it through. This isn't necessary for security, but results in less confusing error mesages.
 2021-12-01 15:16:45 -05:00
Alexander Skvortsov
29c290e78f
Convert routes to Typescript (#3177) 2021-12-01 11:27:19 -05:00
Alexander Skvortsov
71cb8c378f
Add typing files for our translator libraries (#3175) 2021-11-26 17:26:37 -05:00
David Wheatley
afbf5f4905
fix: incorrect typings for Modal hide() method (#3180) 
* fix: incorrect typings for `hide()`

* fix: swap to arrow calling of hide handler
 2021-11-23 22:54:26 +00:00
David Sevilla Martin
aa0b68bc8d
Convert some common classes/utils to TS (#2929) 
* Convert common/Session

* Update common/states/AlertManagerState

* Convert common/utils/extractText

Co-authored-by: David Wheatley <hi@davwheat.dev>
 2021-11-23 17:51:04 -05:00
David Sevilla Martin
94c4f266e3
feat: remove color validation in appearance admin page & add color indicator (#3140) 
* Remove color validation in basics admin page & add color indicator

* Create ColorInput common component

* Revert 'formGroupAttrs' addition

* Rename component CSS classes

* Fix input type in ColorInput from AdminPage#buildSettingComponent

* Rename component to ColorPreviewInput, remove aliases in admin & export in compat

* Remove leftovers from rebase on master

* feat: add global type definition for a vnode element tag

* fix(a11y): add aria roles to color input

* chore: use new type

* chore: format

Co-authored-by: David Wheatley <hi@davwheat.dev>
 2021-11-23 21:38:46 +00:00
Sami Mazouz
a203469109
fix: Modal typings complicate inheritance (#3178) 2021-11-23 14:02:14 +01:00