Commit Graph

8265 Commits

Author SHA1 Message Date
Alexander Skvortsov
7b8eaf9045 Fix typing errors with app.modal.show
Unfortunately TypeScript doesn't support higher-kinded types, so we can't write this in a type-safe way.
2021-12-13 20:20:35 -05:00
Alexander Skvortsov
850d555866 Slightly improve AlertManagerState show typing
`typeof Alert` is more correct than `Alert`, since we're accepting classes not instances.
2021-12-13 20:20:35 -05:00
Alexander Skvortsov
7b8d507139 VnodeElementTag must be either a string or a class.
Unfortunately, TypeScript only supports strings and classes for JSX tags.
Therefore, our type definition should only allow for those two types.
see https://github.com/microsoft/TypeScript/issues/14789#issuecomment-412247771
2021-12-13 20:20:34 -05:00
Alexander Skvortsov
959662f2e2 Format VnodeElementTag fix 2021-12-13 20:20:34 -05:00
Alexander Skvortsov
e1c6028dce Modal typescript cleanup and conversions 2021-12-13 20:20:34 -05:00
Alexander Skvortsov
da6ae898b2 alertAttrs can be null 2021-12-13 20:20:34 -05:00
Alexander Skvortsov
74f223cccc Fix LoadingModal attr typings 2021-12-13 20:20:34 -05:00
Alexander Skvortsov
0e2053da1f Allow any Mithril Children where appropriate 2021-12-13 20:20:33 -05:00
Alexander Skvortsov
d307331603 extractText from translations where strings expected 2021-12-13 20:20:33 -05:00
Alexander Skvortsov
a8db0b7bb2 Fix import of mithril for VnodeElementTag usage 2021-12-13 20:20:33 -05:00
Alexander Skvortsov
e79d3bc3b7 Don't assume app.session.user is present 2021-12-13 20:20:33 -05:00
flarum-bot
32d272c57f Bundled output for commit a10495d03e
Includes transpiled JS/TS, and Typescript declaration files (typings).

[skip ci]
2021-12-14 00:01:04 +00:00
Alexander Skvortsov
a10495d03e Merge pull request #3197 from flarum/as/permission-grid-fixes
Permission grid fixes
2021-12-13 18:56:11 -05:00
Alexander Skvortsov
9e678101ca Return undefined => return null 2021-12-13 18:55:25 -05:00
flarum-bot
e81104ce53 Bundled output for commit 3892d9b1fa
Includes transpiled JS/TS, and Typescript declaration files (typings).

[skip ci]
2021-12-13 21:35:24 +00:00
Alexander Skvortsov
3892d9b1fa Merge pull request #3200 from flarum/as/1_2_assorted_frontend_patches
A few frontend fixes for v1.2
2021-12-13 16:31:18 -05:00
Alexander Skvortsov
f4f9f1408c Sync with v2.1 of markdown-toolbar-element 2021-12-13 16:03:34 -05:00
Hasan Özbey
c8055090ca improve selected text stylization 2021-12-13 15:14:23 -05:00
Alexander Skvortsov
d494a6a7d0 Don't throw errors for undefined relationships 2021-12-13 15:07:30 -05:00
Alexander Skvortsov
d543ba9656 Make sure this.data.attributes is initialized.
`Object.assign` is not type-safe, and does ensure that the property being assigned to is not undefined.
2021-12-13 12:34:51 -05:00
Sami Mazouz
f7777ff9e3 perf: Fix eager loading of tag state relation in other endpoints (#151) 2021-12-13 11:34:51 +01:00
Sami Mazouz
e663bb6a55 perf: Allow loading relations in other discussion endpoints (#3191) 2021-12-13 11:34:26 +01:00
flarum-bot
5d8964584b Bundled output for commit ff3ea8bd0e
Includes transpiled JS/TS, and Typescript declaration files (typings).

[skip ci]
2021-12-13 07:03:23 +00:00
Alexander Skvortsov
30843fd7ef Don't lazy draw permissions dropdown
It is already lazy drawn, see 23a70affa6/js/src/admin/components/PermissionDropdown.js (L63-L63)
2021-12-13 02:00:06 -05:00
Alexander Skvortsov
fc43191ae3 PermissionGrid fixes
Fixes https://github.com/flarum/core/issues/3169#issuecomment-979470794

- Restore wrapping `scope.render` results in a table cell tag. This was accidentially introduced in 5a26dd8c4b, and caused the issue linked above
- Rename the `SettingDropdown` attr `key` to `setting` in order to avoid naming clashes with Mithril vnode keys. `key` still works, but is deprecated.
2021-12-13 02:00:06 -05:00
Alexander Skvortsov
ff3ea8bd0e Format 2021-12-13 01:58:47 -05:00
Alexander Skvortsov
f51fc7b502 Fix listItems to unbrick admin extension pages
https://github.com/flarum/core/pull/3176 accidentially stopped adding a `key` attribute to wrappers of non-vnode inputs. This resulted in "all or no vnodes must have keys" errors.
2021-12-13 01:34:05 -05:00
flarum-bot
d2a952d264 Bundled output for commit 17db36fb3c
Includes transpiled JS/TS, and Typescript declaration files (typings).

[skip ci]
2021-12-13 01:41:29 +00:00
Alexander Skvortsov
17db36fb3c Merge pull request #3174 from flarum/as/models-typing
Typescript for models
2021-12-12 20:37:32 -05:00
flarum-bot
8f48630458 Bundled output for commit fc06dba1b3
Includes transpiled JS/TS.

[skip ci]
2021-12-12 23:49:16 +00:00
Ian Morland
fc06dba1b3 feat: Display suspension to user (#41) 2021-12-13 00:48:10 +01:00
Ian Morland
e914deef6a feat: Allow switching the ImageManager driver (#3195) 2021-12-12 22:34:10 +01:00
Alexander Skvortsov
d62c20285d Minor typefixes, fomat 2021-12-12 15:46:46 -05:00
Alexander Skvortsov
32daeffa8a Post's discussion should always be present 2021-12-12 15:39:45 -05:00
Alexander Skvortsov
f469bcfcd7 params arguments for id-based app.store.find should be optional 2021-12-12 15:39:28 -05:00
Alexander Skvortsov
a8c56122fd Type-safe session instantiation 2021-12-12 15:39:06 -05:00
Alexander Skvortsov
ed84a21f18 Rename Discussion, User files to allow jsx 2021-12-12 15:18:37 -05:00
Alexander Skvortsov
4b5f680c39 Update js/src/common/models/User.ts
Co-authored-by: David Wheatley <hi@davwheat.dev>
2021-12-12 15:18:37 -05:00
Alexander Skvortsov
5881a053e8 Update js/src/common/models/User.ts
Co-authored-by: David Wheatley <hi@davwheat.dev>
2021-12-12 15:18:36 -05:00
Alexander Skvortsov
c9d8e73ea9 Update js/src/common/models/Discussion.ts
Co-authored-by: David Wheatley <hi@davwheat.dev>
2021-12-12 15:18:36 -05:00
Alexander Skvortsov
b460b8b5da Update js/src/common/Store.ts
Co-authored-by: David Wheatley <hi@davwheat.dev>
2021-12-12 15:18:36 -05:00
Alexander Skvortsov
9fc6a2333d Update js/src/common/Model.ts
Co-authored-by: David Wheatley <hi@davwheat.dev>
2021-12-12 15:18:36 -05:00
Alexander Skvortsov
c18dbbbe53 Update js/src/common/Model.ts
Co-authored-by: David Wheatley <hi@davwheat.dev>
2021-12-12 15:18:36 -05:00
Alexander Skvortsov
5df4a3df49 Add meta to ApiPayload interfaces 2021-12-12 15:18:35 -05:00
Alexander Skvortsov
982940ce78 Review changes, make Model.store non-nullable, include meta in APIPayload signatures 2021-12-12 15:18:35 -05:00
Alexander Skvortsov
11a72f8450 Remove unnecessary nonnull assertions 2021-12-12 15:18:35 -05:00
Alexander Skvortsov
2a7183b0a4 Drop unnecessary JSDocs 2021-12-12 15:18:35 -05:00
Alexander Skvortsov
70bd032cc7 format 2021-12-12 15:18:34 -05:00
Alexander Skvortsov
3c9c67d726 Clean up model nullability 2021-12-12 15:18:34 -05:00
Alexander Skvortsov
25934833b8 Convert models to TS 2021-12-12 15:18:34 -05:00