Commit Graph

139 Commits

Author SHA1 Message Date
Toby Zerner
c7d7b2d360 Fix subsequent pages of results not working properly 2017-11-13 09:17:55 +10:30
Toby Zerner
0ce00c6d16 Performance: Refactor SQL that pins unread sticky posts to the top
Ordering by `is_sticky and (unread subquery) desc` removes MySQL's
ability to use an index for ordering by `last_time`, which triggers a
filesort across the whole discussions table which is BAD.

This commit uses a union to add all stickied discussions to the query.
The results of the unioned queries are then ordered by the `is_sticky
and (unread subquery)` criteria, so the filesort only takes place on
a maximum of limit * 2 rows. Big performance win when you get up to
thousands of discussions!
2017-11-12 21:28:17 +10:30
Toby Zerner
7ff57e1ba4 Refactor sticky order clause into a subquery
Based on some limited testing, using a subquery seems to outperform a
join in this case (the join was invoking a temporary table, which is
always a bad sign).

This also adds logic to fix a bug where sticky discussions would remain
at the top even when marked as read using the "mark all as read" button.
I thought we had an open issue for this somewhere, but I can't seem to
find one. ref #988 #1003
2017-11-08 11:34:37 +10:30
Franz Liedke
b28f116b06 Fix class names 2017-10-03 19:45:54 +02:00
Franz Liedke
a8c43097d7 Update namespaces for beta 8
Refs flarum/core#1235.
2017-10-01 19:55:07 +02:00
Toby Zerner
86cc5fe9c8 Remove unused imports 2017-09-29 12:35:59 +09:30
Toby Zerner
5a9711fac9 Require b7 for new migration helper 2017-07-22 12:17:30 +09:30
Toby Zerner
9fb03d3549 Add default permissions 2017-07-22 12:09:36 +09:30
Franz Liedke
b775e59909 Merge pull request #6 from janga1997/patch-1
Hide diff for compiled diff files
2017-02-26 21:09:09 +01:00
VSN Reddy Janga
b7f2469523 Hide diff for compiled diff files 2017-02-20 19:28:13 +05:30
Franz Liedke
e3cd327d9f Merge pull request #5 from milescellar/patch-1
Update year
2017-01-02 20:04:47 +01:00
Miles Cellar
c1d7a2db51 Update year 2017-01-01 22:46:59 +01:00
Toby Zerner
bf71b101c2 Merge pull request #4 from flarum/analysis-z9nemo
Apply fixes from StyleCI
2016-11-29 16:01:22 +10:30
Toby Zerner
7564533d1d Apply fixes from StyleCI
[ci skip] [skip ci]
2016-11-29 05:29:44 +00:00
Toby Zerner
0653d74f0d Recompile JS 2016-11-19 22:09:38 +10:30
Toby Zerner
0802a9f139 Update StyleCI rules 2016-11-16 15:46:23 +10:30
Toby Zerner
6cb446837d v0.1.0-beta.6 2016-10-19 21:13:40 +10:30
Toby Zerner
dce149b536 Use new event name 2016-06-03 11:02:34 +09:30
Toby Zerner
5c6089b4df Recompile dist JS using latest version of babel 2016-06-03 11:02:28 +09:30
Toby Zerner
71db5f23e9 Require core v0.1.0-beta.5 2016-03-29 18:48:57 +10:30
Toby Zerner
fe90e5d6a5 Upgrade to flarum-gulp 0.2.0 / Babel 6 2016-03-18 09:33:31 +10:30
Toby Zerner
ad80f1bc1e Clean up linting stuff 2016-03-10 17:22:05 +10:30
Franz Liedke
da664d1624 Use new shortcuts for migrations 2016-03-04 01:12:30 +09:00
Toby Zerner
3b6fc53f91 Update MergeableInterface method arguments 2016-02-29 18:54:25 +10:30
Toby Zerner
3f1140db13 Merge pull request #3 from flarum/analysis-zOMd7B
Applied fixes from StyleCI
2016-02-26 14:27:07 +10:30
Toby Zerner
b59268b856 Applied fixes from StyleCI 2016-02-25 22:56:55 -05:00
Toby Zerner
648cad1a38 Add StyleCI config 2016-02-26 14:02:50 +10:30
Franz Liedke
ead84c29c5 Use new migration format 2016-02-24 23:13:39 +09:00
Toby Zerner
e3a43938ac Merge pull request #2 from maelsoucaze/patch-1
Update license year range to 2016
2016-01-26 11:14:39 +10:30
Maël Soucaze
a82d256366 Update license year range to 2016 2016-01-25 16:54:00 +01:00
Toby Zerner
1fdcf58014 Add Composer branch-alias
This allows installations to require version 0.1.0 with minimum-stability=dev, and they will get the latest from master.

See flarum/core#727
2016-01-19 17:18:10 +10:30
Toby Zerner
85c71af3a5 Rename package 2015-12-29 12:55:46 +10:30
Toby Zerner
a6a9e87873 Release 0.1.0-beta.3 2015-11-03 10:03:45 +10:30
Toby Zerner
395b45156b Translations are now automatically included 2015-11-02 18:52:52 +10:30
Toby Zerner
36b81b55bb Recompile JS 2015-10-27 12:40:16 +10:30
Toby Zerner
f7e815f6e6 Recompile JS 2015-10-27 12:17:08 +10:30
Toby Zerner
50e838e990 Remove unused notification component 2015-10-22 11:14:11 +10:30
Toby Zerner
5cef24a4af Merge pull request #1 from dcsjapan/key-reorganization
Reorganize key names
2015-10-22 11:13:24 +10:30
dcsjapan
160f092810 Reorganize key names
See [flarum/core #265](https://github.com/flarum/core/issues/265).

- Adjusts key names to three-tier namespacing.
- Extracts previously unextracted strings.
2015-10-22 09:21:00 +09:00
Toby Zerner
45e3e0fbff Change app.trans calls to app.translator.trans calls 2015-10-21 10:29:31 +10:30
Toby Zerner
d11d9d144a Update metadata 2015-10-12 15:01:20 +10:30
Toby Zerner
030e0c9938 Update API, add default translations 2015-10-11 22:24:12 +10:30
Toby Zerner
0ddd1dcd59 Rename initializer 2015-10-11 13:01:53 +10:30
Toby Zerner
37d7874705 Update for composer branch
Also remove sticky notification
2015-10-11 11:43:13 +10:30
Toby Zerner
0d7a7682be Add sticky permission to grid 2015-09-22 18:05:40 +09:30
Toby Zerner
efcbc80b7e Add gitattributes 2015-09-17 09:09:16 +09:30
Toby Zerner
04f33261ee Namespace migrations 2015-09-17 09:09:11 +09:30
Toby Zerner
3ab62fb0ca Add LICENSE information 2015-09-04 12:30:25 +09:30
Toby Zerner
33c86f38f1 Update npm dependency 2015-09-04 12:07:19 +09:30
Toby Zerner
fd5a6e6a5d Update flarum.json 2015-09-04 11:47:53 +09:30