Commit Graph

2294 Commits

Author SHA1 Message Date
Toby Zerner
b461f157ca Use regex for username validation
Laravel's alpha_dash rule allows unicode letters including those with inflections, leading to issues like #832. As per discussion in #557, we are sticking with ASCII-only usernames for now.
2016-02-26 13:59:05 +10:30
Franz Liedke
bc95ab8ae1 Improve alignment of string 2016-02-26 12:20:37 +09:00
Toby Zerner
49ea5d7923 Simplify StyleCI config 2016-02-26 13:47:17 +10:30
Toby Zerner
556755ee8c Merge pull request #831 from flarum/analysis-qvQMPx
Applied fixes from StyleCI
2016-02-26 13:40:39 +10:30
Toby Zerner
63c355c20d Applied fixes from StyleCI 2016-02-25 22:09:39 -05:00
Toby Zerner
5fe8e6cd9a Fix StyleCI misconfiguration error
> The provided fixer 'unalign_double_arrow' cannot be disabled unless it was already enabled by your preset.
2016-02-26 13:36:19 +10:30
Toby Zerner
9e882d8023 Add StyleCI config 2016-02-26 13:35:09 +10:30
Toby Zerner
2f187dfd65 Delete a discussion when its last post is deleted. fixes #823 2016-02-26 13:26:09 +10:30
Toby Zerner
f375fd9241 Revert #687 + #197. fixes #785
Unfortunately we have no way to calculate the number of comment posts that are previous to the current viewing position of the discussion, without loading all of the posts which is going to be too expensive (even if we do it selectively somehow).
2016-02-26 13:11:52 +10:30
Toby Zerner
f6c3834b32 Recompile admin JS 2016-02-26 12:50:03 +10:30
Toby Zerner
3148f175cf Refactor Composer rendering for smoother animations
Also fixes a couple of miscellaneous bugs:
- Minimise the Composer when clicking the preview button in full-screen mode on desktop.
- Minimise the Composer when clicking the link to the discussion/post in the header on mobile/full-screen mode.
2016-02-26 12:49:49 +10:30
Franz Liedke
1cbab36fda Just a tad of cleanup 2016-02-25 23:29:55 +09:00
Daniel Klabbers
3f4b880e77 refactoring to support array closures migrations and fixed issues with previous pr for extension rewriting 2016-02-25 23:26:10 +09:00
Franz Liedke
9c7523e3b1 Use the new migration shortcuts in most of core's migrations 2016-02-25 00:50:54 +09:00
Franz Liedke
14042bedaf Add some handy shortcuts for typical migration tasks
This will make it much easier for extension developers (and also less
error-prone) to create migrations for things like creating tables,
renaming columns and so on...
2016-02-25 00:50:03 +09:00
Franz Liedke
b2b3e8ff89 Remove obsolete AbstractMigration class 2016-02-24 23:22:52 +09:00
Franz Liedke
0411cc5137 Update generate:migration command to deal with new migration structure 2016-02-24 23:20:33 +09:00
Franz Liedke
14ecd325e1 Add two missing copyright headers 2016-02-24 22:25:09 +09:00
Franz Liedke
98546801bc Revamp migration structure
They are now simply files that return an array of closures, for
running the named "up" and "down" actions, respectively.

Related to #732.
2016-02-24 22:23:49 +09:00
Toby Zerner
61a0523e12 Fix crash when displaying a discussion with no posts. closes #823 2016-02-22 22:22:49 +10:30
Toby Zerner
7b0c318dc9 Condense into value/oninput into bidi 2016-02-22 21:22:18 +10:30
Toby Zerner
a979338ccb Merge pull request #811 from sijad/firefox-fix
Fix login box autocomplete in firefox
2016-02-22 21:09:18 +10:30
Franz Liedke
e376b74236 Merge pull request #817 from flarum/revert-813-typehint
Revert "typehint fix, opening for implementation"
2016-02-18 17:35:17 +01:00
Franz Liedke
44586ed4c2 Revert "typehint fix, opening for implementation" 2016-02-18 17:33:34 +01:00
Franz Liedke
fe6c3b9ea5 Merge pull request #813 from Luceos/typehint
typehint fix, opening for implementation
2016-02-17 16:12:15 +01:00
Daniel Klabbers
f9419926a5 typehint fix, opening for implementation 2016-02-17 13:34:13 +01:00
Sajjad Hasehmian
d49f8164f9 Fix login box autocomplete 2016-02-16 21:08:45 +03:30
Toby Zerner
28b5ab620b Merge pull request #787 from sijad/401-page
401 for unauthorised request to settings, notifications page
2016-02-15 21:04:39 +10:30
Daniël Klabbers
6e0715e822 Merge pull request #801 from Luceos/extension_fix
Extension fix
2016-02-14 22:18:08 +01:00
Daniel Klabbers
ef83a4681b fixes #800, forgot these controllers 2016-02-13 20:33:33 +01:00
Daniel Klabbers
5179d2eb52 fixes #799, now properly assigning a id 2016-02-13 20:32:46 +01:00
Sajjad Hasehmian
28ed01ffcc 401 for unauthorised request to settings, notifications page fixes #714 2016-02-11 09:59:01 +03:30
Daniel Klabbers
b11b952aff Implemented extensions as an object, usable by backend and frontend. 2016-02-10 15:13:51 +01:00
Franz Liedke
10f3846646 Merge pull request #786 from Luceos/imports
reordering and removing unused imports
2016-02-10 15:02:37 +01:00
Franz Liedke
ca5c3079c9 Avoid use of model class in migration
See commit 03db2b4
2016-02-10 14:17:38 +01:00
Franz Liedke
03db2b4cc0 Installer: Fix models not being ready for use when running migrations
This was a regression after the recent introduction of a new migration that actually uses models.
Maybe we should change this.

See https://discuss.flarum.org/d/2023-can-t-manage-to-install-the-development-version-503-service-unavailable/8
2016-02-10 14:07:29 +01:00
Daniel Klabbers
20e4f64025 reordering and removing unused imports 2016-02-10 11:00:37 +01:00
Toby Zerner
e3f6092c32 Merge pull request #784 from sijad/no-confirm
Remove "Mark as Read" confirmation fixes #782
2016-02-10 18:13:38 +10:30
Sajjad Hasehmian
50b756e55e Remove "Mark as Read" confirmation fixes #782 2016-02-10 10:50:24 +03:30
Toby Zerner
9324af12ea Merge pull request #779 from sijad/uri-fix
Correct redirect uri in OAuth2 Controller
2016-02-10 07:06:14 +10:30
Sajjad Hasehmian
45a4849448 Correct redirect uri in OAuth2 Controller (fixes #778) 2016-02-09 18:01:59 +03:30
Toby Zerner
c1236bc7ff Slightly widen index sidebar, overflow buttons properly
First half of #349 fix. Supersedes #734 (190px wide instead of 200px, correctly modify margin-left of .sideNavOffset, more descriptive commit message)
2016-02-07 12:10:02 +10:30
Toby Zerner
f2b6b61811 Merge pull request #748 from JoshyPHP/Minifiers
Added support for new minifiers
2016-02-07 11:37:15 +10:30
Toby Zerner
894144405a Update Mithril 2016-02-06 18:58:34 +10:30
Toby Zerner
f0564b7588 Better post scrubber size calculations. fixes #109 2016-02-06 18:47:09 +10:30
Franz Liedke
56956a84aa Use stored slug for generating server-rendered link to discussion
Fixes #646.
2016-02-04 11:47:03 +01:00
Franz Liedke
373452b395 Store discussion slug in database table
In preparation for #646.
2016-02-04 11:46:30 +01:00
Toby Zerner
a9fdbd02ae Add priorities to user page sidebar items 2016-01-31 17:11:13 +10:30
Toby Zerner
51d6a23b83 Refactor ListPostsController, make filtering extensible
It became apparent in https://github.com/flarum/core/issues/319#issuecomment-170558573 that there was no way for extensions to add filter parameters to the /api/posts endpoint (e.g. /api/posts?filter[mentioned]=1). Simply adding an event to modify the `$where` array severely limits how much can be done with the query. This commit refactors the controller so that filters are applied directly to the query Builder, and exposes the Builder in a new `ConfigurePostsQuery` event.
2016-01-31 17:06:38 +10:30
Toby Zerner
553a49af56 Fix fatal error
"PHP Fatal error:  Cannot use Symfony\Component\Translation\Translator as Translator because the name is already in use"
2016-01-31 15:35:53 +10:30