489 Commits

Author	SHA1	Message	Date
David Wheatley	6e3051b36a	fix: sort posts by number instead of creation datetime (#3282) ... Co-authored-by: Alexander Skvortsov <38059171+askvortsov1@users.noreply.github.com>	2022-02-09 20:58:11 +00:00
David Wheatley	21d3e33613	chore: remove call to console.log	2022-02-06 02:12:52 +00:00
Alexander Skvortsov	beae75dab3	chore: fl-dev audit infra --fix	2022-01-20 03:19:22 -05:00
David Wheatley	a7aad46068	fix: mark near as optional in discussion route (#3257)	2022-01-14 00:25:29 -05:00
Alexander Skvortsov	f4c29db182	fix: Allow outside click on modal focus trap ... Without this, alerts triggered while a modal is open can't be dismissed.	2022-01-08 22:55:48 -05:00
Alexander Skvortsov	a291134da1	fix: don't spellcheck custom LESS ... This should stop browsers from "correcting" code, and from converting regular quotes to "smart" quotes.	2022-01-08 22:55:48 -05:00
Alexander Skvortsov	67821d95bd	fix: Ensure user not false in post component ... If no information about a relation exists, it will return false, not undefined. Therefore, the nullsafe operator is not enough to avoid issues here.	2022-01-08 18:26:51 -05:00
Alexander Skvortsov	7cec4d1f42	Format	2022-01-04 21:13:42 -05:00
Alexander Skvortsov	fbe1a48bec	Fix echo statements not showing up in debug modals or console trace ... This was accidentially introduced in the recent Application permissions refactor, where `formattedError`was changed to always be a string array.	2022-01-04 21:13:15 -05:00
Alexander Skvortsov	85ee80659d	fix: broken post/discussion soft delete (#3249) ... * FIx broken post/discussion soft delete Before the Model typescript rewrite, `pushAttributes` supported including relationship objects, which is hacky but incorrect behavior. With the rewrite, this functionality was broken. This PR deprecates the functionality, adds a deprecated BC layer with a debug warning, and removes instances of incorrect usage. * Update js/src/common/Model.ts Co-authored-by: David Wheatley <hi@davwheat.dev> * Update js/src/common/Model.ts Co-authored-by: David Wheatley <hi@davwheat.dev> * chore: format Co-authored-by: David Wheatley <hi@davwheat.dev>	2022-01-04 13:26:46 +00:00
David Wheatley	2541cdec94	fix: prevent unwarranted a11y warnings on custom Button subclasses (#3238) ... * fix: prevent unwarranted a11y warnings on UploadImageButton * chore: format * refactor * fix: remove attr	2021-12-29 10:37:58 +01:00
David Wheatley	993500aae4	fix(a11y): fix a11y warning in alert, and other a11y fixes (#3237) ... * fix(a11y): fix a11y warning in alert, and other a11y fixes * chore: correct import * chore: use `class`	2021-12-28 21:08:34 +01:00
David Wheatley	94f9e7f9de	fix: don't fire deprecation warnings for Mithril-originating action (#3236) ... * fix: don't fire deprecation warnings for Mithril-originating actions * Add comment	2021-12-28 20:51:13 +01:00
David Wheatley	a4fbf16eef	fix: mark render method in RouteResolver as optional (#3235)	2021-12-28 20:36:11 +01:00
Alexander Skvortsov	cff672424b	Merge pull request #3228 from flarum/as/v1.2_frontend_fixes ... Some v1.2 frontend fixes	2021-12-27 20:24:53 -05:00
Alexander Skvortsov	b7f2fe2429	Fix consecutive shows of same modal with different attrs ... We need to specify a unique key for each modal so that the modals are fully destroyed and recreated. For instance, this fixes the signup modal being empty with OAuth register flows.	2021-12-27 18:28:11 -05:00
Alexander Skvortsov	a55b61e058	Use translations for page titles in frontend ... This gives more flexibility for customization, and allows overriding title structure via translations / linguist.	2021-12-27 18:15:12 -05:00
Alexander Skvortsov	206aa227f2	Only retain scroll position if coming from discussion (#3229) ... Fixes https://discuss.flarum.org/d/29596-make-tag-hero-visible/8. If a user has just switched from one tag to another, they want to see the entire new discussion list, and information about which tag that discussion list corresponds to. There's no good reason to not display the hero header when switching tags.	2021-12-27 18:13:29 -05:00
David Wheatley	ad8ac4e342	fix: posts tab on users page broken	2021-12-27 21:32:04 +01:00
David Wheatley	d5cd0bd339	fix: returning null breaking CommentPosts	2021-12-27 20:54:00 +01:00
David Wheatley	d268894e61	chore: 1.2 JS clean-up (#3214) ... * fix: `extend.ts` TS error * docs: fix incorrect JS docblocks * chore: simplify some code * chore: remove usages of prefixed JS function * chore: consistent empty return types * chore: format * fix: typing errors * chore: remove unneeded `@public` docblock modifiers * Apply suggestions from code review * Update js/src/forum/utils/slidable.js Co-authored-by: Alexander Skvortsov <38059171+askvortsov1@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Alexander Skvortsov <38059171+askvortsov1@users.noreply.github.com>	2021-12-27 18:58:18 +00:00
Alexander Skvortsov	d89031f057	Fix drawer focus trap making login form unclickable on mobile ... Adding `clickOutsideDeactivates` seems to fix the issue, contrary to what the focus-trap documentation implies about it being unnecessary.	2021-12-26 22:45:58 -05:00
Alexander Skvortsov	0c95d28e94	Fix Search error when user can't search ... If there are no search sources, HTML for the Search component won't be rendered, so trying to attach listeners to it will likely error. In this PR, we don't attach such listeners/logic if there are no sources. We also stop asserting that sources is defined to help avoid other similar issues in the future.	2021-12-26 20:04:48 -05:00
David Wheatley	a2f417e9c5	fix: incorrect return type on pushPayload (#3226)	2021-12-26 01:25:16 -05:00
David Wheatley	7a27f494c6	fix: hide WelcomeHero when content is empty (#3219)	2021-12-22 13:54:21 -05:00
David Wheatley	e57655553f	fix: breaking change in Search component - renaming of state property (#3212) ... * fix: breaking change in search component's public api * fix: add setter * feat: add deprecation warning helper This reduces bundle size as a result of deprecation warning in our JS, as well as maintaining a consistent format across warnings. * feat: fire deprecation warning on usage of `Search.state` * chore: use consistent deprecation warning across core * fix: `/pull` not `/issue` * chore: format	2021-12-20 16:28:28 +00:00
David Wheatley	a1cc456f3a	fix(postmeta): use app baseUrl instead of location.origin (#3216)	2021-12-20 16:25:04 +00:00
Sami Mazouz	a36f98d1fc	fix: Add a11y labels to auth modal inputs (#3207)	2021-12-16 09:30:34 +01:00
David Wheatley	726661fe8c	fix: replace throw with debug warning to fix breaking change (#3206) ... * fix: replace throw with debug warning to fix breaking change * Add link back to PR in warning * fix: add missing `return null` for `!allowUnregistered` code path * Clean up message -- move more info to PR comment * Add setTimeout to delay call debug warning call until after `app.forum` is defined * Add backticks around data type	2021-12-15 10:48:46 -05:00
Ian Morland	c9a8543554	feat: extract notification primaryControl items to an ItemList (#3204)	2021-12-14 22:11:48 +00:00
Alexander Skvortsov	c88a3e7e89	Merge pull request #2961 from the-turk/style-st ... Improve selected text stylization	2021-12-14 12:06:22 -05:00
Alexander Skvortsov	cbbb574e37	Format and Type Import Cleanup ... Co-authored-by: David Wheatley <hi@davwheat.dev>	2021-12-13 22:04:36 -05:00
Alexander Skvortsov	55dd8f17f3	Fix typing errors with app.modal.show ... Unfortunately TypeScript doesn't support higher-kinded types, so we can't write this in a type-safe way.	2021-12-13 20:20:35 -05:00
Alexander Skvortsov	718e01165a	Slightly improve AlertManagerState show typing ... `typeof Alert` is more correct than `Alert`, since we're accepting classes not instances.	2021-12-13 20:20:35 -05:00
Alexander Skvortsov	311e858c2b	VnodeElementTag must be either a string or a class. ... Unfortunately, TypeScript only supports strings and classes for JSX tags. Therefore, our type definition should only allow for those two types. see https://github.com/microsoft/TypeScript/issues/14789#issuecomment-412247771	2021-12-13 20:20:34 -05:00
Alexander Skvortsov	b13bc70339	Format VnodeElementTag fix	2021-12-13 20:20:34 -05:00
Alexander Skvortsov	a90140928c	Modal typescript cleanup and conversions	2021-12-13 20:20:34 -05:00
Alexander Skvortsov	162c60e763	alertAttrs can be null	2021-12-13 20:20:34 -05:00
Alexander Skvortsov	174345cf22	Fix LoadingModal attr typings	2021-12-13 20:20:34 -05:00
Alexander Skvortsov	fe9cec0787	Allow any Mithril Children where appropriate	2021-12-13 20:20:33 -05:00
Alexander Skvortsov	1bdfe0112c	extractText from translations where strings expected	2021-12-13 20:20:33 -05:00
Alexander Skvortsov	cc69211977	Fix import of mithril for VnodeElementTag usage	2021-12-13 20:20:33 -05:00
Alexander Skvortsov	02a57bfa8e	Don't assume app.session.user is present	2021-12-13 20:20:33 -05:00
Alexander Skvortsov	6c46fc4228	Merge pull request #3197 from flarum/as/permission-grid-fixes ... Permission grid fixes	2021-12-13 18:56:11 -05:00
Alexander Skvortsov	1567ab0cb8	Return undefined => return null	2021-12-13 18:55:25 -05:00
Alexander Skvortsov	080442d085	Sync with v2.1 of markdown-toolbar-element	2021-12-13 16:03:34 -05:00
Hasan Özbey	fb82afa97f	improve selected text stylization	2021-12-13 15:14:23 -05:00
Alexander Skvortsov	508be96f15	Don't throw errors for undefined relationships	2021-12-13 15:07:30 -05:00
Alexander Skvortsov	364575b3f0	Make sure this.data.attributes is initialized. ... `Object.assign` is not type-safe, and does ensure that the property being assigned to is not undefined.	2021-12-13 12:34:51 -05:00
Alexander Skvortsov	4ade45e67a	Don't lazy draw permissions dropdown ... It is already lazy drawn, see 23a70affa6/js/src/admin/components/PermissionDropdown.js (L63-L63)	2021-12-13 02:00:06 -05:00