Commit Graph

3137 Commits

Author SHA1 Message Date
Daniël Klabbers
2dced2e6c8 Fixes #1686
- further cleaned up the toggle action
- there's no way to remove the redraws because then the jquery isn't being fired properly
2019-01-25 05:37:45 +01:00
Toby Zerner
2d714a06b5 Make the Request available to the Formatter\Rendering event (#1721)
This is important because extensions may wish to render post content
differently depending on Request factors such as the actor. For example,
an attachments extension might wish to hide attachments from guests.

This solution is a bit of a hack-job for now, but soon when we refactor
the API layer to use tobscure/json-api-server, and also refactor the
Formatter layer, it can be revised.
2019-01-22 23:33:49 +01:00
Daniël Klabbers
ca02e2adf4 Merge branch 'master' of github.com:flarum/core 2019-01-16 11:59:04 +01:00
Daniël Klabbers
a5363e084d update symfony/console, because illuminate/console needs a higher version 2019-01-16 11:58:42 +01:00
flarum-bot
dc92dea235 Bundled output for commit a39782368e [skip ci] 2019-01-16 09:05:46 +00:00
Daniël Klabbers
a39782368e fixes #1686, unable to edit user password 2019-01-16 09:58:22 +01:00
Daniël Klabbers
1c7789683b set prefixing indices to be done automatically, now that illuminate can take care of that 2019-01-15 20:49:33 +01:00
Daniël Klabbers
b5bc2b2e87 further revert #41688c7 2019-01-15 20:49:06 +01:00
Daniël Klabbers
d56ea1ef07 reverts #41688c7 2019-01-15 20:39:38 +01:00
Daniël Klabbers
f0d626aaa7 Increasing test coverage (#1711)
* added a few more tests, renamed singular to plural to match controller

* increase error reporting

* removed debugging and wait for tests
2019-01-01 21:02:18 +01:00
Franz Liedke
7e0ec84028 Mail: Add an array of supported drivers
This can be used for e.g. validation, or a dropdown in the frontend.
It can also be extended by extensions, such as flagrow/mail-drivers.

Refs #1169.
2018-12-20 13:36:08 +01:00
Franz Liedke
77247d4378 Apply fixes from StyleCI (#1714)
[ci skip] [skip ci]
2018-12-20 13:13:58 +01:00
Franz Liedke
3fb0072b64 Register service providers alphabetically
Order should not matter - and this is the only one that can
realistically stay consistent.
2018-12-20 13:13:04 +01:00
Franz Liedke
9d3f2b1c49 Use a custom service provider for email configuration 2018-12-20 13:10:30 +01:00
Daniël Klabbers
8e37c2b8d8 updated constraint for 5.7 (#1698) 2018-12-20 08:20:52 +10:30
Franz Liedke
9989e76750 Don't resolve services when binding listeners
Refs #1578.
2018-12-19 22:47:58 +01:00
Franz Liedke
a26985cb0d Apply fixes from StyleCI (#1713)
[ci skip] [skip ci]
2018-12-19 22:42:54 +01:00
Franz Liedke
fadf87470d Avoid unnecessary event subscribers
Refs #1578.
2018-12-19 22:27:32 +01:00
Franz Liedke
c0a51b340b Fix UpdateServiceProvider
- Shorten registration of routes
- Do not resolve view factory before booting
2018-12-19 22:17:44 +01:00
Franz Liedke
428b2f07e8 Locale: Don't resolve manager just to configure it
Refs #1578.
2018-12-19 22:07:31 +01:00
Franz Liedke
4cd503746f Shorten registration of routes 2018-12-19 21:57:59 +01:00
Franz Liedke
c923d23f32 Frontends: Populate default routes only when they are resolved 2018-12-19 21:55:58 +01:00
Franz Liedke
6d1349e861 Make site extenders run after extensions
Fixes #1708.
2018-12-19 21:30:29 +01:00
Daniël Klabbers
3604dde442 add 7.3 to travis (#1710) 2018-12-19 18:09:36 +01:00
Daniel Klabbers
80c6efa1e8 fixes #1695, post comment count is incorrectly calculated based on all posts, including events 2018-12-19 15:07:32 +01:00
Daniel Klabbers
f1c672e12d fixes a notice due to the forum variable not being defined before compacting 2018-12-19 11:40:48 +01:00
Franz Liedke
b461281e09 Run local extenders before booting service providers
We still need to discuss the priority of local extenders vs. those
from enabled extensions, but let's first fix the actual bug.

Refs #1708.
2018-12-18 11:16:57 +01:00
Franz Liedke
9f3770eedb API: Populate default routes only when they are resolved
Refs #1708.
2018-12-18 10:33:01 +01:00
Franz Liedke
e27cd69974 Allow passing strings (names of invokable classes) to Formatter extender
In preparation for fixing #1703.
2018-12-15 12:05:17 +01:00
Toby Zerner
2c6398b8e3 Remove obsolete binding 2018-12-14 11:28:11 +10:30
Franz Liedke
3a6e577329 Apply fixes from StyleCI (#1701)
[ci skip] [skip ci]
2018-12-14 01:48:19 +01:00
Franz Liedke
8614bc65d5 Use class constant to get qualified class names 2018-12-14 01:47:54 +01:00
Franz Liedke
c17c785b61 Get rid of docblocks that don't add information 2018-12-13 23:08:49 +01:00
Franz Liedke
4175755a12 Early returns 2018-12-13 23:06:59 +01:00
Kirill
83eebeba2c Fix incorrect docs link (#1699) 2018-12-13 20:19:13 +01:00
Franz Liedke
3e914b7d39 Merge pull request #1697 from flarum/fl/1578-speed-up-extenders
Do not resolve services in extenders
2018-12-13 10:33:00 +01:00
Franz Liedke
d97f7136df Inject dependencies when firing events, not before
The event subscriber approach means that dependencies have to be
injected (and thus instantiated, along with all *their* dependencies) at
the time of registering event listeners - even when events are never
fired within a request's lifecycle.

This is unnecessary and causes more classes than necessary to be loaded.

In this case, we can explicitly register event listeners that will
resolve their dependencies when the event is fired, not before.

Refs #1578.
2018-12-13 02:01:50 +01:00
Franz Liedke
25c8ab0a35 Do not resolve services when extending them
Refs #1578.
2018-12-13 01:58:54 +01:00
David Sevilla Martín
13a6bd535b Fix DELETE /api/extensions/* returning 500 (#1580)
* Use extension string as parameter for ::disable & ::uninstall

* Remove repeated 'ExtensionManager::disable' call

* Fix StyleCI
2018-12-13 00:16:03 +01:00
Arda Çebi
833056dd68 Profile group badge overlapping fix (#1506) 2018-12-12 22:24:30 +01:00
Franz Liedke
57dd0bcbb5 Update changelog 2018-12-10 22:52:50 +01:00
Franz Liedke
46e0e7e042 Add an issue template for security vulnerabilities 2018-12-10 22:43:03 +01:00
David Sevilla Martín
6d185eecf1 Add 'hasPermission' helper to Group (#1688)
* Add Group@hasPermission helper

* Improve performance of method
2018-12-10 22:32:21 +01:00
Franz Liedke
7ffca76c61 Fix incorrect column name for registration token
Oversight from the database renamings, I suppose.

Fixes #1691.
2018-12-09 23:17:04 +01:00
Toby Zerner
13ce2d1e3d Performance: Actually make use of the translator cache
We had added a `storage/locale` directory to our skeleton, but we had
forgotten to hook it up with the translator. Enabling caching saves
parsing that locale YAML files on every pageload which should be good
for performance.

The locale cache will be cleared whenever an extension that uses the
`Locales` or `LanguagePack` extenders is enabled/disabled. If debug
mode is ON, then the caching mechanism will automatically check if any
of the loaded YAML files are dirty and update accordingly.
2018-12-07 09:38:08 +10:30
Toby Zerner
6b6fce878a Add another commit 2018-12-07 09:13:44 +10:30
Franz Liedke
36a0231796 Release version 0.1.0-beta.8.1 2018-12-06 00:47:38 +01:00
Franz Liedke
de73685764 Do not create tables as InnoDB automatically, rely on connection default
As argued in #1675, this makes us slightly less reliant on MySQL.
2018-12-06 00:34:43 +01:00
Toby Zerner
d7fd5ef11e Don't output empty html tag attributes
From https://discuss.flarum.org/d/17817-meta-description-is-empty/8
ref #1677
2018-12-04 09:47:49 +10:30
Toby Zerner
2b9e969b95 Fix empty meta description tag. Fixes #1677 2018-12-04 09:28:24 +10:30