Commit Graph

2664 Commits

Author SHA1 Message Date
Daniël Klabbers
a2fcb01dac public path should not be writable, but base path should 2018-03-21 20:52:49 +01:00
Franz Liedke
a8795b02b9 List debug mode setting in info output 2018-03-19 23:28:05 +01:00
Franz Liedke
2f5a8f1a90 Recompile JavaScript 2018-03-19 23:21:57 +01:00
David Sevilla Martín
f480849c7c Merge branch 'master' into patch-2 2018-03-19 18:20:11 -04:00
Franz Liedke
c3f115387e Return empty response
Without this, the new version of Stratigility complained about no
response being returned. Old versions were more graceful here, but
this is certainly more correct.
2018-03-19 23:06:27 +01:00
David Sevilla Martín
80de4fe797 always return a promise in PostStream#update 2018-03-18 20:37:04 -04:00
Franz Liedke
92cb3b9166 Split up Locale extender
Now we have two extenders:
- `Extend\LanguagePack` is the "convention over configuration" loader
  for complete language packs.
- `Extend\Locales` can be used to load files (by locale) from a given
  directory - useful for extensions that bring along their own locales
  in multiple different languages.

Refs #851.
2018-03-19 01:07:59 +01:00
Franz Liedke
d60cec33be Bind session handling to request lifecycle
With this change, session objects are no longer instantiated
globally, but instead created within a middleware during the
request lifecycle.

In addition, session garbage collection is integrated with
the already existing middleware for this purpose.
2018-03-18 15:58:31 +01:00
Toby Zerner
a0105eb40b Use Illuminate Session component instead of Symfony
Symfony's component relies on PHP's native session functionality, which
is not ideal. It automatically sets its own cookie headers, resulting in
this issue: https://github.com/flarum/core/issues/1084#issuecomment-364569953

The Illuminate component is more powerful and has a simpler API for
extension with other drivers and such, and fits in nicely with other
components we use (the majority of which are from Illuminate).
2018-03-18 14:43:44 +01:00
Franz Liedke
87860b471f Ignore Composer's lockfile 2018-03-18 14:33:47 +01:00
Franz Liedke
86e47deaa5 Apply fixes from StyleCI (#1391)
[ci skip] [skip ci]
2018-03-18 13:53:44 +01:00
Franz Liedke
aa48fd5c84 Update Stratigility, use http-interop middleware 2018-03-18 13:52:16 +01:00
Toby Zerner
a96f94d3e6 Merge pull request #1384 from flarum/fix-hash-binding
fixes the broken hash & hash.driver ioc binding which is part of 5.6
2018-03-09 12:41:28 +10:30
Daniël Klabbers
45097420a7 fixes the broken hash & hash.driver ioc binding which is part of 5.6 2018-03-08 14:25:25 +01:00
Toby Zerner
f8afe53e70 Merge pull request #1382 from clarkwinkelmann/patch-2
Remove unused $lifetime variable
2018-03-07 11:42:41 +10:30
Clark Winkelmann
8f9d9061b4 Remove unused $lifetime variable 2018-03-07 01:30:23 +01:00
Franz Liedke
e30de50f99 Apply fixes from StyleCI (#1381)
[ci skip] [skip ci]
2018-03-04 01:18:49 +01:00
Franz Liedke
33beec3739 Move logic to Extension class
The gathering and execution of extenders can actually be done here
in the `Extension` class. This way, the `ExtensionManager` only
deals with the question of which extensions are enabled, the
`Extension` class actually extends the core application, and the
service provider simply calls a method, without having to know
about internals.
2018-03-04 01:16:50 +01:00
Toby Zerner
407515f5a7 Give Extenders information about which Extension they belong to 2018-03-04 10:13:12 +10:30
Franz Liedke
84be6f3f7f Fix test namespace 2018-03-04 00:04:43 +01:00
Franz Liedke
b75f098de7 Change namespace of test classes
(as implemented by @luceos in his WIP PR)
2018-03-04 00:01:49 +01:00
Daniel Klabbers
2348b8f46f dropped hhvm and gitter webhook 2018-03-03 23:54:37 +01:00
DogSports
63aca851d4 Fix modal title background in media phone 2018-03-02 12:32:07 +01:00
Toby Zerner
98dbe9136c Update core container aliases 2018-02-24 10:37:21 +10:30
AFR
a147fb578a FontAwesome v5.0.6 (#1372)
* Update FontAwesome to v5.0.6

* Adapt DiscussionListItem-count icon to match FontAwesome 5 syntax

* Change icon name to match FontAwesome 5.0.6 fas icon

* Add font type prefix parameter to icon helper

* Add Enable Icon Prefix to show icon in Extension Page

* Fix invalid icon behavior

* Change icon name to match FontAwesome 5.0.6 far icon

* Use iconPrefix property on component

* Use full icon class name

* Update icon helper docblock

* Full icon class syntax
2018-02-23 23:42:00 +01:00
Marcel Pokrandt
f5a4d7b2a3 add message to Dispatch exceptions (#1376)
Exceptions thrown while attempting to dispatch routes are now informing the exact value that was incorrect; url for not found routes and the method when the method was invalid.
2018-02-21 11:28:45 +01:00
Franz Liedke
7bfb220979 Apply fixes from StyleCI (#1371)
[ci skip] [skip ci]
2018-02-15 16:57:18 +01:00
Franz Liedke
a32bddd3e2 Refactor MIME type guessing to work without any PHP extension
Closes #1241.
2018-02-15 16:40:41 +01:00
Toby Zerner
f9963f8268 Merge pull request #1363 from clarkwinkelmann/extension-rollback
Add extension rollback command
2018-02-13 07:18:00 +10:30
Clark Winkelmann
e47fcc8ad6 Rename to reset and make extension an option 2018-02-11 20:03:54 +01:00
Franz Liedke
93822ba4ed API: Provide forum info under /
Closes #875.
2018-02-11 16:40:05 +01:00
Toby Zerner
b8e5dcd587 fire -> dispatch
As per Illuminate\Contracts\Events\Dispatcher
2018-02-10 12:09:35 +10:30
Clark Winkelmann
15114ebd90 Fix formatting 2018-02-09 18:42:43 +01:00
Clark Winkelmann
51adf57f17 Fix formatting 2018-02-09 18:41:51 +01:00
Clark Winkelmann
d47aed59c6 Add extension rollback command 2018-02-09 18:32:44 +01:00
Toby Zerner
c3d034d2fa Merge pull request #1361 from clarkwinkelmann/extendable-notification-methods
Extendable notification methods
2018-02-09 13:51:39 +10:30
Clark Winkelmann
e0b7182908 Fix jsdoc for notification types 2018-02-09 02:53:05 +01:00
Clark Winkelmann
982cbe4b49 Use an extendable ItemList for notification methods 2018-02-09 02:51:42 +01:00
Johann Rodríguez
0fedee8f80 No slug? Then no '-' separator! (#1351)
* Stop using slug separator when there is no slug

* Changing as per upstream requirements
2018-02-09 07:22:50 +10:30
Toby Zerner
6922c3081e Remove excerpt margin on mobile 2018-02-08 07:18:29 +10:30
Toby Zerner
327989d40c Fix CSS rule 2018-02-08 07:08:54 +10:30
Toby Zerner
4ccdd32bb4 Fix regression: set actor before eager loading user state 2018-02-08 07:08:39 +10:30
Toby Zerner
6a53fe35b3 Improve search performance (#1339)
* Improve fulltext gambit

* Only search in visible posts

This change relies on the `visibility-scoping` branch to be merged.

* Change posts table to use InnoDB engine

Doing a JOIN between an InnoDB table (discussions) and a MyISAM table
(posts) is very very (very) bad for performance. FULLTEXT indexes are
fully supported in InnoDB now, and it is a superior engine in every
other way, so there is no longer any reason to be using MyISAM.

* Use ::class

* Only search for comment posts

* Add fulltext index to discussions.title

* Fix migration not working if there is a table prefix

* Update frontend appearance

* Apply fixes from StyleCI

[ci skip] [skip ci]

* Show search result excerpts on mobile
2018-02-08 06:38:08 +10:30
Daniel Klabbers
a816068397 Improved the console configuring event to support any type of console command to be added 2018-02-07 13:58:31 +01:00
Clark Winkelmann
63a9258fe4 Add console configuration event (#1349)
* Add console configuration event

* Fix comment formatting
2018-02-07 21:49:08 +10:30
Daniel Klabbers
bcc239d468 validation requires nullable now in order to allow null values to pass the validation 2018-02-02 11:38:06 +01:00
Toby Zerner
0f49b62bcf Merge pull request #1358 from clarkwinkelmann/avatar-permission
Assert permission when updating avatar
2018-02-01 06:54:47 +10:30
Clark Winkelmann
8835aee224 Assert permission when updating avatar 2018-01-31 16:36:42 +01:00
Toby Zerner
c4b8875be2 Don't break compatibility with extensions that return a function name
eg. s9e/mediaembed
2018-01-31 07:20:49 +10:30
Toby Zerner
4af6acdbda Grant users permission to view empty discussions if they can edit posts
This fixes an issue where unapproved discussions (via
flarum-ext-approval) that were rejected became invisible to the user.

This solution is imperfect and some more substantial thought into how
flarum-ext-approval works is required in the future.
2018-01-30 11:14:25 +10:30