framework/tests
Franz Liedke 3b5691ee28
Restore beta.9 behavior of assertCan()
In flarum/core#1854, I changed the implementation of `assertCan()` to be
more aware of the user's log-in status. I came across this when unifying
our API's response status code when actors are not authenticated or not
authorized to do something.

@luceos rightfully had to tweak this again in ea84fc4, because the
behavior changed for one of the few API endpoints that checked for a
permission that even guests can have.

It turns out having this complex behavior in `assertCan()` is quite
misleading, because the name suggests a simple permission check and
nothing more.

Where we actually want to differ between HTTP 401 and 403, we can do
this using two method calls, and enforce it with our tests.

If this turns out to be problematic or extremely common, we can revisit
this and introduce a method with a different, better name in the future.

This commit restores the method's behavior in the last release, so we
also avoid another breaking change for extensions.
2019-09-14 21:32:00 +02:00
..
integration Restore beta.9 behavior of assertCan() 2019-09-14 21:32:00 +02:00
unit Remove old error handler, middleware and tests 2019-08-10 00:26:24 +02:00
phpunit.integration.xml Update test libraries 2019-07-06 01:49:55 +02:00
phpunit.unit.xml Update test libraries 2019-07-06 01:49:55 +02:00