790d5beee5
This is probably the most complicated way I could find to fix #1587. Jokes aside, this was done with a few goals in mind: - Reduce coupling between the installer and the rest of Flarum's "Application", which we are building during installation. - Move the installer logic to several smaller classes, which can then be used by the web frontend and the console task, instead of the former hacking its way into the latter to be "DRY". - Separate installer infrastructure (the "pipeline", with the ability to revert steps upon failure) from the actual steps being taken. The problem was conceptual, and would certainly re-occur in a similar fashion if we wouldn't tackle it at its roots. It is fixed now, because we no longer use the ExtensionManager for enabling extensions, but instead duplicate some of its logic. That is fine because we don't want to do everything it does, e.g. omit extenders' lifecycle hooks (which depend on the Application instance being complete). > for each desired change, make the change easy (warning: this may be > hard), then make the easy change - Kent Beck, https://twitter.com/kentbeck/status/250733358307500032 Fixes #1587.
About Flarum
Flarum is a delightfully simple discussion platform for your website. It's fast and easy to use, with all the features you need to run a successful community. It is designed to be:
-
Fast and simple. No clutter, no bloat, no complex dependencies. Flarum is built with PHP so it’s quick and easy to deploy. The interface is powered by Mithril, a performant JavaScript framework with a tiny footprint.
-
Beautiful and responsive. This is forum software for humans. Flarum is carefully designed to be consistent and intuitive across platforms, out-of-the-box.
-
Powerful and extensible. Customize, extend, and integrate Flarum to suit your community. Flarum’s architecture is amazingly flexible, with a powerful Extension API.
Installation
This repository contains Flarum's core code. If you want to set up a forum, visit the Flarum skeleton repository.
Contributing
Thank you for considering contributing to Flarum! Please read the Contributing guide to learn how you can help.
Security Vulnerabilities
If you discover a security vulnerability within Flarum, please send an e-mail to security@flarum.org. All security vulnerabilities will be promptly addressed.
License
Flarum is open-source software licensed under the MIT License.