github-mirror/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2024-11-22 11:16:06 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Add null check for responseData.invalidTopics (#32212)
Some checks are pending
release-nightly / nightly-binary (push) Waiting to run
Details
release-nightly / nightly-docker-rootful (push) Waiting to run
Details
release-nightly / nightly-docker-rootless (push) Waiting to run
Details

Browse Source 
<img width="553" alt="Screenshot 2024-10-08 at 10 49 10 AM"
src="https://github.com/user-attachments/assets/faeef64d-684a-4aba-b7fc-c7c6a0301abe">

`responseData.invalidTopics` can be null but it wasn't handled.
This commit is contained in:
cloudchamb3r 2024-10-09 02:27:05 +09:00 committed by GitHub
parent d6d3c96e65
commit 2e12343fc4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
web_src/js/features/repo-home.ts
View File

@ -60,7 +60,7 @@ export function initRepoTopicBar() {
// how to test: input topic like " invalid topic " (with spaces), and select it from the list, then "Save" // how to test: input topic like " invalid topic " (with spaces), and select it from the list, then "Save"
const responseData = await response.json(); const responseData = await response.json();
lastErrorToast = showErrorToast(responseData.message, {duration: 5000}); lastErrorToast = showErrorToast(responseData.message, {duration: 5000});
if (responseData.invalidTopics.length > 0) { if (responseData.invalidTopics && responseData.invalidTopics.length > 0) {
const {invalidTopics} = responseData; const {invalidTopics} = responseData;
const topicLabels = queryElemChildren(topicDropdown, 'a.ui.label'); const topicLabels = queryElemChildren(topicDropdown, 'a.ui.label');
for (const [index, value] of topics.split(',').entries()) { for (const [index, value] of topics.split(',').entries()) {