Fix checkbox bug on private/archive filter (#32236)
Some checks are pending
release-nightly / nightly-binary (push) Waiting to run
release-nightly / nightly-docker-rootful (push) Waiting to run
release-nightly / nightly-docker-rootless (push) Waiting to run

fix #32235

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
This commit is contained in:
cloudchamb3r 2024-10-11 02:12:27 +09:00 committed by GitHub
parent 6029d78ab5
commit cb739f5333
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -362,9 +362,9 @@ export default sfc; // activate the IDE's Vue plugin
<div class="menu"> <div class="menu">
<a class="item" @click="toggleArchivedFilter()"> <a class="item" @click="toggleArchivedFilter()">
<div class="ui checkbox" ref="checkboxArchivedFilter" :title="checkboxArchivedFilterTitle"> <div class="ui checkbox" ref="checkboxArchivedFilter" :title="checkboxArchivedFilterTitle">
<!--the "hidden" is necessary to make the checkbox work without Fomantic UI js, <!--the "tw-pointer-events-none" is necessary to prevent the checkbox from handling user's input,
otherwise if the "input" handles click event for intermediate status, it breaks the internal state--> otherwise if the "input" handles click event for intermediate status, it breaks the internal state-->
<input type="checkbox" class="hidden" v-bind.prop="checkboxArchivedFilterProps"> <input type="checkbox" class="tw-pointer-events-none" v-bind.prop="checkboxArchivedFilterProps">
<label> <label>
<svg-icon name="octicon-archive" :size="16" class-name="tw-mr-1"/> <svg-icon name="octicon-archive" :size="16" class-name="tw-mr-1"/>
{{ textShowArchived }} {{ textShowArchived }}
@ -373,7 +373,7 @@ export default sfc; // activate the IDE's Vue plugin
</a> </a>
<a class="item" @click="togglePrivateFilter()"> <a class="item" @click="togglePrivateFilter()">
<div class="ui checkbox" ref="checkboxPrivateFilter" :title="checkboxPrivateFilterTitle"> <div class="ui checkbox" ref="checkboxPrivateFilter" :title="checkboxPrivateFilterTitle">
<input type="checkbox" class="hidden" v-bind.prop="checkboxPrivateFilterProps"> <input type="checkbox" class="tw-pointer-events-none" v-bind.prop="checkboxPrivateFilterProps">
<label> <label>
<svg-icon name="octicon-lock" :size="16" class-name="tw-mr-1"/> <svg-icon name="octicon-lock" :size="16" class-name="tw-mr-1"/>
{{ textShowPrivate }} {{ textShowPrivate }}