gitea

github-mirror/gitea

Fork 0

mirror of https://github.com/go-gitea/gitea.git synced 2024-12-01 05:54:09 +08:00

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
박상철	620f19610e	Prevent from submitting issue/comment on uploading (#32263 ) fix #32262 --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>	2024-10-23 10:48:04 +08:00
cloudchamb3r	603fca1e27	Fix null errors on conversation holder (#32258 ) (#32266 ) Some checks are pending release-nightly / nightly-binary (push) Waiting to run Details release-nightly / nightly-docker-rootful (push) Waiting to run Details release-nightly / nightly-docker-rootless (push) Waiting to run Details fix #32258 Errors in the issue was due to unhandled null check. so i fixed it. ### Detailed description for Issue & Fix To reproduce that issue, the comment must be deleted on Conversation tab. #### Before Delete <img width="1032" alt="image" src="https://github.com/user-attachments/assets/72df61ba-7db6-44c9-bebc-ca1178dd27f1"> #### After Delete (AS-IS) <img width="1010" alt="image" src="https://github.com/user-attachments/assets/36fa537e-4f8e-4535-8d02-e538c50f0dd8"> gitea already have remove logic for `timeline-item-group`, but because of null ref exception the later logic that removes `timeline-item-group` could be not be called correctly.	2024-10-16 20:39:47 +08:00
silverwind	5791a73e75	Convert frontend code to typescript (#31559 ) None of the frontend js/ts files was touched besides these two commands (edit: no longer true, I touched one file in `61105d0618` because of a deprecation that was not showing before the rename). `tsc` currently reports 778 errors, so I have disabled it in CI as planned. Everything appears to work fine.	2024-07-07 15:32:30 +00:00

박상철

620f19610e

Prevent from submitting issue/comment on uploading (#32263 )

fix #32262

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Giteabot <teabot@gitea.io>

2024-10-23 10:48:04 +08:00

cloudchamb3r

603fca1e27

Fix null errors on conversation holder (#32258 ) (#32266 )

release-nightly / nightly-binary (push) Waiting to run

Details

release-nightly / nightly-docker-rootful (push) Waiting to run

Details

release-nightly / nightly-docker-rootless (push) Waiting to run

Details

fix #32258

Errors in the issue was due to unhandled null check. so i fixed it.

### Detailed description for Issue & Fix
To reproduce that issue, the comment must be deleted on Conversation
tab.
#### Before Delete
<img width="1032" alt="image"
src="https://github.com/user-attachments/assets/72df61ba-7db6-44c9-bebc-ca1178dd27f1">

#### After Delete (AS-IS)
<img width="1010" alt="image"
src="https://github.com/user-attachments/assets/36fa537e-4f8e-4535-8d02-e538c50f0dd8">

gitea already have remove logic for `timeline-item-group`, but because
of null ref exception the later logic that removes `timeline-item-group`
could be not be called correctly.

2024-10-16 20:39:47 +08:00

silverwind

5791a73e75

Convert frontend code to typescript (#31559 )

None of the frontend js/ts files was touched besides these two commands
(edit: no longer true, I touched one file in
61105d0618
because of a deprecation that was not showing before the rename).

`tsc` currently reports 778 errors, so I have disabled it in CI as
planned.

Everything appears to work fine.

2024-07-07 15:32:30 +00:00

3 Commits