4684 Commits

Author	SHA1	Message	Date
wxiaoguang	a928739456	Refactor sidebar assignee&milestone&project selectors (#32465) ... Follow #32460 Now the code could be much clearer than before and easier to maintain. A lot of legacy code is removed. Manually tested. This PR is large enough, that fine tunes could be deferred to the future if there is no bug found or design problem. Screenshots: <details>  </details>	2024-11-11 04:07:54 +08:00
wxiaoguang	58c634b854	Refactor sidebar label selector (#32460) ... Introduce `issueSidebarLabelsData` to handle all sidebar labels related data.	2024-11-10 08:26:42 +00:00
Calvin K	18aeca5320	Add reviewers selection to new pull request (#32403) ... Users could add reviewers when creating new PRs. --------- Co-authored-by: splitt3r <splitt3r@users.noreply.github.com> Co-authored-by: Sebastian Sauer <sauer.sebastian@gmail.com> Co-authored-by: bb-ben <70356237+bboerben@users.noreply.github.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2024-11-09 04:48:31 +00:00
wxiaoguang	623a2d41cc	Refactor issue page info (#32445) ... Fix a longstanding TODO since 2021 (#14826) / 2018 (#2531)	2024-11-08 02:21:13 +00:00
wxiaoguang	145e266987	Support quote selected comments to reply (#32431) ... Many existing tests were quite hacky, these could be improved later. <details>  </details>	2024-11-07 03:57:07 +00:00
Lunny Xiao	276500c314	Move AddCollabrator and CreateRepositoryByExample to service layer (#32419) ... - [x] Move `CreateRepositoryByExample` to service layer - [x] Move `AddCollabrator` to service layer - [x] Add a new parameter for `AddCollabrator` so that changing mode immediately after that will become unnecessary.	2024-11-07 11:28:11 +08:00
Kemal Zebari	7adc4717ec	Include file extension checks in attachment API (#32151) ... From testing, I found that issue posters and users with repository write access are able to edit attachment names in a way that circumvents the instance-level file extension restrictions using the edit attachment APIs. This snapshot adds checks for these endpoints.	2024-11-06 21:34:32 +00:00
Lunny Xiao	24b83ff63e	Fix milestone deadline and date related problems (#32339) ... Use zero instead of 9999-12-31 for deadline Fix #32291 --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>	2024-11-05 07:46:40 +00:00
wxiaoguang	61c35590c7	Refactor RepoRefByType (#32413) ... 1. clarify the "filepath" could(should) contain "{ref}" 2. remove unclear RepoRefLegacy and RepoRefAny, use RepoRefUnknown to guess 3. by the way, avoid using AppURL	2024-11-05 06:35:54 +00:00
wxiaoguang	4a469c8e1b	Refactor template ctx and render utils (#32422) ... Clean up the templates	2024-11-05 14:04:26 +08:00
wxiaoguang	b068dbd40e	Refactor DateUtils and merge TimeSince (#32409) ... Follow #32383 and #32402	2024-11-04 11:30:00 +00:00
wxiaoguang	e524f63d58	Fix git error handling (#32401)	2024-11-02 11:20:22 +00:00
wxiaoguang	fec6b3d500	Replace DateTime with DateUtils (#32383)	2024-11-02 04:08:28 +00:00
Rowan Bohde	7dcccc3bb1	improve performance of diffs (#32393) ... This has two major changes that significantly reduce the amount of work done for large diffs: * Kill a running git process when reaching the maximum number of files in a diff, preventing it from processing the entire diff. * When loading a diff with the URL param `file-only=true`, skip loading stats. This speeds up loading both hidden files of a diff and sections of a diff when clicking the "Show More" button. A couple of minor things from profiling are also included: * Reuse existing repo in `PrepareViewPullInfo` if head and base are the same. The performance impact is going to depend heavily on the individual diff and the hardware it runs on, but when testing locally on a diff changing 100k+ lines over hundreds of files, I'm seeing a roughly 75% reduction in time to load the result of "Show More" --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2024-11-02 11:29:37 +08:00
Zettat123	0690cb076b	Fix missing signature key error when pulling Docker images with SERVE_DIRECT enabled (#32365) ... Fix #28121 I did some tests and found that the `missing signature key` error is caused by an incorrect `Content-Type` header. Gitea correctly sets the `Content-Type` header when serving files. 348d1d0f32/routers/api/packages/container/container.go (L712-L717) However, when `SERVE_DIRECT` is enabled, the `Content-Type` header may be set to an incorrect value by the storage service. To fix this issue, we can use query parameters to override response header values. https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetObject.html <img width="600px" src="https://github.com/user-attachments/assets/f2ff90f0-f1df-46f9-9680-b8120222c555" /> In this PR, I introduced a new parameter to the `URL` method to support additional parameters. ``` URL(path, name string, reqParams url.Values) (*url.URL, error) ``` --- Most S3-like services support specifying the content type when storing objects. However, Gitea always use `application/octet-stream`. Therefore, I believe we also need to improve the `Save` method to support storing objects with the correct content type. b7fb20e73e/modules/storage/minio.go (L214-L221)	2024-10-31 15:28:25 +00:00
wxiaoguang	a4a121c684	Fix suggestions for issues (#32380)	2024-10-30 20:06:36 +00:00
Oleksandr Redko	f4d3aaeeb9	refactor: remove redundant err declarations (#32381)	2024-10-30 19:36:24 +00:00
6543	58eb16eda7	Respect UI.ExploreDefaultSort setting again (#32357) ... fix regression of https://github.com/go-gitea/gitea/pull/29430 --- *Sponsored by Kithara Software GmbH*	2024-10-30 12:33:25 +00:00
Anbraten	b7fb20e73e	Suggestions for issues (#32327) ... closes #16872	2024-10-29 17:20:49 +08:00
wxiaoguang	d70af38447	Refactor the DB migration system slightly (#32344) ... Introduce "idNumber" for each migration, and clarify the difference between the migration ID number and database version.	2024-10-27 19:54:35 +08:00
Lunny Xiao	2abdbe88b5	Fix disable 2fa bug (#32320)	2024-10-23 06:41:00 +00:00
Tim	de2ad2e1b1	Make admins adhere to branch protection rules (#32248) ... This introduces a new flag `BlockAdminMergeOverride` on the branch protection rules that prevents admins/repo owners from bypassing branch protection rules and merging without approvals or failing status checks. Fixes #17131 --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>	2024-10-23 12:39:43 +08:00
Zettat123	9206fbb55f	Add DISABLE_ORGANIZATIONS_PAGE and DISABLE_CODE_PAGE settings for explore pages and fix an issue related to user search (#32288) ... These settings can allow users to only display the repositories explore page. Thanks to yp05327 and wxiaoguang ! --------- Co-authored-by: Giteabot <teabot@gitea.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2024-10-22 13:09:19 +08:00
6543	d638067d3c	API: enhance SearchIssues swagger docs (#32208) ... this will result in better api clients generated out of the openapi docs ... for SearchIssues --- *Sponsored by Kithara Software GmbH*	2024-10-19 20:11:56 +00:00
wxiaoguang	5242e520c4	Make owner/repo/pulls handlers use "PR reader" permission (#32254) ... Fix #32253 (partially)	2024-10-15 06:47:07 +00:00
wxiaoguang	afa8dd45af	Make git push options accept short name (#32245) ... Just like what most CLI parsers do: `--opt` means `opt=true` Then users could use `-o force-push` as `-o force-push=true`	2024-10-12 05:42:10 +00:00
Zettat123	0fe5e2b08c	Allow maintainers to view and edit files of private repos when "Allow maintainers to edit" is enabled (#32215) ... Fix #31539	2024-10-11 19:08:19 +00:00
Lunny Xiao	aebb741c08	Use per package global lock for container uploads instead of memory lock (#31860) ... This PR uses a per-package lock instead of a global lock for container uploads. So that different packages can be uploaded simultaneously.	2024-10-11 07:37:49 +00:00
Lunny Xiao	c2217670dd	Move admin routers from /admin to /-/admin (#32189) ... Resolve #32181 --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2024-10-10 04:56:49 +00:00
wxiaoguang	dd83cfcacc	Refactor CSRF token (#32216)	2024-10-10 03:48:21 +00:00
Zettat123	4eacc61f64	Fix incorrect "Target branch does not exist" in PR title (#32222)	2024-10-10 08:25:46 +08:00
Lunny Xiao	d6d3c96e65	Fix bug when a token is given public only (#32204)	2024-10-08 12:51:09 +03:00
6543	bdd655f2bd	Allow filtering PRs by poster in the ListPullRequests API (#32209) ... as title --- *Sponsored by Kithara Software GmbH*	2024-10-07 23:21:07 +02:00
Zisu Zhang	66923e02d2	Enhance USER_DISABLED_FEATURES to allow disabling change username or full name (#31959) ... Fix #31958 Enhanced `USER_DISABLED_FEATURES`(also `EXTERNAL_USER_DISABLE_FEATURES`) option in `[admin]` section. Added following values: - `change_username`: Disable change username - `change_full_name`: Disable change full name --- Progress: - [x] Update code - [x] Update translations	2024-10-05 20:41:38 +00:00
yp05327	5d6d025c9b	Add support for searching users by email (#30908) ... Fix #30898 we have an option `SearchByEmail`, so enable it, then we can search user by email. Also added a test for it.	2024-10-04 17:45:06 +00:00
Job	7e68bc8823	Fix PR creation on forked repositories (#31863) ... Resolves #20475	2024-10-04 13:12:48 -04:00
Lunny Xiao	a989404e23	Fix javascript error when an anonymous user visiting migration page (#32144) ... This PR fixes javascript errors when an anonymous user visits the migration page. It also makes task view checking more restrictive. The router moved from `/user/task/{id}/status` to `/username/reponame/-/migrate/status` because it's a migrate status. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2024-10-02 04:37:16 +00:00
Lunny Xiao	3a4a1bffbe	Make oauth2 code clear. Move oauth2 provider code to their own packages/files (#32148) ... Fix #30266 Replace #31533	2024-10-02 08:03:19 +08:00
yp05327	70b7df0e5e	Support repo license (#24872) ... Close #278 Close #24076 ## Solutions: - Use [google/licenseclassifier](https://github.com/google/licenseclassifier/) Test result between [google/licensecheck](https://github.com/google/licensecheck) and [go-license-detector](https://github.com/go-enry/go-license-detector): https://github.com/go-gitea/gitea/pull/24872#issuecomment-1560361167 Test result between [google/licensecheck](https://github.com/google/licensecheck) and [google/licenseclassifier](https://github.com/google/licenseclassifier/): https://github.com/go-gitea/gitea/pull/24872#issuecomment-1576092178 - Generate License Convert Name List to avoid import license templates with same contents Gitea automatically get latest license data from[ spdx/license-list-data](https://github.com/spdx/license-list-data). But unfortunately, some license templates have same contents. #20915 [click here to see the list](https://github.com/go-gitea/gitea/pull/24872#issuecomment-1584141684) So we will generate a list of these license templates with same contents and create a new file to save the result when using `make generate-license`. (Need to decide the save path) - Save License info into a new table `repo_license` Can easily support searching repo by license in the future. ## Screen shot Single License:  Multiple Licenses:  Triggers: - [x] Push commit to default branch - [x] Create repo - [x] Mirror repo - [x] When Default Branch is changed, licenses should be updated Todo: - [x] Save Licenses info in to DB when there's a change to license file in the commit - [x] DB Migration - [x] A nominal test? - [x] Select which library to use(https://github.com/go-gitea/gitea/pull/24872#issuecomment-1560361167) - [x] API Support - [x] Add repo license table - ~Select license in settings if there are several licenses(Not recommended)~ - License board(later, not in this PR)  --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Denys Konovalov <kontakt@denyskon.de> Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: KN4CK3R <admin@oldschoolhack.me> Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: 6543 <m.huber@kithara.com> Co-authored-by: a1012112796 <1012112796@qq.com> Co-authored-by: techknowlogick <techknowlogick@gitea.com>	2024-10-01 15:25:08 -04:00
Zettat123	f4b8f6fc40	Fix the logic of finding the latest pull review commit ID (#32139) ... Fix #31423	2024-10-01 01:58:55 +00:00
ConcurrentCrab	8a9fd7f771	Add pure SSH LFS support (#31516) ... Fixes #17554 /claim #17554 Docs PR https://gitea.com/gitea/docs/pulls/49 To test, run pushes like: `GIT_TRACE=1` git push. The trace output should mention "pure SSH connection".	2024-09-27 10:27:37 -04:00
charles	3269b04d61	Notify the user when the file path contains leading or trailing spaces and fix the error message for invalid file names. (#31507) ... close #31478	2024-09-24 19:06:52 +00:00
Lunny Xiao	e2f365b55c	Display head branch more comfortable on pull request view (#32000) ... This PR do some minor improvements for head branch display on pull request view UI. - [x] Remove the link if the head branch has been deleted with a tooltip, so that users will not result in a 404 page - [x] Display a label if this pull request is an agit based one. 	2024-09-24 04:14:57 +00:00
Lunny Xiao	6eb5950835	Allow set branch protection in an empty repository (#32095)	2024-09-24 02:06:28 +00:00
Zettat123	fcedf634d5	Fix bug in getting merged pull request by commit (#32079)	2024-09-24 01:00:09 +00:00
cloudchamb3r	e1f0598c8f	Fix Bug in Issue/pulls list (#32081) ... fix #32080 ## After ### for opened issues <img width="1199" alt="Screenshot 2024-09-19 at 6 29 31 PM" src="https://github.com/user-attachments/assets/86cf48ad-5e4b-4dcb-8abe-4d7fd74e0aec"> ### for closed issues <img width="1208" alt="Screenshot 2024-09-19 at 6 29 37 PM" src="https://github.com/user-attachments/assets/a16bc545-bfcf-49a4-be52-3e7334910482"> ### for all issues <img width="1340" alt="Screenshot 2024-09-20 at 12 07 12 PM" src="https://github.com/user-attachments/assets/b2309c8f-e59d-44e9-ae3b-bf54e1196169">	2024-09-24 01:09:57 +08:00
Lunny Xiao	9e0db1b646	Fix rename branch permission bug (#32066) ... The previous implementation requires admin permission to rename branches which should be write permission. Fix #31993	2024-09-22 18:08:27 +00:00
ChristopherHX	b594cec2bd	Fix artifact v4 upload above 8MB (#31664) ... Multiple chunks are uploaded with type "block" without using "appendBlock" and eventually out of order for bigger uploads. 8MB seems to be the chunk size This change parses the blockList uploaded after all blocks to get the final artifact size and order them correctly before calculating the sha256 checksum over all blocks Fixes #31354	2024-09-22 14:01:09 +03:00
Lunny Xiao	a802508f88	Fix wrong last modify time (#32102)	2024-09-21 21:56:25 +00:00
Lunny Xiao	5de41737a5	Fix upload maven pacakge parallelly (#31851) ... Use globallock for maven package uploads. Thanks @tlusser for the test code. Depends on ~#31813~	2024-09-21 19:26:45 +00:00