4904 Commits

Author	SHA1	Message	Date
wxiaoguang	5eebe1dc5f	Fix and refactor markdown rendering (#32522)	2024-11-16 08:41:44 +00:00
charles	e546480d0a	Fix large image overflow in comment page (#31740) ... Close #31709 52px is calculate by avatar size in templates\repo\issue\view_content\comments.tmpl ```html <img src="{{.Poster.AvatarLink $.Context}}" width="40" height="40"> ``` + ```css .ui.comments .comment > .avatar ~ .content { margin-left: 12px; } ```  --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2024-11-15 18:34:54 +00:00
wxiaoguang	21f7db2124	Fix incorrect project page CSS class (#32510) ... Otherwise milestone JS would run on this page and cause errors	2024-11-15 01:30:26 +00:00
wxiaoguang	3f9c3e7bc3	Refactor render system (#32492) ... There were too many patches to the Render system, it's really difficult to make further improvements. This PR clears the legacy problems and fix TODOs. 1. Rename `RenderContext.Type` to `RenderContext.MarkupType` to clarify its usage. 2. Use `ContentMode` to replace `meta["mode"]` and `IsWiki`, to clarify the rendering behaviors. 3. Use "wiki" mode instead of "mode=gfm + wiki=true" 4. Merge `renderByType` and `renderByFile` 5. Add more comments ---- The problem of "mode=document": in many cases it is not set, so many non-comment places use comment's hard line break incorrectly	2024-11-14 05:02:11 +00:00
wxiaoguang	a928739456	Refactor sidebar assignee&milestone&project selectors (#32465) ... Follow #32460 Now the code could be much clearer than before and easier to maintain. A lot of legacy code is removed. Manually tested. This PR is large enough, that fine tunes could be deferred to the future if there is no bug found or design problem. Screenshots: <details>  </details>	2024-11-11 04:07:54 +08:00
wxiaoguang	58c634b854	Refactor sidebar label selector (#32460) ... Introduce `issueSidebarLabelsData` to handle all sidebar labels related data.	2024-11-10 08:26:42 +00:00
Calvin K	18aeca5320	Add reviewers selection to new pull request (#32403) ... Users could add reviewers when creating new PRs. --------- Co-authored-by: splitt3r <splitt3r@users.noreply.github.com> Co-authored-by: Sebastian Sauer <sauer.sebastian@gmail.com> Co-authored-by: bb-ben <70356237+bboerben@users.noreply.github.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2024-11-09 04:48:31 +00:00
wxiaoguang	d80f99ef04	Fix issue sidebar (#32455) ... Fix #32453 Major changes: * revert the `<div class="divider"></div>` in `templates/repo/issue/branch_selector_field.tmpl` (it was removed by mistake in ##32444) * remove incorrect `<div class="inline field">` in `templates/repo/issue/sidebar/allow_maintainer_edit.tmpl` * use `gt-ellipsis` to replace the "title" class in the dependency list, then `.repository .issue-content-right .ui.list .title` could be removed * remove the "relaxed" from dependency list, then there is no padding, then `.repository .issue-content-right .ui.list .dependency` could be removed (`white-space` doesn't have effect either because there is `gt-ellipsis`) * remove dead code `.repository .issue-content-right #deadlineForm input ` The fixed UI should be the same as before.	2024-11-09 01:55:32 +08:00
wxiaoguang	0f397ae09b	Refactor language menu and dom utils (#32450) ... 1. Make `queryElem*` functions could correctly handle TS types 2. Remove some legacy jQuery $ calls (introduce fomanticQuery for Fomantic UI only) 3. Fix some TS typing problems	2024-11-08 14:04:24 +08:00
wxiaoguang	623a2d41cc	Refactor issue page info (#32445) ... Fix a longstanding TODO since 2021 (#14826) / 2018 (#2531)	2024-11-08 02:21:13 +00:00
wxiaoguang	028e612094	Split issue sidebar into small templates (#32444) ... Only move code	2024-11-08 01:44:20 +00:00
wxiaoguang	145e266987	Support quote selected comments to reply (#32431) ... Many existing tests were quite hacky, these could be improved later. <details>  </details>	2024-11-07 03:57:07 +00:00
Lunny Xiao	276500c314	Move AddCollabrator and CreateRepositoryByExample to service layer (#32419) ... - [x] Move `CreateRepositoryByExample` to service layer - [x] Move `AddCollabrator` to service layer - [x] Add a new parameter for `AddCollabrator` so that changing mode immediately after that will become unnecessary.	2024-11-07 11:28:11 +08:00
Kemal Zebari	7adc4717ec	Include file extension checks in attachment API (#32151) ... From testing, I found that issue posters and users with repository write access are able to edit attachment names in a way that circumvents the instance-level file extension restrictions using the edit attachment APIs. This snapshot adds checks for these endpoints.	2024-11-06 21:34:32 +00:00
Lunny Xiao	24b83ff63e	Fix milestone deadline and date related problems (#32339) ... Use zero instead of 9999-12-31 for deadline Fix #32291 --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>	2024-11-05 07:46:40 +00:00
wxiaoguang	61c35590c7	Refactor RepoRefByType (#32413) ... 1. clarify the "filepath" could(should) contain "{ref}" 2. remove unclear RepoRefLegacy and RepoRefAny, use RepoRefUnknown to guess 3. by the way, avoid using AppURL	2024-11-05 06:35:54 +00:00
wxiaoguang	4a469c8e1b	Refactor template ctx and render utils (#32422) ... Clean up the templates	2024-11-05 14:04:26 +08:00
wxiaoguang	b068dbd40e	Refactor DateUtils and merge TimeSince (#32409) ... Follow #32383 and #32402	2024-11-04 11:30:00 +00:00
wxiaoguang	af28ce59b8	Add some handy markdown editor features (#32400) ... There were some missing features from EasyMDE: 1. H1 - H3 style 2. Auto add task list 3. Insert a table And added some tests	2024-11-04 10:14:36 +00:00
wxiaoguang	259811617b	Replace DateTime with proper functions (#32402) ... Follow #32383 This PR cleans up the "Deadline" usages in templates, make them call `ParseLegacy` first to get a `Time` struct then display by `DateUtils`. Now it should be pretty clear how "deadline string" works, it makes it possible to do further refactoring and correcting.	2024-11-02 21:04:53 +00:00
wxiaoguang	fec6b3d500	Replace DateTime with DateUtils (#32383)	2024-11-02 04:08:28 +00:00
yp05327	dd1f67491f	Fix the missing menu in organization project view page (#32313) ... #29248 didn't modify the view page. The class name is not good enough, so this is a quick fix. Before: org:  user:  After: org:  user: (no change)  Co-authored-by: Giteabot <teabot@gitea.io>	2024-10-30 19:05:40 +00:00
Rowan Bohde	1cd3f69859	remove unused call to $.HeadRepo in view_title template (#32317) ... This is only populated in [`ParseCompareInfo`](https://github.com/search?q=repo%3Ago-gitea%2Fgitea%20%20.Data%5B%22HeadRepo%22%5D&type=code) which is called in two handlers: * [`CompareAndPullRequestPost`](9206fbb55f/routers/web/repo/pull.go (L1246)) - a JSON post handler that doesn't render templates * [`CompareDiff`](9206fbb55f/routers/web/repo/compare.go (L706)) - which can render `diff/box.tmpl` and `diff/compare.tmpl`	2024-10-30 13:12:48 +08:00
Anbraten	b7fb20e73e	Suggestions for issues (#32327) ... closes #16872	2024-10-29 17:20:49 +08:00
Tim	de2ad2e1b1	Make admins adhere to branch protection rules (#32248) ... This introduces a new flag `BlockAdminMergeOverride` on the branch protection rules that prevents admins/repo owners from bypassing branch protection rules and merging without approvals or failing status checks. Fixes #17131 --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>	2024-10-23 12:39:43 +08:00
Zettat123	9206fbb55f	Add DISABLE_ORGANIZATIONS_PAGE and DISABLE_CODE_PAGE settings for explore pages and fix an issue related to user search (#32288) ... These settings can allow users to only display the repositories explore page. Thanks to yp05327 and wxiaoguang ! --------- Co-authored-by: Giteabot <teabot@gitea.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2024-10-22 13:09:19 +08:00
6543	d638067d3c	API: enhance SearchIssues swagger docs (#32208) ... this will result in better api clients generated out of the openapi docs ... for SearchIssues --- *Sponsored by Kithara Software GmbH*	2024-10-19 20:11:56 +00:00
charles	6fced33581	Fix dropdown content overflow (#31610) ... close #31602  --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2024-10-13 02:43:43 +00:00
Lunny Xiao	c2217670dd	Move admin routers from /admin to /-/admin (#32189) ... Resolve #32181 --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2024-10-10 04:56:49 +00:00
Ehsan Shirvanian	8bee7fcf7e	update git book link to v2 (#32221) ... Fix the dead link `https://git-scm.com/book/en/Git-Basics-Getting-a-Git-Repository` for empty repositories to help how to clone the repository to `https://git-scm.com/book/en/v2/Git-Basics-Getting-a-Git-Repository` which is v2 of the git book. This also updates download git links	2024-10-09 13:04:34 +08:00
6543	bdd655f2bd	Allow filtering PRs by poster in the ListPullRequests API (#32209) ... as title --- *Sponsored by Kithara Software GmbH*	2024-10-07 23:21:07 +02:00
Zisu Zhang	66923e02d2	Enhance USER_DISABLED_FEATURES to allow disabling change username or full name (#31959) ... Fix #31958 Enhanced `USER_DISABLED_FEATURES`(also `EXTERNAL_USER_DISABLE_FEATURES`) option in `[admin]` section. Added following values: - `change_username`: Disable change username - `change_full_name`: Disable change full name --- Progress: - [x] Update code - [x] Update translations	2024-10-05 20:41:38 +00:00
Lunny Xiao	a989404e23	Fix javascript error when an anonymous user visiting migration page (#32144) ... This PR fixes javascript errors when an anonymous user visits the migration page. It also makes task view checking more restrictive. The router moved from `/user/task/{id}/status` to `/username/reponame/-/migrate/status` because it's a migrate status. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2024-10-02 04:37:16 +00:00
yp05327	70b7df0e5e	Support repo license (#24872) ... Close #278 Close #24076 ## Solutions: - Use [google/licenseclassifier](https://github.com/google/licenseclassifier/) Test result between [google/licensecheck](https://github.com/google/licensecheck) and [go-license-detector](https://github.com/go-enry/go-license-detector): https://github.com/go-gitea/gitea/pull/24872#issuecomment-1560361167 Test result between [google/licensecheck](https://github.com/google/licensecheck) and [google/licenseclassifier](https://github.com/google/licenseclassifier/): https://github.com/go-gitea/gitea/pull/24872#issuecomment-1576092178 - Generate License Convert Name List to avoid import license templates with same contents Gitea automatically get latest license data from[ spdx/license-list-data](https://github.com/spdx/license-list-data). But unfortunately, some license templates have same contents. #20915 [click here to see the list](https://github.com/go-gitea/gitea/pull/24872#issuecomment-1584141684) So we will generate a list of these license templates with same contents and create a new file to save the result when using `make generate-license`. (Need to decide the save path) - Save License info into a new table `repo_license` Can easily support searching repo by license in the future. ## Screen shot Single License:  Multiple Licenses:  Triggers: - [x] Push commit to default branch - [x] Create repo - [x] Mirror repo - [x] When Default Branch is changed, licenses should be updated Todo: - [x] Save Licenses info in to DB when there's a change to license file in the commit - [x] DB Migration - [x] A nominal test? - [x] Select which library to use(https://github.com/go-gitea/gitea/pull/24872#issuecomment-1560361167) - [x] API Support - [x] Add repo license table - ~Select license in settings if there are several licenses(Not recommended)~ - License board(later, not in this PR)  --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Denys Konovalov <kontakt@denyskon.de> Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: KN4CK3R <admin@oldschoolhack.me> Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: 6543 <m.huber@kithara.com> Co-authored-by: a1012112796 <1012112796@qq.com> Co-authored-by: techknowlogick <techknowlogick@gitea.com>	2024-10-01 15:25:08 -04:00
Lunny Xiao	e2f365b55c	Display head branch more comfortable on pull request view (#32000) ... This PR do some minor improvements for head branch display on pull request view UI. - [x] Remove the link if the head branch has been deleted with a tooltip, so that users will not result in a 404 page - [x] Display a label if this pull request is an agit based one. 	2024-09-24 04:14:57 +00:00
Lunny Xiao	2c6fa6c1e0	Fix template bug of pull request view (#32072) ... Caused by #31924	2024-09-24 03:02:42 +00:00
Lunny Xiao	6eb5950835	Allow set branch protection in an empty repository (#32095)	2024-09-24 02:06:28 +00:00
Zettat123	fcedf634d5	Fix bug in getting merged pull request by commit (#32079)	2024-09-24 01:00:09 +00:00
cloudchamb3r	e1f0598c8f	Fix Bug in Issue/pulls list (#32081) ... fix #32080 ## After ### for opened issues <img width="1199" alt="Screenshot 2024-09-19 at 6 29 31 PM" src="https://github.com/user-attachments/assets/86cf48ad-5e4b-4dcb-8abe-4d7fd74e0aec"> ### for closed issues <img width="1208" alt="Screenshot 2024-09-19 at 6 29 37 PM" src="https://github.com/user-attachments/assets/a16bc545-bfcf-49a4-be52-3e7334910482"> ### for all issues <img width="1340" alt="Screenshot 2024-09-20 at 12 07 12 PM" src="https://github.com/user-attachments/assets/b2309c8f-e59d-44e9-ae3b-bf54e1196169">	2024-09-24 01:09:57 +08:00
Lunny Xiao	9e0db1b646	Fix rename branch permission bug (#32066) ... The previous implementation requires admin permission to rename branches which should be write permission. Fix #31993	2024-09-22 18:08:27 +00:00
silverwind	aa9faf8250	Set manual tabindexes on login page (#31689) ... Fixes https://github.com/go-gitea/gitea/issues/31686. A more elborate manual tabindex numbering could be done, but I think it's not really worth the extra effort and such stuff could easily break during refactors. Includes another small tweak to un-stretch the`<a>` element so it's only as large as it needs to be and this change also made the margin unneeded.	2024-09-20 15:27:19 +00:00
Bruno Sofiato	7dde3e6489	Included tag search capabilities (#32045) ... Resolves #31998 The first screenshot shows the tag page without any filter being applied:  The second one, shows the page when the given filter returns no tag:  The last one shows a single tag being filtered:  Signed-off-by: Bruno Sofiato <bruno.sofiato@gmail.com>	2024-09-18 02:33:11 +08:00
Lauris BH	4ab6fc62d2	Add option to filter board cards by labels and assignees (#31999) ... Works in both organization and repository project boards Fixes #21846 Replaces #21963 Replaces #27117  **Note** that implementation was made intentionally to work same as in issue list so that URL can be bookmarked for quick access with predefined filters in URL	2024-09-12 03:53:40 +00:00
Zettat123	def1c9670b	Support migration from AWS CodeCommit (#31981) ... This PR adds support for migrating repos from [AWS CodeCommit](https://docs.aws.amazon.com/codecommit/latest/userguide/welcome.html). The access key ID and secret access key are required to get repository information and pull requests. And [HTTPS Git credentials](https://docs.aws.amazon.com/codecommit/latest/userguide/setting-up-gc.html) are required to clone the repository. <img src="https://github.com/user-attachments/assets/82ecb2d0-8d43-42b0-b5af-f5347a13b9d0" width="680" /> The AWS CodeCommit icon is from [AWS Architecture Icons](https://aws.amazon.com/architecture/icons/). <img src="https://github.com/user-attachments/assets/3c44d21f-d753-40f5-9eae-5d3589e0d50d" width="320" />	2024-09-11 07:49:42 +08:00
Lunny Xiao	a5818470fe	Use forum.gitea.com instead of old URL (#31989)	2024-09-06 07:20:30 +00:00
william-allspice	e9c64f41a6	Distinguish official vs non-official reviews, add tool tips, and upgr… (#31924) ... This Pull Request is a follow up to https://github.com/go-gitea/gitea/pull/31886: 1. Adds a UI indicator between official (green) and unofficial (grey) approved pull requests on the Pull Request page (as suggested by @kdumontnu ) 2. Adds tooltips adding clarity to the type and status of a review on the Pull Request page (as suggested by @kdumontnu) 3. Updates text adding more clarity to required approvals (as suggested by @kdumontnu) 4. Updates text on the branch settings page explaining what branch approval limitations (as suggested by @yp05327) Official approval: <img width="376" alt="Screenshot 2024-08-26 at 1 03 52 PM" src="https://github.com/user-attachments/assets/500f083d-bfc0-45c5-82b7-b98e20495696"> Unofficial approval: <img width="442" alt="Screenshot 2024-08-26 at 12 53 15 PM" src="https://github.com/user-attachments/assets/e8c565ff-5886-4ce1-8b79-a0fa26c282f7"> Rejected approval: <img width="452" alt="Screenshot 2024-08-26 at 12 53 06 PM" src="https://github.com/user-attachments/assets/aebc0e2f-7052-4dea-8098-7caa0db86617"> Stale approval: <img width="546" alt="Screenshot 2024-08-26 at 1 07 59 PM" src="https://github.com/user-attachments/assets/da599ff3-e35c-4fa3-8141-ed80b738dd77"> Requested review tooltip: <img width="434" alt="Screenshot 2024-08-26 at 12 53 22 PM" src="https://github.com/user-attachments/assets/460d163e-8724-43b6-8760-34b285da8fe2"> Updated text for approvals: <img width="991" alt="Screenshot 2024-08-26 at 12 54 00 PM" src="https://github.com/user-attachments/assets/ab3ff012-9742-4c1b-933d-21addcb89f2c"> Updated text for allowlisted/whitelisted approvals: <img width="990" alt="Screenshot 2024-08-26 at 1 01 40 PM" src="https://github.com/user-attachments/assets/1a5bae61-d9e0-4d96-b86f-92610b0940d1"> Protected branch settings text: <img width="1022" alt="Screenshot 2024-08-26 at 1 01 14 PM" src="https://github.com/user-attachments/assets/892ce208-e1c2-41f7-8fec-46d5a0e7e776"> Comments list: <img width="1048" alt="Screenshot 2024-08-28 at 9 25 31 AM" src="https://github.com/user-attachments/assets/9c5c00c5-06cf-43b3-b413-4f7f673609b2"> --------- Co-authored-by: Kyle D. <kdumontnu@gmail.com>	2024-09-06 06:40:02 +00:00
Denys Konovalov	83f37f6302	Remove urls from translations (#31950) ... Part of #27700 Removes all URLs from translation strings to easy up changing them in the future and to exclude people injecting malicious URLs through translations. First measure as long as #24402 is out of scope.	2024-09-02 18:36:24 +00:00
a1012112796	39d2fdefaf	Split org Propfile README to a new tab overview (#31373) ... like user profile, add a new overviw tab to show profile READEME when it is exist. replace #31349 (another solution option) example view:   --------- Signed-off-by: a1012112796 <1012112796@qq.com>	2024-08-27 10:54:12 +08:00
william-allspice	40036b6102	Move lock icon position and add additional tooltips to branch list page (#31839) ... This Pull Request adds missing tool tips for the protected, copy, and rss icons on the branch list page. It also moved protected icon position after the branch name.	2024-08-21 05:40:18 +00:00
Lunny Xiao	ccf7366db0	Add tag name in the commits list (#31082) ... Fix #10036 This PR adds some labels for tags of this commit after the commit message on the commits table. The tag template is share as commit graph's. Desktop: <img width="1302" alt="image" src="https://github.com/go-gitea/gitea/assets/81045/ba94e1e6-2a3d-44f3-85a3-575fb5667c97"> Mobile: <img width="370" alt="image" src="https://github.com/go-gitea/gitea/assets/81045/e3eb1f44-3686-4012-aa9d-52cd88b22c0e">	2024-08-19 17:04:06 +00:00