gitea/modules/storage
Zettat123 898f852d03
Some checks are pending
release-nightly / disk-clean (push) Waiting to run
release-nightly / nightly-binary (push) Waiting to run
release-nightly / nightly-docker-rootful (push) Waiting to run
release-nightly / nightly-docker-rootless (push) Waiting to run
Fix missing signature key error when pulling Docker images with SERVE_DIRECT enabled (#32365) (#32397)
Backport #32365

Fix #28121

I did some tests and found that the `missing signature key` error is
caused by an incorrect `Content-Type` header. Gitea correctly sets the
`Content-Type` header when serving files.


348d1d0f32/routers/api/packages/container/container.go (L712-L717)
However, when `SERVE_DIRECT` is enabled, the `Content-Type` header may
be set to an incorrect value by the storage service. To fix this issue,
we can use query parameters to override response header values.

https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetObject.html <img
width="600px"

src="https://github.com/user-attachments/assets/f2ff90f0-f1df-46f9-9680-b8120222c555"
/>

In this PR, I introduced a new parameter to the `URL` method to support
additional parameters.

```
URL(path, name string, reqParams url.Values) (*url.URL, error)
```
2024-11-01 03:53:59 +00:00
..
helper_test.go Fix missing signature key error when pulling Docker images with SERVE_DIRECT enabled (#32365) (#32397) 2024-11-01 03:53:59 +00:00
helper.go Fix missing signature key error when pulling Docker images with SERVE_DIRECT enabled (#32365) (#32397) 2024-11-01 03:53:59 +00:00
local_test.go Fix all possible setting error related storages and added some tests (#23911) 2023-06-14 11:42:38 +08:00
local.go Fix missing signature key error when pulling Docker images with SERVE_DIRECT enabled (#32365) (#32397) 2024-11-01 03:53:59 +00:00
minio_test.go Fix object storage path handling (#27024) 2023-09-13 01:18:52 +00:00
minio.go Fix missing signature key error when pulling Docker images with SERVE_DIRECT enabled (#32365) (#32397) 2024-11-01 03:53:59 +00:00
storage_test.go Fix all possible setting error related storages and added some tests (#23911) 2023-06-14 11:42:38 +08:00
storage.go Fix missing signature key error when pulling Docker images with SERVE_DIRECT enabled (#32365) (#32397) 2024-11-01 03:53:59 +00:00