github-mirror/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2024-12-11 12:47:36 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity
257ce61023
gitea/routers/web/repo
History
Zettat123 898f852d03
Some checks are pending
release-nightly / disk-clean (push) Waiting to run
Details
release-nightly / nightly-binary (push) Waiting to run
Details
release-nightly / nightly-docker-rootful (push) Waiting to run
Details
release-nightly / nightly-docker-rootless (push) Waiting to run
Details
Fix missing signature key error when pulling Docker images with SERVE_DIRECT enabled (#32365) (#32397) 
Backport #32365

Fix #28121

I did some tests and found that the `missing signature key` error is
caused by an incorrect `Content-Type` header. Gitea correctly sets the
`Content-Type` header when serving files.


348d1d0f32/routers/api/packages/container/container.go (L712-L717)
However, when `SERVE_DIRECT` is enabled, the `Content-Type` header may
be set to an incorrect value by the storage service. To fix this issue,
we can use query parameters to override response header values.

https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetObject.html <img
width="600px"

src="https://github.com/user-attachments/assets/f2ff90f0-f1df-46f9-9680-b8120222c555"
/>

In this PR, I introduced a new parameter to the `URL` method to support
additional parameters.

```
URL(path, name string, reqParams url.Values) (*url.URL, error)
```
2024-11-01 03:53:59 +00:00
..
actions Fix missing signature key error when pulling Docker images with SERVE_DIRECT enabled (#32365) (#32397) 2024-11-01 03:53:59 +00:00
setting Don't return 500 if mirror url contains special chars (#31859) (#31895) 2024-08-22 00:10:50 +08:00
activity.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
attachment.go Fix missing signature key error when pulling Docker images with SERVE_DIRECT enabled (#32365) (#32397) 2024-11-01 03:53:59 +00:00
blame.go Refactor file view & render (#30227) 2024-04-01 21:11:30 +08:00
branch.go Use repo object format name instead of detecting from git repository (#29702) 2024-03-10 22:30:36 +01:00
cherry_pick.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
code_frequency.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
commit.go Fix code search input for different views (#30678) 2024-04-26 11:21:04 +00:00
compare.go Refactor sha1 and time-limited code (#31023) (#31030) 2024-05-21 00:58:21 +08:00
contributors.go Fix Activity Page Contributors dropdown (#31264) (#31269) 2024-06-06 08:14:00 +00:00
download.go Fix missing signature key error when pulling Docker images with SERVE_DIRECT enabled (#32365) (#32397) 2024-11-01 03:53:59 +00:00
editor_test.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
editor.go Add missed return after ctx.ServerError (#31130) (#31133) 2024-05-28 12:47:11 +02:00
find.go Escape paths for find file correctly (#30026) 2024-03-23 13:07:47 +00:00
fork.go Use db.ListOptionsAll instead of db.ListOptions{ListAll: true} (#29995) 2024-03-22 13:53:52 +01:00
githttp_test.go Fix http protocol auth (#27875) 2023-11-02 22:14:33 +08:00
githttp.go Fix wrong last modify time (#32102) (#32104) 2024-09-22 19:12:57 +00:00
helper_test.go Make web context initialize correctly for different cases (#26726) 2023-08-25 19:07:42 +08:00
helper.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
issue_content_history.go Migrate margin and padding helpers to tailwind (#30043) 2024-03-24 17:42:49 +01:00
issue_dependency.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
issue_label_test.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
issue_label.go Refactor label.IsArchived() (#29750) 2024-03-13 07:04:07 +01:00
issue_lock.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
issue_pin.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
issue_stopwatch.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
issue_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue_timetrack.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
issue_watch.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
issue.go Fix Bug in Issue/pulls list (#32081) (#32115) 2024-09-24 01:26:10 +00:00
main_test.go make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
middlewares.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
migrate.go Fix javascript error when an anonymous user visiting migration page (#32144) (#32179) 2024-10-04 17:58:04 +00:00
milestone.go Remove AddParamIfExist(AddParam) (#29841) 2024-03-16 12:07:56 +00:00
packages.go Remove AddParamIfExist(AddParam) (#29841) 2024-03-16 12:07:56 +00:00
patch.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
projects_test.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
projects.go Fix various problems around projects board view (#30696) (#30902) 2024-05-08 15:46:21 +00:00
pull_review_test.go Fix template error when comment review doesn't exist (#29888) 2024-03-19 04:19:48 +00:00
pull_review.go Prevent allow/reject reviews on merged/closed PRs (#30686) 2024-04-27 11:55:03 +00:00
pull.go Avoid returning without written ctx when posting PR (#31843) (#31848) 2024-08-16 13:50:12 -04:00
recent_commits.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
release_test.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
release.go Use db.ListOptionsAll instead of db.ListOptions{ListAll: true} (#29995) 2024-03-22 13:53:52 +01:00
render.go Fix rendered wiki page link (#31398) (#31407) 2024-06-19 11:23:24 +08:00
repo.go Fix missing signature key error when pulling Docker images with SERVE_DIRECT enabled (#32365) (#32397) 2024-11-01 03:53:59 +00:00
search_test.go Improve grep search (#30843) (#30850) 2024-05-03 17:59:33 +08:00
search.go Improve grep search (#30843) (#30850) 2024-05-03 17:59:33 +08:00
topic.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
treelist.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
view_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
view.go Fix rendered wiki page link (#31398) (#31407) 2024-06-19 11:23:24 +08:00
wiki_test.go Fix raw wiki links (#31825) (#31845) 2024-08-17 03:19:26 +00:00
wiki.go Fix raw wiki links (#31825) (#31845) 2024-08-17 03:19:26 +00:00