mirror of
https://github.com/go-gitea/gitea.git
synced 2024-12-30 17:15:56 +08:00
580e21dd2e
Gitea instance keeps reporting a lot of errors like "LFS SSH transfer connection denied, pure SSH protocol is disabled". When starting debugging the problem, there are more problems found. Try to address most of them: * avoid unnecessary server side error logs (change `fail()` to not log them) * figure out the broken tests/user2/lfs.git (added comments) * avoid `migratePushMirrors` failure when a repository doesn't exist (ignore them) * avoid "Authorization" (internal&lfs) header conflicts, remove the tricky "swapAuth" and use "X-Gitea-Internal-Auth" * make internal token comparing constant time (it wasn't a serous problem because in a real world it's nearly impossible to timing-attack the token, but good to fix and backport) * avoid duplicate routers (introduce AddOwnerRepoGitLFSRoutes) * avoid "internal (private)" routes using session/web context (they should use private context) * fix incorrect "path" usages (use "filepath") * fix incorrect mocked route point handling (need to check func nil correctly) * split some tests from "git general tests" to "git misc tests" (to keep "git_general_test.go" simple) Still no correct result for Git LFS SSH tests. So the code is kept there (`tests/integration/git_lfs_ssh_test.go`) and a FIXME explains the details.
297 lines
7.5 KiB
Go
297 lines
7.5 KiB
Go
// Copyright 2024 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package backend
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"io"
|
|
"net/http"
|
|
"net/url"
|
|
"strconv"
|
|
"time"
|
|
|
|
"code.gitea.io/gitea/modules/json"
|
|
lfslock "code.gitea.io/gitea/modules/structs"
|
|
|
|
"github.com/charmbracelet/git-lfs-transfer/transfer"
|
|
)
|
|
|
|
var _ transfer.LockBackend = &giteaLockBackend{}
|
|
|
|
type giteaLockBackend struct {
|
|
ctx context.Context
|
|
g *GiteaBackend
|
|
server *url.URL
|
|
authToken string
|
|
internalAuth string
|
|
logger transfer.Logger
|
|
}
|
|
|
|
func newGiteaLockBackend(g *GiteaBackend) transfer.LockBackend {
|
|
server := g.server.JoinPath("locks")
|
|
return &giteaLockBackend{ctx: g.ctx, g: g, server: server, authToken: g.authToken, internalAuth: g.internalAuth, logger: g.logger}
|
|
}
|
|
|
|
// Create implements transfer.LockBackend
|
|
func (g *giteaLockBackend) Create(path, refname string) (transfer.Lock, error) {
|
|
reqBody := lfslock.LFSLockRequest{Path: path}
|
|
|
|
bodyBytes, err := json.Marshal(reqBody)
|
|
if err != nil {
|
|
g.logger.Log("json marshal error", err)
|
|
return nil, err
|
|
}
|
|
url := g.server.String()
|
|
headers := map[string]string{
|
|
headerAuthorization: g.authToken,
|
|
headerGiteaInternalAuth: g.internalAuth,
|
|
headerAccept: mimeGitLFS,
|
|
headerContentType: mimeGitLFS,
|
|
}
|
|
req := newInternalRequest(g.ctx, url, http.MethodPost, headers, bodyBytes)
|
|
resp, err := req.Response()
|
|
if err != nil {
|
|
g.logger.Log("http request error", err)
|
|
return nil, err
|
|
}
|
|
defer resp.Body.Close()
|
|
respBytes, err := io.ReadAll(resp.Body)
|
|
if err != nil {
|
|
g.logger.Log("http read error", err)
|
|
return nil, err
|
|
}
|
|
if resp.StatusCode != http.StatusCreated {
|
|
g.logger.Log("http statuscode error", resp.StatusCode, statusCodeToErr(resp.StatusCode))
|
|
return nil, statusCodeToErr(resp.StatusCode)
|
|
}
|
|
var respBody lfslock.LFSLockResponse
|
|
err = json.Unmarshal(respBytes, &respBody)
|
|
if err != nil {
|
|
g.logger.Log("json umarshal error", err)
|
|
return nil, err
|
|
}
|
|
|
|
if respBody.Lock == nil {
|
|
g.logger.Log("api returned nil lock")
|
|
return nil, fmt.Errorf("api returned nil lock")
|
|
}
|
|
respLock := respBody.Lock
|
|
owner := userUnknown
|
|
if respLock.Owner != nil {
|
|
owner = respLock.Owner.Name
|
|
}
|
|
lock := newGiteaLock(g, respLock.ID, respLock.Path, respLock.LockedAt, owner)
|
|
return lock, nil
|
|
}
|
|
|
|
// Unlock implements transfer.LockBackend
|
|
func (g *giteaLockBackend) Unlock(lock transfer.Lock) error {
|
|
reqBody := lfslock.LFSLockDeleteRequest{}
|
|
|
|
bodyBytes, err := json.Marshal(reqBody)
|
|
if err != nil {
|
|
g.logger.Log("json marshal error", err)
|
|
return err
|
|
}
|
|
url := g.server.JoinPath(lock.ID(), "unlock").String()
|
|
headers := map[string]string{
|
|
headerAuthorization: g.authToken,
|
|
headerGiteaInternalAuth: g.internalAuth,
|
|
headerAccept: mimeGitLFS,
|
|
headerContentType: mimeGitLFS,
|
|
}
|
|
req := newInternalRequest(g.ctx, url, http.MethodPost, headers, bodyBytes)
|
|
resp, err := req.Response()
|
|
if err != nil {
|
|
g.logger.Log("http request error", err)
|
|
return err
|
|
}
|
|
defer resp.Body.Close()
|
|
if resp.StatusCode != http.StatusOK {
|
|
g.logger.Log("http statuscode error", resp.StatusCode, statusCodeToErr(resp.StatusCode))
|
|
return statusCodeToErr(resp.StatusCode)
|
|
}
|
|
// no need to read response
|
|
|
|
return nil
|
|
}
|
|
|
|
// FromPath implements transfer.LockBackend
|
|
func (g *giteaLockBackend) FromPath(path string) (transfer.Lock, error) {
|
|
v := url.Values{
|
|
argPath: []string{path},
|
|
}
|
|
|
|
respLocks, _, err := g.queryLocks(v)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if len(respLocks) == 0 {
|
|
return nil, transfer.ErrNotFound
|
|
}
|
|
return respLocks[0], nil
|
|
}
|
|
|
|
// FromID implements transfer.LockBackend
|
|
func (g *giteaLockBackend) FromID(id string) (transfer.Lock, error) {
|
|
v := url.Values{
|
|
argID: []string{id},
|
|
}
|
|
|
|
respLocks, _, err := g.queryLocks(v)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if len(respLocks) == 0 {
|
|
return nil, transfer.ErrNotFound
|
|
}
|
|
return respLocks[0], nil
|
|
}
|
|
|
|
// Range implements transfer.LockBackend
|
|
func (g *giteaLockBackend) Range(cursor string, limit int, iter func(transfer.Lock) error) (string, error) {
|
|
v := url.Values{
|
|
argLimit: []string{strconv.FormatInt(int64(limit), 10)},
|
|
}
|
|
if cursor != "" {
|
|
v[argCursor] = []string{cursor}
|
|
}
|
|
|
|
respLocks, cursor, err := g.queryLocks(v)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
|
|
for _, lock := range respLocks {
|
|
err := iter(lock)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
}
|
|
return cursor, nil
|
|
}
|
|
|
|
func (g *giteaLockBackend) queryLocks(v url.Values) ([]transfer.Lock, string, error) {
|
|
urlq := g.server.JoinPath() // get a copy
|
|
urlq.RawQuery = v.Encode()
|
|
url := urlq.String()
|
|
headers := map[string]string{
|
|
headerAuthorization: g.authToken,
|
|
headerGiteaInternalAuth: g.internalAuth,
|
|
headerAccept: mimeGitLFS,
|
|
headerContentType: mimeGitLFS,
|
|
}
|
|
req := newInternalRequest(g.ctx, url, http.MethodGet, headers, nil)
|
|
resp, err := req.Response()
|
|
if err != nil {
|
|
g.logger.Log("http request error", err)
|
|
return nil, "", err
|
|
}
|
|
defer resp.Body.Close()
|
|
respBytes, err := io.ReadAll(resp.Body)
|
|
if err != nil {
|
|
g.logger.Log("http read error", err)
|
|
return nil, "", err
|
|
}
|
|
if resp.StatusCode != http.StatusOK {
|
|
g.logger.Log("http statuscode error", resp.StatusCode, statusCodeToErr(resp.StatusCode))
|
|
return nil, "", statusCodeToErr(resp.StatusCode)
|
|
}
|
|
var respBody lfslock.LFSLockList
|
|
err = json.Unmarshal(respBytes, &respBody)
|
|
if err != nil {
|
|
g.logger.Log("json umarshal error", err)
|
|
return nil, "", err
|
|
}
|
|
|
|
respLocks := make([]transfer.Lock, 0, len(respBody.Locks))
|
|
for _, respLock := range respBody.Locks {
|
|
owner := userUnknown
|
|
if respLock.Owner != nil {
|
|
owner = respLock.Owner.Name
|
|
}
|
|
lock := newGiteaLock(g, respLock.ID, respLock.Path, respLock.LockedAt, owner)
|
|
respLocks = append(respLocks, lock)
|
|
}
|
|
return respLocks, respBody.Next, nil
|
|
}
|
|
|
|
var _ transfer.Lock = &giteaLock{}
|
|
|
|
type giteaLock struct {
|
|
g *giteaLockBackend
|
|
id string
|
|
path string
|
|
lockedAt time.Time
|
|
owner string
|
|
}
|
|
|
|
func newGiteaLock(g *giteaLockBackend, id, path string, lockedAt time.Time, owner string) transfer.Lock {
|
|
return &giteaLock{g: g, id: id, path: path, lockedAt: lockedAt, owner: owner}
|
|
}
|
|
|
|
// Unlock implements transfer.Lock
|
|
func (g *giteaLock) Unlock() error {
|
|
return g.g.Unlock(g)
|
|
}
|
|
|
|
// ID implements transfer.Lock
|
|
func (g *giteaLock) ID() string {
|
|
return g.id
|
|
}
|
|
|
|
// Path implements transfer.Lock
|
|
func (g *giteaLock) Path() string {
|
|
return g.path
|
|
}
|
|
|
|
// FormattedTimestamp implements transfer.Lock
|
|
func (g *giteaLock) FormattedTimestamp() string {
|
|
return g.lockedAt.UTC().Format(time.RFC3339)
|
|
}
|
|
|
|
// OwnerName implements transfer.Lock
|
|
func (g *giteaLock) OwnerName() string {
|
|
return g.owner
|
|
}
|
|
|
|
func (g *giteaLock) CurrentUser() (string, error) {
|
|
return userSelf, nil
|
|
}
|
|
|
|
// AsLockSpec implements transfer.Lock
|
|
func (g *giteaLock) AsLockSpec(ownerID bool) ([]string, error) {
|
|
msgs := []string{
|
|
fmt.Sprintf("lock %s", g.ID()),
|
|
fmt.Sprintf("path %s %s", g.ID(), g.Path()),
|
|
fmt.Sprintf("locked-at %s %s", g.ID(), g.FormattedTimestamp()),
|
|
fmt.Sprintf("ownername %s %s", g.ID(), g.OwnerName()),
|
|
}
|
|
if ownerID {
|
|
user, err := g.CurrentUser()
|
|
if err != nil {
|
|
return nil, fmt.Errorf("error getting current user: %w", err)
|
|
}
|
|
who := "theirs"
|
|
if user == g.OwnerName() {
|
|
who = "ours"
|
|
}
|
|
msgs = append(msgs, fmt.Sprintf("owner %s %s", g.ID(), who))
|
|
}
|
|
return msgs, nil
|
|
}
|
|
|
|
// AsArguments implements transfer.Lock
|
|
func (g *giteaLock) AsArguments() []string {
|
|
return []string{
|
|
fmt.Sprintf("id=%s", g.ID()),
|
|
fmt.Sprintf("path=%s", g.Path()),
|
|
fmt.Sprintf("locked-at=%s", g.FormattedTimestamp()),
|
|
fmt.Sprintf("ownername=%s", g.OwnerName()),
|
|
}
|
|
}
|