Jason Song 7985cde84d

Fix Actions being enabled accidentally (#24802) ...

Regression of #24536. If the user doesn't explicitly disable Actions, it
will be enabled.

1. Gitea will call `loadRepositoryFrom` before `loadActionsFrom`.

25d4f95df2/modules/setting/setting.go (L234-L237)
2. In `loadRepositoryFrom`,
`rootCfg.Section("actions").Key("ENABLED").MustBool(true)` will set
`actions.ENABLED` with `true`.

25d4f95df2/modules/setting/repository.go (L313-L315)
3. In `loadActionsFrom`, `rootCfg.Section("actions")` will get a section
with Actions enabled.

25d4f95df2/modules/setting/actions.go (L23-L26)

Although the cause of the problem was using `true` by copy-paste
mistake, it also surprised me that
**`rootCfg.Section("actions").Key("ENABLED").MustBool(true)` doesn't
only read, but also write.**

2023-05-19 19:35:12 +08:00

..

actions.go

Refactor the setting to make unit test easier (#22405)

2023-02-20 00:12:01 +08:00

admin.go

Refactor the setting to make unit test easier (#22405)

2023-02-20 00:12:01 +08:00

api.go

Refactor the setting to make unit test easier (#22405)

2023-02-20 00:12:01 +08:00

asset_dynamic.go

Use a general approach to access custom/static/builtin assets (#24022)

2023-04-12 18:16:45 +08:00

asset_static.go

Use a general approach to access custom/static/builtin assets (#24022)

2023-04-12 18:16:45 +08:00

attachment.go

Add .patch to attachment.ALLOWED_TYPES (#23580)

2023-03-19 15:58:43 -04:00

cache.go

Refactor the setting to make unit test easier (#22405)

2023-02-20 00:12:01 +08:00

camo.go

Refactor the setting to make unit test easier (#22405)

2023-02-20 00:12:01 +08:00

config_provider.go

Remove unnecessary code (#24610)

2023-05-10 04:57:06 +00:00

cors.go

Fix incorrect CORS default values (#24206)

2023-04-19 15:30:10 -04:00

cron_test.go

Rewrite queue (#24505)

2023-05-08 19:49:59 +08:00

cron.go

Refactor the setting to make unit test easier (#22405)

2023-02-20 00:12:01 +08:00

database_sqlite.go

Implement FSFE REUSE for golang files (#21840)

2022-11-27 18:20:29 +00:00

database_test.go

Implement FSFE REUSE for golang files (#21840)

2022-11-27 18:20:29 +00:00

database.go

Move pidfile creation from setting to web cmd package (#23285)

2023-03-16 15:22:54 +08:00

federation.go

Refactor the setting to make unit test easier (#22405)

2023-02-20 00:12:01 +08:00

git.go

Support reflogs (#22451)

2023-03-13 15:51:07 +08:00

highlight.go

Refactor the setting to make unit test easier (#22405)

2023-02-20 00:12:01 +08:00

i18n.go

Refactor the setting to make unit test easier (#22405)

2023-02-20 00:12:01 +08:00

incoming_email.go

Refactor the setting to make unit test easier (#22405)

2023-02-20 00:12:01 +08:00

indexer_test.go

Implement FSFE REUSE for golang files (#21840)

2022-11-27 18:20:29 +00:00

indexer.go

Rewrite queue (#24505)

2023-05-08 19:49:59 +08:00

lfs.go

Increase default LFS auth timeout from 20m to 24h (#24628)

2023-05-10 22:23:47 +08:00

log.go

Refactor config provider (#24245)

2023-04-25 23:06:39 +08:00

mailer_test.go

Remove unnecessary code (#24610)

2023-05-10 04:57:06 +00:00

mailer.go

Make mailer SMTP check have timed context (#24751)

2023-05-16 22:55:51 +02:00

markup.go

Add .livemd as a markdown extension (#22730)

2023-04-26 11:22:54 -04:00

metrics.go

Refactor the setting to make unit test easier (#22405)

2023-02-20 00:12:01 +08:00

migrations.go

Refactor the setting to make unit test easier (#22405)

2023-02-20 00:12:01 +08:00

mime_type_map.go

Refactor the setting to make unit test easier (#22405)

2023-02-20 00:12:01 +08:00

mirror.go

handle deprecated settings (#22992)

2023-02-20 16:18:26 -06:00

oauth2.go

Refactor config provider (#24245)

2023-04-25 23:06:39 +08:00

other.go

Refactor setting.Other and remove unused SHOW_FOOTER_BRANDING (#24270)

2023-04-22 19:38:25 -04:00

packages_test.go

Remove unnecessary code (#24610)

2023-05-10 04:57:06 +00:00

packages.go

Add Go package registry (#24687)

2023-05-14 23:38:40 +08:00

picture.go

Improve avatar uploading / resizing / compressing, remove Fomantic card module (#24653)

2023-05-13 20:59:11 +02:00

project.go

Refactor the setting to make unit test easier (#22405)

2023-02-20 00:12:01 +08:00

proxy.go

Refactor the setting to make unit test easier (#22405)

2023-02-20 00:12:01 +08:00

queue.go

Rewrite queue (#24505)

2023-05-08 19:49:59 +08:00

repository.go

Fix Actions being enabled accidentally (#24802)

2023-05-19 19:35:12 +08:00

security.go

Refactor config provider (#24245)

2023-04-25 23:06:39 +08:00

server.go

handle deprecated settings (#22992)

2023-02-20 16:18:26 -06:00

service.go

Refactor the setting to make unit test easier (#22405)

2023-02-20 00:12:01 +08:00

session.go

Refactor cookie (#24107)

2023-04-13 15:45:33 -04:00

setting_test.go

Implement FSFE REUSE for golang files (#21840)

2022-11-27 18:20:29 +00:00

setting.go

Merge setting.InitXXX into one function with options (#24389)

2023-05-04 11:55:35 +08:00

ssh.go

Prefer native parser for SSH public key parsing (#23798)

2023-04-11 14:34:28 +08:00

storage_test.go

Rewrite queue (#24505)

2023-05-08 19:49:59 +08:00

storage.go

Refactor config provider (#24245)

2023-04-25 23:06:39 +08:00

task.go

handle deprecated settings (#22992)

2023-02-20 16:18:26 -06:00

time.go

Remove unused setting time.FORMAT (#24430)

2023-04-29 22:51:43 +02:00

ui.go

Don't set meta theme-color by default (#24340)

2023-04-26 00:56:42 -04:00

webhook.go

Refactor the setting to make unit test easier (#22405)

2023-02-20 00:12:01 +08:00