zeripath 8354670708

Prevent hang in git cat-file if repository is not a valid repository and other fixes (#17991) ...

This PR contains multiple fixes. The most important of which is:

* Prevent hang in git cat-file if the repository is not a valid repository 
    
    Unfortunately it appears that if git cat-file is run in an invalid
    repository it will hang until stdin is closed. This will result in
    deadlocked /pulls pages and dangling git cat-file calls if a broken
    repository is tried to be reviewed or pulls exists for a broken
    repository.

    Fix #14734
    Fix #9271
    Fix #16113

Otherwise there are a few small other fixes included which this PR was initially intending to fix:

* Fix panic on partial compares due to missing PullRequestWorkInProgressPrefixes
* Fix links on pulls pages  due to regression from #17551 - by making most /issues routes match /pulls too - Fix #17983
* Fix links on feeds pages due to another regression from #17551 but also fix issue with syncing tags - Fix #17943
* Add missing locale entries for oauth group claims
* Prevent NPEs if ColorFormat is called on nil users, repos or teams.

2021-12-16 19:01:14 +00:00

..

admin

Move user/org deletion to services (#17673)

2021-11-19 01:42:27 +08:00

appstate

Sync gitea app path for git hooks and authorized keys when starting (#17335)

2021-10-21 17:22:43 +08:00

asymkey

Move keys to models/asymkey (#17917)

2021-12-10 16:14:24 +08:00

avatars

Make AvatarRenderedSizeFactor configurable and set it to 3 (#17951)

2021-12-16 10:18:38 +08:00

db

Move keys to models/asymkey (#17917)

2021-12-10 16:14:24 +08:00

fixtures

Allow U2F 2FA without TOTP (#11573)

2021-11-08 23:47:19 +01:00

issues

Improvements to content history (#17746)

2021-11-22 20:20:16 +08:00

login

Remove NewSession method from db.Engine interface (#17577)

2021-11-21 23:41:00 +08:00

migrations

Prevent hang in git cat-file if repository is not a valid repository and other fixes (#17991)

2021-12-16 19:01:14 +00:00

perm

Move accessmode into models/perm (#17828)

2021-11-28 12:58:28 +01:00

repo

Prevent hang in git cat-file if repository is not a valid repository and other fixes (#17991)

2021-12-16 19:01:14 +00:00

unit

Move unit into models/unit/ (#17576)

2021-11-09 20:57:58 +01:00

unittest

Prevent hang in git cat-file if repository is not a valid repository and other fixes (#17991)

2021-12-16 19:01:14 +00:00

user

Prevent hang in git cat-file if repository is not a valid repository and other fixes (#17991)

2021-12-16 19:01:14 +00:00

webhook

Remove NewSession method from db.Engine interface (#17577)

2021-11-21 23:41:00 +08:00

access_test.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

access.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

action_list.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

action_test.go

Some repository refactors (#17950)

2021-12-12 23:48:20 +08:00

action.go

Prevent hang in git cat-file if repository is not a valid repository and other fixes (#17991)

2021-12-16 19:01:14 +00:00

branches_test.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

branches.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

commit_status_test.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

commit_status.go

Add missing X-Total-Count and fix some related bugs (#17968)

2021-12-15 13:39:34 +08:00

commit.go

Move keys to models/asymkey (#17917)

2021-12-10 16:14:24 +08:00

consistency_test.go

A better go code formatter, and now make fmt can run in Windows (#17684)

2021-11-17 20:34:35 +08:00

consistency.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

engine_test.go

Refactor install page (db type) (#17919)

2021-12-07 13:44:08 +08:00

error.go

Some repository refactors (#17950)

2021-12-12 23:48:20 +08:00

fixture_generation.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

fixture_test.go

Decouple unit test code from business code (#17623)

2021-11-12 22:36:47 +08:00

helper_directory.go

refactor: move from io/ioutil to io and os package (#17109)

2021-09-22 13:38:34 +08:00

helper_environment.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

helper.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

issue_assignees_test.go

Move user related model into models/user (#17781)

2021-11-24 17:49:20 +08:00

issue_assignees.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

issue_comment_list.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

issue_comment_test.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

issue_comment.go

Add missing X-Total-Count and fix some related bugs (#17968)

2021-12-15 13:39:34 +08:00

issue_dependency_test.go

Move user related model into models/user (#17781)

2021-11-24 17:49:20 +08:00

issue_dependency.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

issue_label_test.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

issue_label.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

issue_list_test.go

Decouple unit test, remove intermediate unittestbridge package (#17662)

2021-11-16 16:53:21 +08:00

issue_list.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

issue_lock.go

Move user related model into models/user (#17781)

2021-11-24 17:49:20 +08:00

issue_milestone_test.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

issue_milestone.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

issue_reaction_test.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

issue_reaction.go

Add missing X-Total-Count and fix some related bugs (#17968)

2021-12-15 13:39:34 +08:00

issue_stopwatch_test.go

Move user related model into models/user (#17781)

2021-11-24 17:49:20 +08:00

issue_stopwatch.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

issue_test.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

issue_tracked_time_test.go

Move user related model into models/user (#17781)

2021-11-24 17:49:20 +08:00

issue_tracked_time.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

issue_user_test.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

issue_user.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

issue_watch_test.go

A better go code formatter, and now make fmt can run in Windows (#17684)

2021-11-17 20:34:35 +08:00

issue_watch.go

Add missing X-Total-Count and fix some related bugs (#17968)

2021-12-15 13:39:34 +08:00

issue_xref_test.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

issue_xref.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

issue.go

Add missing X-Total-Count and fix some related bugs (#17968)

2021-12-15 13:39:34 +08:00

lfs_lock.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

lfs.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

main_test.go

Move keys to models/asymkey (#17917)

2021-12-10 16:14:24 +08:00

migrate.go

Move more model into models/user (#17826)

2021-11-28 22:11:58 +08:00

notification_test.go

Move user related model into models/user (#17781)

2021-11-24 17:49:20 +08:00

notification.go

Some repository refactors (#17950)

2021-12-12 23:48:20 +08:00

org_team_test.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

org_team.go

Prevent hang in git cat-file if repository is not a valid repository and other fixes (#17991)

2021-12-16 19:01:14 +00:00

org_test.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

org.go

Some repository refactors (#17950)

2021-12-12 23:48:20 +08:00

project_board.go

Support sorting for project board issuses (#17152)

2021-12-08 14:57:18 +08:00

project_issue.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

project_test.go

Decouple unit test code from business code (#17623)

2021-11-12 22:36:47 +08:00

project.go

Remove NewSession method from db.Engine interface (#17577)

2021-11-21 23:41:00 +08:00

protected_tag_test.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

protected_tag.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

pull_list.go

Move user related model into models/user (#17781)

2021-11-24 17:49:20 +08:00

pull_test.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

pull.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

release.go

Some repository refactors (#17950)

2021-12-12 23:48:20 +08:00

repo_activity.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

repo_collaboration_test.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

repo_collaboration.go

Some repository refactors (#17950)

2021-12-12 23:48:20 +08:00

repo_generate_test.go

Fixed assert statements. (#16089)

2021-06-07 07:27:09 +02:00

repo_generate.go

Some repository refactors (#17950)

2021-12-12 23:48:20 +08:00

repo_list_test.go

Decouple unit test, remove intermediate unittestbridge package (#17662)

2021-11-16 16:53:21 +08:00

repo_list.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

repo_permission_test.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

repo_permission.go

Some repository refactors (#17950)

2021-12-12 23:48:20 +08:00

repo_test.go

Some repository refactors (#17950)

2021-12-12 23:48:20 +08:00

repo_transfer_test.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

repo_transfer.go

Some repository refactors (#17950)

2021-12-12 23:48:20 +08:00

repo.go

Improve behavior of "Fork" button (#17288)

2021-12-13 09:59:09 +08:00

review_test.go

Move user related model into models/user (#17781)

2021-11-24 17:49:20 +08:00

review.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

statistic.go

Some repository refactors (#17950)

2021-12-12 23:48:20 +08:00

task.go

Move repository model into models/repo (#17933)

2021-12-10 09:27:50 +08:00

token_test.go

A better go code formatter, and now make fmt can run in Windows (#17684)

2021-11-17 20:34:35 +08:00

token.go

Fix problem when database ID is not incremented as expected (#17229)

2021-10-06 15:36:24 -05:00

upload.go

Remove NewSession method from db.Engine interface (#17577)

2021-11-21 23:41:00 +08:00

user_heatmap_test.go

Move user related model into models/user (#17781)

2021-11-24 17:49:20 +08:00

user_heatmap.go

Move user related model into models/user (#17781)

2021-11-24 17:49:20 +08:00

user_test.go

Move keys to models/asymkey (#17917)

2021-12-10 16:14:24 +08:00

user.go

Some repository refactors (#17950)

2021-12-12 23:48:20 +08:00

userlist_test.go

Move more model into models/user (#17826)

2021-11-28 22:11:58 +08:00

userlist.go

Move more model into models/user (#17826)

2021-11-28 22:11:58 +08:00