gitea/routers/api/v1/repo
wxiaoguang dd8bc1d61d
Refactor issue template parsing and fix API endpoint (#29069) (#29140)
Backport #29069

The old code `GetTemplatesFromDefaultBranch(...) ([]*api.IssueTemplate,
map[string]error)` doesn't really follow Golang's habits, then the
second returned value might be misused. For example, the API function
`GetIssueTemplates` incorrectly checked the second returned value and
always responds 500 error.

This PR refactors GetTemplatesFromDefaultBranch to
ParseTemplatesFromDefaultBranch and clarifies its behavior, and fixes
the API endpoint bug, and adds some tests.

And by the way, add proper prefix `X-` for the header generated in
`checkDeprecatedAuthMethods`, because non-standard HTTP headers should
have `X-` prefix, and it is also consistent with the new code in
`GetIssueTemplates`
2024-02-14 01:32:31 +00:00
..
action.go Refactor secrets modification logic (#26873) 2023-09-05 15:21:02 +00:00
avatar.go Add missing 404 response to Swagger (#27038) 2023-09-13 10:37:54 +08:00
blob.go Add missing 404 response to Swagger (#27038) 2023-09-13 10:37:54 +08:00
branch.go Also sync DB branches on push if necessary (#28361) (#28403) 2023-12-11 06:16:56 +00:00
collaborators.go More db.DefaultContext refactor (#27265) (#27347) 2023-09-29 13:35:01 +00:00
commits.go Filter get single commit (#24613) 2023-05-10 09:34:07 +08:00
file.go Add context parameter to some database functions (#26055) 2023-07-22 22:14:27 +08:00
fork.go Reduce usage of db.DefaultContext (#27073) 2023-09-14 17:09:32 +00:00
git_hook.go Add missing 404 response to Swagger (#27038) 2023-09-13 10:37:54 +08:00
git_ref.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
hook_test.go Move web/api context related testing function into a separate package (#26859) 2023-09-01 11:26:07 +00:00
hook.go Fix comment permissions (#28213) (#28216) 2023-11-25 23:43:23 +00:00
issue_attachment.go More refactoring of db.DefaultContext (#27083) 2023-09-15 06:13:19 +00:00
issue_comment_attachment.go Fix comment permissions (#28213) (#28216) 2023-11-25 23:43:23 +00:00
issue_comment.go Fix comment permissions (#28213) (#28216) 2023-11-25 23:43:23 +00:00
issue_dependency.go Fix issue dependencies (#27736) (#28776) 2024-01-12 23:29:22 +02:00
issue_label.go Don't let API add 2 exclusive labels from same scope (#27433) (#27460) 2023-10-06 05:06:31 +08:00
issue_pin.go Add missing 404 response to Swagger (#27038) 2023-09-13 10:37:54 +08:00
issue_reaction.go Fix comment permissions (#28213) (#28216) 2023-11-25 23:43:23 +00:00
issue_stopwatch.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
issue_subscription.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
issue_tracked_time.go Add missing 404 response to Swagger (#27038) 2023-09-13 10:37:54 +08:00
issue.go Fix comment permissions (#28213) (#28216) 2023-11-25 23:43:23 +00:00
key.go Fix comment permissions (#28213) (#28216) 2023-11-25 23:43:23 +00:00
label.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
language.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
main_test.go Merge setting.InitXXX into one function with options (#24389) 2023-05-04 11:55:35 +08:00
migrate.go move repository deletion to service layer (#26948) 2023-09-08 04:51:15 +00:00
milestone.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
mirror.go Add RemoteAddress to mirrors (#26952) 2023-09-16 16:03:02 +00:00
notes.go api: GetPullRequestCommits: return file list (#27483) (#27539) 2023-10-09 14:21:35 +02:00
patch.go Add missing 404 response to Swagger (#27038) 2023-09-13 10:37:54 +08:00
pull_review.go More db.DefaultContext refactor (#27265) (#27347) 2023-09-29 13:35:01 +00:00
pull.go api: GetPullRequestCommits: return file list (#27483) (#27539) 2023-10-09 14:21:35 +02:00
release_attachment.go Fix comment permissions (#28213) (#28216) 2023-11-25 23:43:23 +00:00
release_tags.go Fix comment permissions (#28213) (#28216) 2023-11-25 23:43:23 +00:00
release.go Fix comment permissions (#28213) (#28216) 2023-11-25 23:43:23 +00:00
repo_test.go Move web/api context related testing function into a separate package (#26859) 2023-09-01 11:26:07 +00:00
repo.go Refactor issue template parsing and fix API endpoint (#29069) (#29140) 2024-02-14 01:32:31 +00:00
star.go More refactoring of db.DefaultContext (#27083) 2023-09-15 06:13:19 +00:00
status.go Fix GetCommitStatuses (#28787) (#28804) 2024-01-15 19:30:12 +01:00
subscriber.go More refactoring of db.DefaultContext (#27083) 2023-09-15 06:13:19 +00:00
tag.go Fix comment permissions (#28213) (#28216) 2023-11-25 23:43:23 +00:00
teams.go More refactoring of db.DefaultContext (#27083) 2023-09-15 06:13:19 +00:00
topic.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
transfer.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
tree.go Add missing 404 response to Swagger (#27038) 2023-09-13 10:37:54 +08:00
wiki.go Fix an actions schedule bug (#28942) (#28999) 2024-01-31 15:52:31 +00:00