github-mirror/lkmpg
2
0
Fork 0
mirror of https://github.com/sysprog21/lkmpg.git synced 2024-11-23 02:26:12 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix dereference NULL pointer with proc_lseek

Browse Source 
Since the operations are static storage duration, the pointer in
operation structures will initialize with NULL. But, the kernel
doesn't check whether the pointer is NULL or not when calling it.

Related Discussion:
- https://github.com/sysprog21/lkmpg/issues/165
- https://github.com/sysprog21/lkmpg/issues/160

Close #165
This commit is contained in:
linD026 2022-09-21 13:55:30 +08:00
parent c69eff9d1f
commit 0f9c72631c
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
examples/sleep.c
View File

@ -169,6 +169,7 @@ static const struct proc_ops file_ops_4_our_proc_file = {
.proc_write = module_input, /* "write" to the file */ .proc_write = module_input, /* "write" to the file */
.proc_open = module_open, /* called when the /proc file is opened */ .proc_open = module_open, /* called when the /proc file is opened */
.proc_release = module_close, /* called when it's closed */ .proc_release = module_close, /* called when it's closed */
.proc_lseek = noop_llseek, /* return file->f_pos */
}; };
#else #else
static const struct file_operations file_ops_4_our_proc_file = { static const struct file_operations file_ops_4_our_proc_file = {
@ -176,6 +177,7 @@ static const struct file_operations file_ops_4_our_proc_file = {
.write = module_input, .write = module_input,
.open = module_open, .open = module_open,
.release = module_close, .release = module_close,
.llseek = noop_llseek,
}; };
#endif #endif