github-mirror/lkmpg
github-mirror/lkmpg
2
0
Fork 0
mirror of https://github.com/sysprog21/lkmpg.git synced 2025-03-13 05:55:10 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove redundant code

Browse Source 
Remove unnecessary definition of SUCCESS, as returning 0 already
indicates successful execution.
This commit is contained in:
jeremy90307 2025-03-10 22:09:22 +08:00
parent e061eaf5e3
commit d1d76f7efd
3 changed files with 9 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
examples/chardev.c
View File

@ -25,7 +25,6 @@ static ssize_t device_read(struct file *, char __user *, size_t, loff_t *);
static ssize_t device_write(struct file *, const char __user *, size_t, static ssize_t device_write(struct file *, const char __user *, size_t,
loff_t *); loff_t *);
#define SUCCESS 0
#define DEVICE_NAME "chardev" /* Dev name as it appears in /proc/devices */ #define DEVICE_NAME "chardev" /* Dev name as it appears in /proc/devices */
#define BUF_LEN 80 /* Max length of the message from the device */ #define BUF_LEN 80 /* Max length of the message from the device */
@ -72,7 +71,7 @@ static int __init chardev_init(void)
pr_info("Device created on /dev/%s\n", DEVICE_NAME); pr_info("Device created on /dev/%s\n", DEVICE_NAME);
return SUCCESS; return 0;
} }
static void __exit chardev_exit(void) static void __exit chardev_exit(void)
@ -99,7 +98,7 @@ static int device_open(struct inode *inode, struct file *file)
sprintf(msg, "I already told you %d times Hello world!\n", counter++); sprintf(msg, "I already told you %d times Hello world!\n", counter++);
try_module_get(THIS_MODULE); try_module_get(THIS_MODULE);
return SUCCESS; return 0;
} }
/* Called when a process closes the device file. */ /* Called when a process closes the device file. */
@ -113,7 +112,7 @@ static int device_release(struct inode *inode, struct file *file)
*/ */
module_put(THIS_MODULE); module_put(THIS_MODULE);
return SUCCESS; return 0;
} }
/* Called when a process, which already opened the dev file, attempts to /* Called when a process, which already opened the dev file, attempts to

7
examples/chardev2.c
View File

@ -17,7 +17,6 @@
#include <asm/errno.h> #include <asm/errno.h>
#include "chardev.h" #include "chardev.h"
#define SUCCESS 0
#define DEVICE_NAME "char_dev" #define DEVICE_NAME "char_dev"
#define BUF_LEN 80 #define BUF_LEN 80
@ -42,7 +41,7 @@ static int device_open(struct inode *inode, struct file *file)
pr_info("device_open(%p)\n", file); pr_info("device_open(%p)\n", file);
try_module_get(THIS_MODULE); try_module_get(THIS_MODULE);
return SUCCESS; return 0;
} }
static int device_release(struct inode *inode, struct file *file) static int device_release(struct inode *inode, struct file *file)
@ -50,7 +49,7 @@ static int device_release(struct inode *inode, struct file *file)
pr_info("device_release(%p,%p)\n", inode, file); pr_info("device_release(%p,%p)\n", inode, file);
module_put(THIS_MODULE); module_put(THIS_MODULE);
return SUCCESS; return 0;
} }
/* This function is called whenever a process which has already opened the /* This function is called whenever a process which has already opened the
@ -126,7 +125,7 @@ device_ioctl(struct file *file, /* ditto */
unsigned long ioctl_param) unsigned long ioctl_param)
{ {
int i; int i;
long ret = SUCCESS; long ret = 0;
/* We don't want to talk to two processes at the same time. */ /* We don't want to talk to two processes at the same time. */
if (atomic_cmpxchg(&already_open, CDEV_NOT_USED, CDEV_EXCLUSIVE_OPEN)) if (atomic_cmpxchg(&already_open, CDEV_NOT_USED, CDEV_EXCLUSIVE_OPEN))

7
examples/static_key.c
View File

@ -22,7 +22,6 @@ static ssize_t device_read(struct file *file, char __user *buf, size_t count,
static ssize_t device_write(struct file *file, const char __user *buf, static ssize_t device_write(struct file *file, const char __user *buf,
size_t count, loff_t *ppos); size_t count, loff_t *ppos);
#define SUCCESS 0
#define DEVICE_NAME "key_state" #define DEVICE_NAME "key_state"
#define BUF_LEN 10 #define BUF_LEN 10
@ -71,7 +70,7 @@ static int __init chardev_init(void)
pr_info("Device created on /dev/%s\n", DEVICE_NAME); pr_info("Device created on /dev/%s\n", DEVICE_NAME);
return SUCCESS; return 0;
} }
static void __exit chardev_exit(void) static void __exit chardev_exit(void)
@ -103,7 +102,7 @@ static int device_open(struct inode *inode, struct file *file)
try_module_get(THIS_MODULE); try_module_get(THIS_MODULE);
return SUCCESS; return 0;
} }
/** /**
@ -120,7 +119,7 @@ static int device_release(struct inode *inode, struct file *file)
*/ */
module_put(THIS_MODULE); module_put(THIS_MODULE);
return SUCCESS; return 0;
} }
/** /**