github-mirror/mergerfs
2
0
Fork 0
mirror of https://github.com/trapexit/mergerfs.git synced 2024-11-22 11:39:52 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Ensure lookups of FUSE_ROOT_ID always return generation=0

Browse Source
This commit is contained in:
Antonio SJ Musumeci 2024-02-25 17:03:47 -06:00
parent 85a936c95e
commit 951eb9540d
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
libfuse/lib/fuse.c
View File

@ -1375,7 +1375,7 @@ set_path_info(struct fuse *f,
return -ENOMEM; return -ENOMEM;
e->ino = node->nodeid; e->ino = node->nodeid;
e->generation = f->nodeid_gen.generation; e->generation = ((e->ino == FUSE_ROOT_ID) ? 0 : f->nodeid_gen.generation);
pthread_mutex_lock(&f->lock); pthread_mutex_lock(&f->lock);
update_stat(node,&e->attr); update_stat(node,&e->attr);
@ -1386,6 +1386,15 @@ set_path_info(struct fuse *f,
return 0; return 0;
} }
/*
lookup requests only come in for FUSE_ROOT_ID when a "parent of
child of root node" request is made. This can happen when using
EXPORT_SUPPORT=true and a file handle is used to keep a reference to
a node which has been forgotten. Mostly a NFS concern but not
excluslively. Root node always has a nodeid of 1 and generation of
0. To ensure this set_path_info() explicitly ensures the root id has
a generation of 0.
*/
static static
int int
lookup_path(struct fuse *f, lookup_path(struct fuse *f,

5
libfuse/lib/fuse_lowlevel.c
View File

@ -294,6 +294,11 @@ fuse_reply_entry(fuse_req_t req,
fill_entry(&arg, e); fill_entry(&arg, e);
#ifdef NDEBUG
// TODO: Add checks for cases where a node could be marked bad by
// the kernel.
#endif
return send_reply_ok(req, &arg, size); return send_reply_ok(req, &arg, size);
} }