cmdtest: end-to-end test for commands, flags and environment variables
There was no easy way to automatically test the end-to-end functionality
of commands, flags, environment variables etc.
The need for end-to-end testing was highlighted by the issues fixed
in #5341. There was no automated test to continually verify current
behaviour, nor a framework to quickly test the correctness of the fixes.
This change adds an end-to-end testing framework in the cmdtest folder.
It has some simple examples in func TestCmdTest in cmdtest_test.go. The
tests should be readable by anybody familiar with rclone and look like
this:
// Test the rclone version command with debug logging (-vv)
out, err = rclone("version", "-vv")
if assert.NoError(t, err) {
assert.Contains(t, out, "rclone v")
assert.Contains(t, out, "os/version:")
assert.Contains(t, out, " DEBUG : ")
}
The end-to-end tests are executed just like the Go unit tests, that is:
go test ./cmdtest -v
The change also contains a thorough test of environment variables in
environment_test.go.
Thanks to @ncw for encouragement and introduction to the TestMain trick.
2021-06-04 16:56:40 +08:00
|
|
|
// cmdtest_test creates a testable interface to rclone main
|
|
|
|
//
|
|
|
|
// The interface is used to perform end-to-end test of
|
|
|
|
// commands, flags, environment variables etc.
|
|
|
|
|
|
|
|
package cmdtest
|
|
|
|
|
|
|
|
import (
|
|
|
|
"log"
|
|
|
|
"os"
|
|
|
|
"os/exec"
|
|
|
|
"path/filepath"
|
|
|
|
"strings"
|
|
|
|
"testing"
|
|
|
|
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
)
|
|
|
|
|
|
|
|
// TestMain is initially called by go test to initiate the testing.
|
|
|
|
// TestMain is also called during the tests to start rclone main in a fresh context (using exec.Command).
|
|
|
|
// The context is determined by setting/finding the environment variable RCLONE_TEST_MAIN
|
|
|
|
func TestMain(m *testing.M) {
|
|
|
|
_, found := os.LookupEnv(rcloneTestMain)
|
|
|
|
if !found {
|
|
|
|
// started by Go test => execute tests
|
|
|
|
err := os.Setenv(rcloneTestMain, "true")
|
|
|
|
if err != nil {
|
|
|
|
log.Fatalf("Unable to set %s: %s", rcloneTestMain, err.Error())
|
|
|
|
}
|
|
|
|
os.Exit(m.Run())
|
|
|
|
} else {
|
|
|
|
// started by func rcloneExecMain => call rclone main in cmdtest.go
|
|
|
|
err := os.Unsetenv(rcloneTestMain)
|
|
|
|
if err != nil {
|
|
|
|
log.Fatalf("Unable to unset %s: %s", rcloneTestMain, err.Error())
|
|
|
|
}
|
|
|
|
main()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
const rcloneTestMain = "RCLONE_TEST_MAIN"
|
|
|
|
|
|
|
|
// rcloneExecMain calls rclone with the given environment and arguments.
|
|
|
|
// The environment variables are in a single string separated by ;
|
|
|
|
// The terminal output is retuned as a string.
|
|
|
|
func rcloneExecMain(env string, args ...string) (string, error) {
|
|
|
|
_, found := os.LookupEnv(rcloneTestMain)
|
|
|
|
if !found {
|
|
|
|
log.Fatalf("Unexpected execution path: %s is missing.", rcloneTestMain)
|
|
|
|
}
|
|
|
|
// make a call to self to execute rclone main in a predefined environment (enters TestMain above)
|
|
|
|
command := exec.Command(os.Args[0], args...)
|
|
|
|
command.Env = getEnvInitial()
|
|
|
|
if env != "" {
|
|
|
|
command.Env = append(command.Env, strings.Split(env, ";")...)
|
|
|
|
}
|
|
|
|
out, err := command.CombinedOutput()
|
|
|
|
return string(out), err
|
|
|
|
}
|
|
|
|
|
|
|
|
// rcloneEnv calls rclone with the given environment and arguments.
|
|
|
|
// The environment variables are in a single string separated by ;
|
|
|
|
// The test config file is automatically configured in RCLONE_CONFIG.
|
|
|
|
// The terminal output is retuned as a string.
|
|
|
|
func rcloneEnv(env string, args ...string) (string, error) {
|
|
|
|
envConfig := env
|
|
|
|
if testConfig != "" {
|
|
|
|
if envConfig != "" {
|
|
|
|
envConfig += ";"
|
|
|
|
}
|
|
|
|
envConfig += "RCLONE_CONFIG=" + testConfig
|
|
|
|
}
|
|
|
|
return rcloneExecMain(envConfig, args...)
|
|
|
|
}
|
|
|
|
|
|
|
|
// rclone calls rclone with the given arguments, E.g. "version","--help".
|
|
|
|
// The test config file is automatically configured in RCLONE_CONFIG.
|
|
|
|
// The terminal output is retuned as a string.
|
|
|
|
func rclone(args ...string) (string, error) {
|
|
|
|
return rcloneEnv("", args...)
|
|
|
|
}
|
|
|
|
|
|
|
|
// getEnvInitial returns the os environment variables cleaned for RCLONE_ vars (except RCLONE_TEST_MAIN).
|
|
|
|
func getEnvInitial() []string {
|
|
|
|
if envInitial == nil {
|
|
|
|
// Set initial environment variables
|
|
|
|
osEnv := os.Environ()
|
|
|
|
for i := range osEnv {
|
|
|
|
if !strings.HasPrefix(osEnv[i], "RCLONE_") || strings.HasPrefix(osEnv[i], rcloneTestMain) {
|
|
|
|
envInitial = append(envInitial, osEnv[i])
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return envInitial
|
|
|
|
}
|
|
|
|
|
|
|
|
var envInitial []string
|
|
|
|
|
|
|
|
// createTestEnvironment creates a temporary testFolder and
|
|
|
|
// sets testConfig to testFolder/rclone.config.
|
|
|
|
func createTestEnvironment(t *testing.T) {
|
|
|
|
//Set temporary folder for config and test data
|
2022-01-30 00:24:56 +08:00
|
|
|
tempFolder := t.TempDir()
|
cmdtest: end-to-end test for commands, flags and environment variables
There was no easy way to automatically test the end-to-end functionality
of commands, flags, environment variables etc.
The need for end-to-end testing was highlighted by the issues fixed
in #5341. There was no automated test to continually verify current
behaviour, nor a framework to quickly test the correctness of the fixes.
This change adds an end-to-end testing framework in the cmdtest folder.
It has some simple examples in func TestCmdTest in cmdtest_test.go. The
tests should be readable by anybody familiar with rclone and look like
this:
// Test the rclone version command with debug logging (-vv)
out, err = rclone("version", "-vv")
if assert.NoError(t, err) {
assert.Contains(t, out, "rclone v")
assert.Contains(t, out, "os/version:")
assert.Contains(t, out, " DEBUG : ")
}
The end-to-end tests are executed just like the Go unit tests, that is:
go test ./cmdtest -v
The change also contains a thorough test of environment variables in
environment_test.go.
Thanks to @ncw for encouragement and introduction to the TestMain trick.
2021-06-04 16:56:40 +08:00
|
|
|
testFolder = filepath.ToSlash(tempFolder)
|
|
|
|
|
|
|
|
// Set path to temporary config file
|
|
|
|
testConfig = testFolder + "/rclone.config"
|
|
|
|
}
|
|
|
|
|
|
|
|
var testFolder string
|
|
|
|
var testConfig string
|
|
|
|
|
|
|
|
// createTestFile creates the file testFolder/name
|
|
|
|
func createTestFile(name string, t *testing.T) string {
|
2022-08-20 22:38:02 +08:00
|
|
|
err := os.WriteFile(testFolder+"/"+name, []byte("content_of_"+name), 0666)
|
cmdtest: end-to-end test for commands, flags and environment variables
There was no easy way to automatically test the end-to-end functionality
of commands, flags, environment variables etc.
The need for end-to-end testing was highlighted by the issues fixed
in #5341. There was no automated test to continually verify current
behaviour, nor a framework to quickly test the correctness of the fixes.
This change adds an end-to-end testing framework in the cmdtest folder.
It has some simple examples in func TestCmdTest in cmdtest_test.go. The
tests should be readable by anybody familiar with rclone and look like
this:
// Test the rclone version command with debug logging (-vv)
out, err = rclone("version", "-vv")
if assert.NoError(t, err) {
assert.Contains(t, out, "rclone v")
assert.Contains(t, out, "os/version:")
assert.Contains(t, out, " DEBUG : ")
}
The end-to-end tests are executed just like the Go unit tests, that is:
go test ./cmdtest -v
The change also contains a thorough test of environment variables in
environment_test.go.
Thanks to @ncw for encouragement and introduction to the TestMain trick.
2021-06-04 16:56:40 +08:00
|
|
|
require.NoError(t, err)
|
|
|
|
return testFolder + "/" + name
|
|
|
|
}
|
|
|
|
|
|
|
|
// createTestFolder creates the folder testFolder/name
|
|
|
|
func createTestFolder(name string, t *testing.T) string {
|
|
|
|
err := os.Mkdir(testFolder+"/"+name, 0777)
|
|
|
|
require.NoError(t, err)
|
|
|
|
return testFolder + "/" + name
|
|
|
|
}
|
|
|
|
|
|
|
|
// createSimpleTestData creates simple test data in testFolder/subFolder
|
|
|
|
func createSimpleTestData(t *testing.T) string {
|
|
|
|
createTestFolder("testdata", t)
|
|
|
|
createTestFile("testdata/file1.txt", t)
|
|
|
|
createTestFile("testdata/file2.txt", t)
|
|
|
|
createTestFolder("testdata/folderA", t)
|
|
|
|
createTestFile("testdata/folderA/fileA1.txt", t)
|
|
|
|
createTestFile("testdata/folderA/fileA2.txt", t)
|
|
|
|
createTestFolder("testdata/folderA/folderAA", t)
|
|
|
|
createTestFile("testdata/folderA/folderAA/fileAA1.txt", t)
|
|
|
|
createTestFile("testdata/folderA/folderAA/fileAA2.txt", t)
|
|
|
|
createTestFolder("testdata/folderB", t)
|
|
|
|
createTestFile("testdata/folderB/fileB1.txt", t)
|
|
|
|
createTestFile("testdata/folderB/fileB2.txt", t)
|
|
|
|
|
2022-12-08 20:43:53 +08:00
|
|
|
t.Cleanup(func() {
|
|
|
|
err := os.RemoveAll(testFolder + "/testdata")
|
|
|
|
require.NoError(t, err)
|
|
|
|
})
|
|
|
|
|
|
|
|
return testFolder + "/testdata"
|
cmdtest: end-to-end test for commands, flags and environment variables
There was no easy way to automatically test the end-to-end functionality
of commands, flags, environment variables etc.
The need for end-to-end testing was highlighted by the issues fixed
in #5341. There was no automated test to continually verify current
behaviour, nor a framework to quickly test the correctness of the fixes.
This change adds an end-to-end testing framework in the cmdtest folder.
It has some simple examples in func TestCmdTest in cmdtest_test.go. The
tests should be readable by anybody familiar with rclone and look like
this:
// Test the rclone version command with debug logging (-vv)
out, err = rclone("version", "-vv")
if assert.NoError(t, err) {
assert.Contains(t, out, "rclone v")
assert.Contains(t, out, "os/version:")
assert.Contains(t, out, " DEBUG : ")
}
The end-to-end tests are executed just like the Go unit tests, that is:
go test ./cmdtest -v
The change also contains a thorough test of environment variables in
environment_test.go.
Thanks to @ncw for encouragement and introduction to the TestMain trick.
2021-06-04 16:56:40 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// TestCmdTest demonstrates and verifies the test functions for end-to-end testing of rclone
|
|
|
|
func TestCmdTest(t *testing.T) {
|
|
|
|
createTestEnvironment(t)
|
|
|
|
|
|
|
|
// Test simple call and output from rclone
|
|
|
|
out, err := rclone("version")
|
|
|
|
t.Logf("rclone version\n" + out)
|
|
|
|
if assert.NoError(t, err) {
|
|
|
|
assert.Contains(t, out, "rclone v")
|
|
|
|
assert.Contains(t, out, "version: ")
|
|
|
|
assert.NotContains(t, out, "Error:")
|
|
|
|
assert.NotContains(t, out, "--help")
|
|
|
|
assert.NotContains(t, out, " DEBUG : ")
|
|
|
|
assert.Regexp(t, "rclone\\s+v\\d+\\.\\d+", out) // rclone v_.__
|
|
|
|
}
|
|
|
|
|
|
|
|
// Test multiple arguments and DEBUG output
|
|
|
|
out, err = rclone("version", "-vv")
|
|
|
|
if assert.NoError(t, err) {
|
|
|
|
assert.Contains(t, out, "rclone v")
|
|
|
|
assert.Contains(t, out, " DEBUG : ")
|
|
|
|
}
|
|
|
|
|
|
|
|
// Test error and error output
|
|
|
|
out, err = rclone("version", "--provoke-an-error")
|
|
|
|
if assert.Error(t, err) {
|
|
|
|
assert.Contains(t, err.Error(), "exit status 1")
|
|
|
|
assert.Contains(t, out, "Error: unknown flag")
|
|
|
|
}
|
|
|
|
|
|
|
|
// Test effect of environment variable
|
|
|
|
env := "RCLONE_LOG_LEVEL=DEBUG"
|
|
|
|
out, err = rcloneEnv(env, "version")
|
|
|
|
if assert.NoError(t, err) {
|
|
|
|
assert.Contains(t, out, "rclone v")
|
|
|
|
assert.Contains(t, out, " DEBUG : ")
|
|
|
|
}
|
|
|
|
|
|
|
|
// Test effect of multiple environment variables, including one with ,
|
|
|
|
env = "RCLONE_LOG_LEVEL=DEBUG;RCLONE_LOG_FORMAT=date,shortfile;RCLONE_STATS=173ms"
|
|
|
|
out, err = rcloneEnv(env, "version")
|
|
|
|
if assert.NoError(t, err) {
|
|
|
|
assert.Contains(t, out, "rclone v")
|
|
|
|
assert.Contains(t, out, " DEBUG : ")
|
|
|
|
assert.Regexp(t, "[^\\s]+\\.go:\\d+:", out) // ___.go:__:
|
|
|
|
assert.Contains(t, out, "173ms")
|
|
|
|
}
|
|
|
|
|
|
|
|
// Test setup of config file
|
|
|
|
out, err = rclone("config", "create", "myLocal", "local")
|
|
|
|
if assert.NoError(t, err) {
|
|
|
|
assert.Contains(t, out, "[myLocal]")
|
|
|
|
assert.Contains(t, out, "type = local")
|
|
|
|
}
|
|
|
|
|
|
|
|
// Test creation of simple test data
|
|
|
|
createSimpleTestData(t)
|
|
|
|
|
|
|
|
// Test access to config file and simple test data
|
|
|
|
out, err = rclone("lsl", "myLocal:"+testFolder)
|
|
|
|
t.Logf("rclone lsl myLocal:testFolder\n" + out)
|
|
|
|
if assert.NoError(t, err) {
|
|
|
|
assert.Contains(t, out, "rclone.config")
|
|
|
|
assert.Contains(t, out, "testdata/folderA/fileA1.txt")
|
|
|
|
}
|
|
|
|
|
|
|
|
}
|