github-mirror/rclone
2
0
Fork 0
mirror of https://github.com/rclone/rclone.git synced 2024-11-22 10:54:48 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

vfs: error out early if can't upload 0 length file

Browse Source 
Before this change if a backend can't upload 0 length files and
`--vfs-cache-mode writes` was in use then the writeback logic would
try to upload the 0 length file forever.

This change causes it to exit on the first failure to upload.
This commit is contained in:
Nick Craig-Wood 2023-11-18 15:50:04 +00:00
parent ddaf01ece9
commit 168d577297
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
vfs/vfscache/item.go
View File

@ -593,6 +593,10 @@ func (item *Item) _store(ctx context.Context, storeFn StoreFn) (err error) {
o, err := operations.Copy(ctx, item.c.fremote, o, name, cacheObj) o, err := operations.Copy(ctx, item.c.fremote, o, name, cacheObj)
item.mu.Lock() item.mu.Lock()
if err != nil { if err != nil {
if errors.Is(err, fs.ErrorCantUploadEmptyFiles) {
fs.Errorf(name, "Writeback failed: %v", err)
return nil
}
return fmt.Errorf("vfs cache: failed to transfer file from cache to remote: %w", err) return fmt.Errorf("vfs cache: failed to transfer file from cache to remote: %w", err)
} }
item.o = o item.o = o