github-mirror/rclone
2
0
Fork 0
mirror of https://github.com/rclone/rclone.git synced 2024-11-22 12:36:38 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

config: reject remote names starting with a dash. (#4261)

Browse Source
This commit is contained in:
jtagcat 2020-06-16 13:34:03 +03:00 committed by Nick Craig-Wood
parent 62650a3eb3
commit 2d88d24881
2 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
fs/fspath/path.go
View File

@ -19,6 +19,7 @@ const (
var (
errInvalidCharacters = errors.New("config name contains invalid characters - may only contain 0-9, A-Z ,a-z ,_ , - and space ")
errCantBeEmpty = errors.New("can't use empty string as a path")
errCantStartWithDash = errors.New("config name starts with -")
// urlMatcher is a pattern to match an rclone URL
// note that this matches invalid remoteNames
@ -36,6 +37,10 @@ func CheckConfigName(configName string) error {
if !configNameMatcher.MatchString(configName) {
return errInvalidCharacters
}
// Reject configName, if it starts with -, complicates usage. (#4261)
if strings.HasPrefix(configName, "-") {
return errCantStartWithDash
}
return nil
}

3
fs/fspath/path_test.go
View File

@ -23,6 +23,9 @@ func TestCheckConfigName(t *testing.T) {
{"rem\\ote", errInvalidCharacters},
{"[remote", errInvalidCharacters},
{"*", errInvalidCharacters},
{"-remote", errCantStartWithDash},
{"r-emote-", nil},
{"_rem_ote_", nil},
} {
got := CheckConfigName(test.in)
assert.Equal(t, test.want, got, test.in)