From 75dfdbf211593ceabd2a84d4ccfe057c035e2a97 Mon Sep 17 00:00:00 2001 From: Nick Craig-Wood Date: Mon, 20 Mar 2023 14:17:18 +0000 Subject: [PATCH] ci: revert revive settings back to fix lint The upstream revive repo changed the default settings for this linter. We use this through golangci-lint. This change meant lots of errors appearing all at once. We should probably fix these in due course, but for the time being this disables those settings. See: https://github.com/mgechev/revive/pull/799 --- .golangci.yml | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/.golangci.yml b/.golangci.yml index 9828c53dd..40c6e76d2 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -28,3 +28,17 @@ issues: run: # timeout for analysis, e.g. 30s, 5m, default is 1m timeout: 10m + +linters-settings: + revive: + rules: + - name: unreachable-code + disabled: true + - name: unused-parameter + disabled: true + - name: empty-block + disabled: true + - name: redefines-builtin-id + disabled: true + - name: superfluous-else + disabled: true