From 8c1edf410ce71157e5a61b3865919e7622f266d7 Mon Sep 17 00:00:00 2001 From: Nick Craig-Wood Date: Tue, 8 Oct 2019 19:56:12 +0100 Subject: [PATCH] dropbox: make disallowed filenames return no retry error - fixes #3569 Before this change we silently skipped uploads to dropbox of disallowed file names. However this then caused "corrupted on transfer" errors because the sizes were wrong. After this change we return an no retry error which will mean that the sync fails (as it should - not all files were uploaded) but no unecessary retries happened. --- backend/dropbox/dropbox.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/backend/dropbox/dropbox.go b/backend/dropbox/dropbox.go index 9dbfa5c20..1ddefce12 100644 --- a/backend/dropbox/dropbox.go +++ b/backend/dropbox/dropbox.go @@ -1130,8 +1130,7 @@ func (o *Object) uploadChunked(in0 io.Reader, commitInfo *files.CommitInfo, size func (o *Object) Update(ctx context.Context, in io.Reader, src fs.ObjectInfo, options ...fs.OpenOption) error { remote := o.remotePath() if ignoredFiles.MatchString(remote) { - fs.Logf(o, "File name disallowed - not uploading") - return nil + return fserrors.NoRetryError(errors.Errorf("file name %q is disallowed - not uploading", path.Base(remote))) } commitInfo := files.NewCommitInfo(enc.FromStandardPath(o.remotePath())) commitInfo.Mode.Tag = "overwrite"